--- loncom/auth/lonroles.pm	2010/01/18 17:15:47	1.244
+++ loncom/auth/lonroles.pm	2010/06/02 14:49:38	1.247
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # User Roles Screen
 #
-# $Id: lonroles.pm,v 1.244 2010/01/18 17:15:47 raeburn Exp $
+# $Id: lonroles.pm,v 1.247 2010/06/02 14:49:38 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -57,8 +57,7 @@ course they should act on, etc. Both in
 handler determines via C<lonnet>'s C<&allowed> function that a certain
 action is not allowed, C<lonroles> is used as error handler. This
 allows the user to select another role which may have permission to do
-what they were trying to do. C<lonroles> can also be accessed via the
-B<CRS> button in the Remote Control. 
+what they were trying to do.
 
 =begin latex
 
@@ -145,19 +144,11 @@ use HTML::Entities;
  
 
 sub redirect_user {
-    my ($r,$title,$url,$msg,$launch_nav) = @_;
+    my ($r,$title,$url,$msg) = @_;
     $msg = $title if (! defined($msg));
     &Apache::loncommon::content_type($r,'text/html');
     &Apache::loncommon::no_cache($r);
     $r->send_http_header;
-    my $swinfo=&Apache::lonmenu::rawconfig();
-    my $navwindow;
-    if ($launch_nav eq 'on') {
-	$navwindow.=&Apache::lonnavdisplay::launch_win('now',undef,undef,
-						       ($url =~ m-^/adm/whatsnew-));
-    } else {
-	$navwindow.=&Apache::lonnavmaps::close();
-    }
 
     # Breadcrumbs
     my $brcrum = [{'href' => $url,
@@ -172,12 +163,6 @@ sub redirect_user {
     $url=~s/ /\%20/g;
     $r->print(<<ENDREDIR);
 $start_page
-<script type="text/javascript">
-// <![CDATA[
-$swinfo
-// ]]>
-</script>
-$navwindow
 <p>$msg</p>
 $end_page
 ENDREDIR
@@ -503,10 +488,9 @@ ENDENTERKEY
                                             my $esc_symb = &HTML::Entities::encode($env{'form.destsymb'},'"<>&');
                                             $dest .= '?symb='.$esc_symb;
                                         }
-                                        &redirect_user($r,&mt('Entering [_1]',
-                                                      $env{'course.'.$courseid.'.description'}),
-                                               $dest,$msg,
-                                               $env{'environment.remotenavmap'});
+                                        &redirect_user($r, &mt('Entering [_1]',
+                                                       $env{'course.'.$courseid.'.description'}),
+                                                       $dest, $msg);
                                         return OK;
                                     }
 				    if (&Apache::lonnet::allowed('whn',
@@ -519,9 +503,8 @@ ENDENTERKEY
 					unless ($startpage eq 'firstres') {         
 					    $msg = &mt('Entering [_1] ...',
 						       $env{'course.'.$courseid.'.description'});
-					    &redirect_user($r,&mt('New in course'),
-							   '/adm/whatsnew?refpage=start',$msg,
-							   $env{'environment.remotenavmap'});
+					    &redirect_user($r, &mt('New in course'),
+                                       '/adm/whatsnew?refpage=start', $msg);
 					    return OK;
 					}
 				    }
@@ -533,10 +516,9 @@ ENDENTERKEY
 				}
                                 $msg = &mt('Entering [_1] ...',
 					   $env{'course.'.$courseid.'.description'});
-				&redirect_user($r,&mt('Entering [_1]',
-						      $env{'course.'.$courseid.'.description'}),
-					       $furl,$msg,
-					       $env{'environment.remotenavmap'});
+				&redirect_user($r, &mt('Entering [_1]',
+                               $env{'course.'.$courseid.'.description'}),
+                               $furl, $msg);
 			    }
 			    return OK;
 			}
@@ -770,6 +752,13 @@ ENDHEADER
 	return OK;
     }
 # ----------------------------------------------------------------------- Table
+
+    if ($numdc > 0) {
+        $r->print(&coursepick_jscript());
+        $r->print(&Apache::loncommon::coursebrowser_javascript().
+                  &Apache::loncommon::authorbrowser_javascript());
+    }
+
     unless ((!&Apache::loncommon::show_course()) || ($nochoose) || ($countactive==1)) {
 	$r->print("<h2>".&mt('Select a Course to Enter')."</h2>\n");
     }
@@ -781,28 +770,29 @@ ENDHEADER
                       $env{'form.destsymb'}.'" />');
         }
     }
+
     my $doheaders = &roletable_headers($r,\%roleclass,\%sortrole,$nochoose);
     if ($env{'environment.recentroles'}) {
         my %recent_roles =
                &Apache::lonhtmlcommon::get_recent('roles',$env{'environment.recentrolesn'});
 	my $output='';
-	foreach (sort(keys(%recent_roles))) {
-	    if (ref($roletext{'user.role.'.$_}) eq 'ARRAY') {
+	foreach my $role (sort(keys(%recent_roles))) {
+	    if (ref($roletext{'user.role.'.$role}) eq 'ARRAY') {
 		$output.= &Apache::loncommon::start_data_table_row().
-                          $roletext{'user.role.'.$_}->[0].
+                          $roletext{'user.role.'.$role}->[0].
                           &Apache::loncommon::end_data_table_row().
                           &Apache::loncommon::continue_data_table_row().
-                          $roletext{'user.role.'.$_}->[1].
+                          $roletext{'user.role.'.$role}->[1].
                           &Apache::loncommon::end_data_table_row();
-                if ($_ =~ m-dc\./($match_domain)/- 
+                if ($role =~ m{dc\./($match_domain)/} 
 		    && $dcroles{$1}) {
 		    $output .= &adhoc_roles_row($1,'recent');
                 }
 	    } elsif ($numdc > 0) {
-                unless ($_ =~/^error\:/) {
+                unless ($role =~/^error\:/) {
                     $output.=&display_cc_role('user.role.'.$_);
                 }
-            } 
+            }
 	}
 	if ($output) {
 	    $r->print(&Apache::loncommon::start_data_table_empty_row()
@@ -815,12 +805,6 @@ ENDHEADER
             $doheaders ++;
 	}
     }
-
-    if ($numdc > 0) {
-        $r->print(&coursepick_jscript());
-        $r->print(&Apache::loncommon::coursebrowser_javascript().
-                  &Apache::loncommon::authorbrowser_javascript());
-    }
     &print_rolerows($r,$doheaders,\%roleclass,\%sortrole,\%dcroles,\%roletext);
     if ($countactive > 1) {
         my $tremark='';
@@ -1651,8 +1635,7 @@ course they should act on, etc. Both in
 handler determines via C<lonnet>'s C<&allowed> function that a certain
 action is not allowed, C<lonroles> is used as error handler. This
 allows the user to select another role which may have permission to do
-what they were trying to do. C<lonroles> can also be accessed via the
-B<CRS> button in the Remote Control. 
+what they were trying to do.
 
 =begin latex