--- loncom/homework/bridgetask.pm	2007/02/23 01:04:05	1.227
+++ loncom/homework/bridgetask.pm	2007/05/03 16:51:47	1.233
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA 
 # definition of tags that give a structure to a document
 #
-# $Id: bridgetask.pm,v 1.227 2007/02/23 01:04:05 albertel Exp $
+# $Id: bridgetask.pm,v 1.233 2007/05/03 16:51:47 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -38,7 +38,6 @@ use Apache::lonlocal;
 use Apache::lonxml;
 use Apache::slotrequest();
 use Time::HiRes qw( gettimeofday tv_interval );
-use lib '/home/httpd/lib/perl/';
 use LONCAPA;
  
 
@@ -488,6 +487,7 @@ sub webgrade_standard_info {
 	    'stop'   => 'Quit Grading',
 	    'fail'   => 'Fail Rest',
 	    'cancel' => 'Cancel',
+	    'submit' => 'Submit Grades',
 	    );
     %lt=&Apache::lonlocal::texthash(%lt);
 
@@ -495,26 +495,35 @@ sub webgrade_standard_info {
   <div class="LC_GRADING_maincontrols">
 INFO
 
-    if (&grade_mode() eq 'regrade') {
+    if ($env{'request.state'} eq 'construct') {
 	$result.=<<INFO;
+    <input type="submit" name="next" value="$lt{'submit'}" />
+INFO
+    } else {
+	if (&grade_mode() eq 'regrade' && $env{'request.state'} ne 'construct') {
+	    $result.=<<INFO;
     <input type="submit" name="cancel" value="$lt{'cancel'}" />
 INFO
-    }
+        }
 
-    $result.=<<INFO;
+	$result.=<<INFO;
     <input type="submit" name="next" value="$lt{'done'}" />
     <input type="submit" name="stop" value="$lt{'stop'}" />
+INFO
+    }
+    $result.=<<INFO;
     <input type="button" name="fail" value="$lt{'fail'}" 
            onclick="javascript:onFailRest()" />
   </div>
   $file_list
 INFO
     return $result;
+
 }
 
 sub done_screen {
     my ($version) = @_;
-    my $title=&Apache::lonnet::gettitle();
+    my $title=&Apache::lonnet::gettitle($env{'request.uri'});
     my @files=split(',',$Apache::lonhomework::history{'resource.'.$version.'.0.bridgetask.portfiles'});
     my (undef,undef,$domain,$user)= &Apache::lonnet::whichuser();
     my $files = '<ul>';
@@ -620,7 +629,7 @@ sub start_Task {
 	    }
 	}
     }
-    if ($target eq 'web' && $env{'request.state'} eq 'construct') {
+    if ($target =~/(web|webgrade)/ && $env{'request.state'} eq 'construct') {
 	$form_tag_start.=&Apache::structuretags::problem_web_to_edit_header($env{'form.rndseed'});
     }
     if ($target eq 'web' 
@@ -724,8 +733,12 @@ sub start_Task {
 	if ($todo) {
 	    &setup_env_for_other_user($todo,$safeeval);
 	    my ($symb,$uname,$udom)=&decode_queue_key($todo);
-	    $result.="\n".'<table><tr><td>Found '.
-		&Apache::lonnet::gettitle($symb).' for '.$uname.' at '.$udom.'</td></tr></table>';
+	    if ($env{'request.state'} eq 'construct') {
+		$symb = $env{'request.uri'};
+	    }
+	    $result.="\n".'<p>'.
+		&mt('Grading [_1] for [_2] at [_3]',
+		    &Apache::lonnet::gettitle($symb),$uname,$udom).'</p>';
 	    $form_tag_start.=
 		'<input type="hidden" name="gradingkey" value="'.
 		&escape($todo).'" />';
@@ -800,6 +813,12 @@ sub start_Task {
 		}
 	    }
 	    if ($webgrade eq 'yes') { $result.=&webgrade_standard_info(); }
+	} elsif ($target eq 'webgrade' 
+		 && $env{'request.state'} eq 'construct') {
+	    $result.=$form_tag_start;
+	    $result.='<input type="hidden" name="webgrade" value="'.
+		$webgrade.'" />';
+	    $result.=&webgrade_standard_info();
 	}
 	if ($target eq 'webgrade') {
 	    $result.="\n".'<div id="LC_GRADING_criterialist">';
@@ -847,6 +866,12 @@ sub get_key_todo {
     my ($target)=@_;
     my $todo;
 
+    if ($env{'request.state'} eq 'construct') {
+	my ($symb,$cid,$udom,$uname) = &Apache::lonnet::whichuser();
+	my $gradingkey=&encode_queue_key($symb,$udom,$uname);
+	return ($gradingkey);
+    }
+
     if (defined($env{'form.reviewasubmission'})) {
 	&Apache::lonxml::debug("review a submission....");
 	$env{'form.queue'}='reviewqueue';
@@ -1039,7 +1064,7 @@ sub end_Task {
 		}
 		if (!$previous && $status ne 'SHOW_ANSWER' &&
 		    &show_task($status,$previous)) {
-		    $result.=&Apache::inputtags::gradestatus('0');
+		    $result.=&Apache::inputtags::gradestatus('0',$target,1);
 		}
 		
 		$result.='</form>';
@@ -1057,8 +1082,7 @@ DONEBUTTON
 		if (&show_task($status,$previous) &&
 		    $Apache::lonhomework::history{"resource.$version.0.status"} =~ /^(pass|fail)$/) {
 		    my $bt_status=$Apache::lonhomework::history{"resource.$version.0.status"};
-		    my $title=&Apache::lonnet::gettitle();
-
+		    my $title=&Apache::lonnet::gettitle($env{'request.uri'});
 		    my $start_time;
 
 		    my $slot_name=
@@ -2200,8 +2224,8 @@ sub start_Dimension {
 	$result.=  
 	    &Apache::edit::text_arg('Id:','id',$token,10).' '.
 	    &Apache::edit::select_arg('Passing is Mandatory:','Mandatory',
-				      [['yes', 'Yes'],
-				       ['no','No'],],
+				      [['Y', 'Yes'],
+				       ['N','No'],],
 				      $token).' <br /> '.
 	    &Apache::edit::text_arg('Required number of passed optional elements to pass the '.$token->[1].':',
 				    'OptionalRequired',$token,4).
@@ -2839,41 +2863,12 @@ sub start_Criteria {
 	    push(@{$dimension{$dim}{'criterias'}},$id);
 	}
     } elsif ($target eq 'edit') {
-	if (0) {
-	    $result = &Apache::edit::tag_start($target,$token);
-	    my $text=&Apache::lonxml::get_all_text("/criteria",$parser);
-	    &Apache::lonnet::logthis("get_all_text criteria \n$text");
-	    my $local_parser = HTML::LCParser->new(\$text);
-	    $local_parser->xml_mode(1);
-	    $local_parser->marked_sections(1);
-	    while (1) {
-		my $criteria_text = 
-		    &Apache::lonxml::get_all_text('gradernote',$local_parser);
-		$result.=
-		    &Apache::edit::editfield($token->[1],$criteria_text,'',80,4);
-		
-		# check for a <GraderNote> next might be end
-		my $token = $local_parser->get_token();
-		# is the end
-		last if (!$token);
-		my $gradernote = &Apache::lonxml::get_all_text('/gradernote',
-							       $local_parser);
-		# purge the end tag
-		my $token = $local_parser->get_token();
-		$gradernote = '<GraderNote>'.$gradernote.'</GraderNote>';
-		@Apache::scripttag::parser_env = @_;
-		$result .= 
-		    &Apache::edit::end_row().&Apache::edit::start_spanning_row().
-		    &Apache::scripttag::xmlparse($gradernote).
-		    &Apache::edit::end_row().&Apache::edit::start_spanning_row();
-	    }
-	}
 	$result .=&Apache::edit::tag_start($target,$token);
 	$result.=  
 	    &Apache::edit::text_arg('Id:','id',$token,10).' '.
 	    &Apache::edit::select_arg('Passing is Mandatory:','Mandatory',
-				      [['yes', 'Yes'],
-				       ['no','No'],],
+				      [['Y', 'Yes'],
+				       ['N','No'],],
 				      $token)
 	    .' <br /> '.&Apache::edit::end_row().
 	    &Apache::edit::start_spanning_row();
@@ -3044,19 +3039,43 @@ sub proctor_validation_screen {
     my ($slot) = @_;
     my (undef,undef,$domain,$user) = &Apache::lonnet::whichuser();
     my $url=&Apache::lonnet::studentphoto($domain,$user,'jpg');
+    if ($url ne '/adm/lonKaputt/lonlogo_broken.gif') {
+	$url = "<tr><td colspan=\"2\"><img src=\"$url\" /></td></tr>";
+    } else {
+	undef($url);
+    }
+
     my $name=&Apache::loncommon::plainname($user,$domain);
     
     my $msg;
     if ($env{'form.proctorpassword'}) {
-	$msg='<p><font color="red">'.&mt("Failed to authenticate the proctor.")
-	    .'</font></p>';
+	$msg.='<p><span class="LC_warning">'
+	    .&mt("Failed to authenticate the proctor.")
+	    .'</span></p>';
     }
+
+    my $valid;
+    my @possible_proctors=split(",",$slot->{'proctor'});
+    foreach my $proctor (@possible_proctors) {
+	if ($proctor =~ /$LONCAPA::username_re:$LONCAPA::domain_re/) {
+	    $valid = 1;
+	    last;
+	}
+    }
+    if (!$valid) {
+	$msg.='<p><span class="LC_error">'
+	    .&mt("No valid poctors are defined.")
+	    .'</span></p>';
+    }
+    
     if (!$env{'form.proctordomain'}) { $env{'form.proctordomain'}=$domain; }
+    my $uri = &Apache::lonenc::check_encrypt($env{'request.uri'});
+    $uri = &HTML::Entities::encode($uri,'<>&"');
     my $result= (<<ENDCHECKOUT);
 <h2>Proctor Validation</h2>
     <p>Your room's proctor needs to validate your access to this resource.</p>
     $msg
-<form name="checkout" method="post" action="$env{'request.uri'}">
+<form name="checkout" method="post" action="$uri">
 <input type="hidden" name="validate" value="yes" />
 <input type="hidden" name="submitted" value="yes" />
 <table>
@@ -3072,7 +3091,7 @@ sub proctor_validation_screen {
       <tr><td>Name:</td><td>$name</td></tr>
       <tr><td>Student ID:</td><td>$env{'environment.id'}</td></tr>
       <tr><td>Usename</td><td>$user:$domain</td></tr>
-      <tr><td colspan="2"><img src="$url" /></td></tr>
+      $url
     </table>
   </tr></td>
 </table>