--- loncom/homework/inputtags.pm 2006/10/12 16:28:21 1.208
+++ loncom/homework/inputtags.pm 2008/12/10 22:54:12 1.248.2.2
@@ -1,7 +1,7 @@
# The LearningOnline Network with CAPA
# input definitons
#
-# $Id: inputtags.pm,v 1.208 2006/10/12 16:28:21 albertel Exp $
+# $Id: inputtags.pm,v 1.248.2.2 2008/12/10 22:54:12 raeburn Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -31,7 +31,6 @@ use strict;
use Apache::loncommon;
use Apache::lonlocal;
use Apache::lonnet;
-use lib '/home/httpd/lib/perl/';
use LONCAPA;
@@ -70,6 +69,10 @@ BEGIN {
# %Apache::inputtags::answertxt - <*response> tags store correct
# answer strings for display by
# in this hash.
+# %Apache::inputtags::submission_display
+# - <*response> tags store improved display
+# of submission strings for display by part
+# end.
sub initialize_inputtags {
@Apache::inputtags::input=();
@@ -88,6 +91,7 @@ sub initialize_inputtags {
@Apache::inputtags::importlist=();
$Apache::inputtags::response_with_no_part=0;
%Apache::inputtags::answertxt=();
+ %Apache::inputtags::submission_display=();
}
sub check_for_duplicate_ids {
@@ -111,8 +115,7 @@ sub check_for_duplicate_ids {
sub start_input {
my ($parstack,$safeeval)=@_;
- my $id = &Apache::lonxml::get_param('id',$parstack,$safeeval);
- if ($id eq '') { $id = $Apache::lonxml::curdepth; }
+ my $id = &Apache::lonxml::get_id($parstack,$safeeval);
push (@Apache::inputtags::input,$id);
push (@Apache::inputtags::inputlist,$id);
return $id;
@@ -283,7 +286,7 @@ sub needs_exam_box {
sub start_textline {
my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_;
my $result = "";
- my $id = &start_input($parstack,$safeeval);
+ my $input_id = &start_input($parstack,$safeeval);
if ($target eq 'web') {
$Apache::lonxml::evaluate--;
my $partid=$Apache::inputtags::part;
@@ -292,9 +295,20 @@ sub start_textline {
my $size = &Apache::lonxml::get_param('size',$parstack,$safeeval);
my $maxlength;
if ($size eq '') { $size=20; } else {
- if ($size < 20) { $maxlength=$size; }
+ if ($size < 20) {
+ $maxlength = ' maxlength="'.$size.'"';
+ }
+ }
+ my $oldresponse = $Apache::lonhomework::history{"resource.$partid.$id.submission"};
+ &Apache::lonxml::debug("oldresponse $oldresponse is ".ref($oldresponse));
+
+ if (ref($oldresponse) eq 'ARRAY') {
+ $oldresponse = $oldresponse->[$#Apache::inputtags::inputlist];
}
- my $oldresponse = &HTML::Entities::encode($Apache::lonhomework::history{"resource.$partid.$id.submission"},'<>&"');
+ $oldresponse = &HTML::Entities::encode($oldresponse,'<>&"');
+ $oldresponse =~ s/^\s+//;
+ $oldresponse =~ s/\s+$//;
+ $oldresponse =~ s/\s+/ /g;
if ($Apache::lonhomework::type ne 'exam') {
my $addchars=&Apache::lonxml::get_param('addchars',$parstack,$safeeval);
$result='';
@@ -313,8 +327,8 @@ sub start_textline {
if ($Apache::inputtags::status[-1] eq 'CANNOT_ANSWER') {
$name = "none";
}
- $result.= '';
+ $result.= '';
}
if ($Apache::lonhomework::type eq 'exam'
&& &needs_exam_box($tagstack)) {
@@ -344,8 +358,15 @@ sub start_textline {
&& $Apache::lonhomework::type ne 'exam') {
my $size = &Apache::lonxml::get_param('size',$parstack,$safeeval);
if ($size != 0) {$size=$size*2; $size.=' mm';} else {$size='40 mm';}
- $result='\framebox['.$size.'][s]{\tiny\strut}';
-
+ if ($env{'form.pdfFormFields'} eq 'yes') {
+ my $fieldname = $env{'request.symb'}.
+ '&part_'. $Apache::inputtags::part.
+ '&textresponse'.
+ '&HWVAL_' . $Apache::inputtags::response['-1'];
+ $result="\n\\\\\n".'\textField{'.$fieldname.'}{'.$size.'}{12 bp}';
+ } else {
+ $result='\framebox['.$size.'][s]{\tiny\strut}';
+ }
} elsif ($target eq 'tex'
&& $Apache::lonhomework::type eq 'exam'
&& &needs_exam_box($tagstack)) {
@@ -365,12 +386,18 @@ sub end_textline {
sub start_hiddenline {
my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_;
my $result = "";
+ my $input_id = &start_input($parstack,$safeeval);
if ($target eq 'web') {
$Apache::lonxml::evaluate--;
if ($Apache::inputtags::status[-1] eq 'CAN_ANSWER') {
my $partid=$Apache::inputtags::part;
my $id=$Apache::inputtags::response[-1];
- my $oldresponse = &HTML::Entities::encode($Apache::lonhomework::history{"resource.$partid.$id.submission"},'<>&"');
+ my $oldresponse = $Apache::lonhomework::history{"resource.$partid.$id.submission"};
+ if (ref($oldresponse) eq 'ARRAY') {
+ $oldresponse = $oldresponse->[$#Apache::inputtags::inputlist];
+ }
+ $oldresponse = &HTML::Entities::encode($oldresponse,'<>&"');
+
if ($Apache::lonhomework::type ne 'exam') {
$result= '';
@@ -393,19 +420,21 @@ sub end_hiddenline {
my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_;
if ($target eq 'web') { $Apache::lonxml::evaluate++; }
elsif ($target eq 'edit') { return ('','no'); }
+ &end_input();
return "";
}
# $part -> partid
# $id -> responseid
# $uploadefiletypes -> comma seperated list of extensions allowed or * for any
-# $which -> 'uploadedonly' -> only newly uploaded files
+# $which -> 'uploadonly' -> only newly uploaded files
# 'portfolioonly' -> only allow files from portfolio
# 'both' -> allow files from either location
# $extratext -> additional text to go between the link and the input box
+# $maxfilesize -> maximum cumulative filesize for submitted files (in MB).
# returns a table row
sub file_selector {
- my ($part,$id,$uploadedfiletypes,$which,$extratext)=@_;
+ my ($part,$id,$uploadedfiletypes,$which,$extratext,$maxfilesize)=@_;
if (!$uploadedfiletypes) { return ''; }
my $jspart=$part;
@@ -414,9 +443,16 @@ sub file_selector {
my $result;
$result.='
';
- if ($uploadedfiletypes ne '*') {
- $result.=
- &mt('Allowed filetypes: [_1]',$uploadedfiletypes).' ';
+ if (($uploadedfiletypes ne '*') || ($maxfilesize)) {
+ if ($uploadedfiletypes ne '*') {
+ $result.=
+ &mt('Allowed filetypes: [_1]',''.$uploadedfiletypes.'').' ';
+ }
+ if ($maxfilesize) {
+ $result.=&mt('Combined size of files not to exceed: [_1] MB[_2].',
+ ''.$maxfilesize.'').' ';
+ }
+ $result .= ' ';
}
if ($which eq 'uploadonly' || $which eq 'both') {
$result.=&mt('Submit a file: (only one file can be uploaded)').
@@ -428,12 +464,11 @@ sub file_selector {
$result.=' '.''.&mt('OR:').' ';
}
if ($which eq 'portfolioonly' || $which eq 'both') {
- $result.=$extratext.''.
+ $result.=$extratext.''.
&mt('Select Portfolio Files').' '.
''.
' ';
$result .= &show_past_portfile_submission($part,$id);
-
}
$result.='
";
+ }
+ }
+ }
+ my $tries = $Apache::lonhomework::history{"$prefix.tries"};
+ my $maxtries = &Apache::lonnet::EXT("resource.$id.maxtries");
+ &Apache::lonxml::debug("got maxtries of :$maxtries:");
+ #if tries are set to negative turn off the Tries/Button and messages
+ if (defined($maxtries) && $maxtries < 0) { return ''; }
+ if ( $tries eq '' ) { $tries = '0'; }
+ if ( $maxtries eq '' ) { $maxtries = '2'; }
+ if ( $maxtries eq 'con_lost' ) { $maxtries = '0'; }
+ my $tries_text=&mt('Tries');
+ if ( $Apache::lonhomework::type eq 'survey' ||
+ $Apache::lonhomework::parsing_a_task) {
+ $tries_text=&mt('Submissions');
+ }
+
+ if ($showbutton) {
+ if ($target eq 'tex') {
+ if ($env{'request.state'} ne "construct"
+ && $Apache::lonhomework::type ne 'exam'
+ && $env{'form.suppress_tries'} ne 'yes') {
+ $trystr = ' {\vskip 1 mm \small \textit{'.$tries_text.'} '.
+ $tries.'/'.$maxtries.'} \vskip 2 mm ';
+ } else {
+ $trystr = '\vskip 0 mm ';
+ }
+ } else {
+ $trystr = "
".$tries_text." $tries";
+ if ($Apache::lonhomework::parsing_a_task) {
+ } elsif($env{'request.state'} ne 'construct') {
+ $trystr.="/$maxtries";
+ } else {
+ if (defined($Apache::inputtags::params{'maxtries'})) {
+ $trystr.="/".$Apache::inputtags::params{'maxtries'};
+ }
+ }
+ $trystr.="
";
+ }
+ }
+
+ if ($Apache::lonhomework::history{"$prefix.afterduedate"}) {
+ #last submissions was after due date
+ $latemessage=&mt(' The last submission was after the Due Date ');;
+ if ($target eq 'web') {
+ $latemessage='
'.$latemessage.'
';
+ }
+ }
+ return ($previousmsg,$latemessage,$message,$trystr,$showbutton);
+}
+
sub gradestatus {
- my ($id,$target) = @_;
+ my ($id,$target,$no_previous) = @_;
my $showbutton = 1;
- my $bgcolor = '';
my $message = '';
my $latemessage = '';
my $trystr='';
@@ -995,72 +1223,27 @@ sub gradestatus {
&& $status ne 'INVALID_ACCESS'
&& $status ne 'NEEDS_CHECKIN'
&& $status ne 'NOT_IN_A_SLOT') {
- my $award = $Apache::lonhomework::history{"resource.$id.award"};
- my $awarded = $Apache::lonhomework::history{"resource.$id.awarded"};
- my $solved = $Apache::lonhomework::history{"resource.$id.solved"};
- my $previous = $Apache::lonhomework::history{"resource.$id.previous"};
- my $awardmsg = $Apache::lonhomework::history{"resource.$id.awardmsg"};
- &Apache::lonxml::debug("Found Award |$award|$solved|$awardmsg");
- if ( $award ne '' || $solved ne '' || $status eq 'SHOW_ANSWER') {
- &Apache::lonxml::debug('Getting message');
- ($showbutton,$bgcolor,$message,$previousmsg) =
- &decideoutput($award,$awarded,$awardmsg,$solved,$previous,
- $target);
- if ($target eq 'tex') {
- $message='\vskip 2 mm '.$message.' ';
- } else {
- $message="
$message
";
- if ($previousmsg) {
- $previousmsg="
$previousmsg
";
- }
- }
- }
- my $tries = $Apache::lonhomework::history{"resource.$id.tries"};
- my $maxtries = &Apache::lonnet::EXT("resource.$id.maxtries");
- &Apache::lonxml::debug("got maxtries of :$maxtries:");
- #if tries are set to negative turn off the Tries/Button and messages
- if (defined($maxtries) && $maxtries < 0) { return ''; }
- if ( $tries eq '' ) { $tries = '0'; }
- if ( $maxtries eq '' ) { $maxtries = '2'; }
- if ( $maxtries eq 'con_lost' ) { $maxtries = '0'; }
- my $tries_text=&mt('Tries');
- if ( $Apache::lonhomework::type eq 'survey' ||
- $Apache::lonhomework::parsing_a_task) {
- $tries_text=&mt('Submissions');
+
+ ($previousmsg,$latemessage,$message,$trystr) =
+ &get_grade_messages($id,"resource.$id",$target,$status,
+ $showbutton);
+ if ( $status eq 'SHOW_ANSWER' || $status eq 'CANNOT_ANSWER') {
+ $showbutton = 0;
}
- if ( $showbutton ) {
- if ($target eq 'tex') {
- if ($env{'request.state'} ne "construct" && $Apache::lonhomework::type ne 'exam' && $env{'form.suppress_tries'} ne 'yes') {
- $trystr = ' {\vskip 1 mm \small \textit{'.$tries_text.'} '.$tries.'/'.$maxtries.'} \vskip 2 mm ';
- } else {
- $trystr = '\vskip 0 mm ';
- }
- } else {
- $trystr = "
".$tries_text." $tries";
- if ($Apache::lonhomework::parsing_a_task) {
- } elsif($env{'request.state'} ne 'construct') {
- $trystr.="/$maxtries";
- } else {
- if (defined($Apache::inputtags::params{'maxtries'})) {
- $trystr.="/".$Apache::inputtags::params{'maxtries'};
- }
- }
- $trystr.="
";
- }
+ if ( $status eq 'SHOW_ANSWER') {
+ undef($previousmsg);
}
- if ( $status eq 'SHOW_ANSWER' || $status eq 'CANNOT_ANSWER') {$showbutton = 0;}
if ( $showbutton ) {
if ($target ne 'tex') {
- $button = '';
- }
- }
- if ($Apache::lonhomework::history{"resource.$id.afterduedate"}) {
- #last submissions was after due date
- $latemessage=&mt(' The last submission was after the Due Date ');;
- if ($target eq 'web') {
- $latemessage='
'.$latemessage.'
';
+ $button =
+ '';
}
}
+
}
my $output= $previousmsg.$latemessage.$message.$trystr;
if ($output =~ /^\s*$/) {
@@ -1069,10 +1252,112 @@ sub gradestatus {
if ($target eq 'tex') {
return $button.' \vskip 0 mm '.$output.' ';
} else {
- return '
'.$button.'
'.$output.'
';
+ $output =
+ '
'.$button.'
'.$output;
+ if (!$no_previous) {
+ $output.='
'.&previous_tries($id,$target).'
';
+ }
+ $output.= '
';
+ return $output;
}
}
}
+
+sub previous_tries {
+ my ($id,$target) = @_;
+ my $output;
+ my $status = $Apache::inputtags::status['-1'];
+
+ my $count;
+ my %count_lookup;
+
+ foreach my $i (1..$Apache::lonhomework::history{'version'}) {
+ my $prefix = $i.":resource.$id";
+
+ next if (!exists($Apache::lonhomework::history{"$prefix.award"}));
+ $count++;
+ $count_lookup{$i} = $count;
+
+ my ($previousmsg,$latemessage,$message,$trystr);
+
+ ($previousmsg,$latemessage,$message,$trystr) =
+ &get_grade_messages($id,"$prefix",$target,$status);
+
+ if ($previousmsg ne '') {
+ my ($match,$which) = &find_which_previous($i);
+ $message=$previousmsg;
+ my $previous = $count_lookup{$which};
+ $message =~ s{()}{ as submission \# $previous $1};
+ } elsif ($Apache::lonhomework::history{"$prefix.tries"}) {
+ if (!(&Apache::lonhomework::hide_problem_status()
+ && $Apache::inputtags::status[-1] ne 'SHOW_ANSWER')
+ && $Apache::lonhomework::history{"$prefix.solved"} =~/^correct/
+ ) {
+
+ my $txt_correct = &mt('Correct');
+ $message =~ s{()(.*?)()}
+ {$1 $txt_correct. $3}s;
+ }
+ my $trystr = "(".&mt('Try [_1]',$Apache::lonhomework::history{"$prefix.tries"}).")";
+ $message =~ s{()}{ $trystr $1};
+ }
+ my ($class) = ($message =~ m{)}{
};
+
+
+ $output.='
';
+ $output.='
'.$count.'
';
+ $output.=$message;
+
+ foreach my $resid (@Apache::inputtags::response) {
+ my $prefix = $prefix.".$resid";
+ if (exists($Apache::lonhomework::history{"$prefix.submission"})) {
+ my $submission =
+ $Apache::inputtags::submission_display{"$prefix.submission"};
+ if (!defined($submission)) {
+ $submission =
+ $Apache::lonhomework::history{"$prefix.submission"};
+ }
+ $output.='