--- loncom/interface/lonextresedit.pm	2017/11/30 14:41:20	1.21
+++ loncom/interface/lonextresedit.pm	2020/04/09 22:37:32	1.22.2.1
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Documents
 #
-# $Id: lonextresedit.pm,v 1.21 2017/11/30 14:41:20 raeburn Exp $
+# $Id: lonextresedit.pm,v 1.22.2.1 2020/04/09 22:37:32 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -258,7 +258,6 @@ sub process_changes {
 
 sub update_exttool {
     my ($marker,$cdom,$cnum,$args) = @_;
-    my %toolhash=&Apache::lonnet::dump('exttool_'.$marker,$cdom,$cnum);
     my (%newhash,$changed,@deleted,$errormsg);
     ($newhash{'target'},$newhash{'width'},$newhash{'height'},$newhash{'linktext'},$newhash{'explanation'},
      $newhash{'crslabel'},$newhash{'crstitle'},$newhash{'crsappend'}) = split(/:/,$args);
@@ -563,7 +562,7 @@ sub extedit_form {
                     '<div id="'.$toolattr{'crsappenddiv'}.'" style="'.$appendstyle.'">'.
                     '<span class="'.$class.'">'.&mt('Append to URL[_1]',
                     '<span id="'.$toolattr{'providerurl'}.'">&nbsp;('.$providerurl.')<br /></span>').
-                    '<input type="text" id="'.$toolattr{'crsappend'}.'" size="20" name="exttoolappend" value="'.$crsappend.'"'.$disabled.' /></span><br />'.
+                    '<input type="text" id="'.$toolattr{'crsappend'}.'" size="30" name="exttoolappend" value="'.$crsappend.'"'.$disabled.' /></span><br />'.
                     '</div>';
     }
     my $chooser = $toolelem;
@@ -673,6 +672,7 @@ sub extedit_javascript {
                     } else {
                         $providerurl = $toolsref->{$key}->{'url'};
                     }
+                    $providerurl = &LONCAPA::map::qtunescape($providerurl);
                     $toolsjs .= '        ltitools['.$i.'] = '."'$key';\n".
                                 '        ltitoolsTarget['.$i.'] = '."'$target';\n".
                                 '        ltitoolsWidth['.$i.'] = '."'$width';\n".
@@ -1018,13 +1018,13 @@ function updateExttool(caller,form,suppl
                                 document.getElementById(appenddiv).style.display = 'inline';
                                 if (document.getElementById(providerurl)) {
                                     if ((ltitoolsUrl[j] != '') && (ltitoolsUrl[j] != null)) {
-                                        document.getElementById(providerurl).innerHTML.value = '&nbsp;('+ltitoolsUrl[j]+')<br />';
+                                        document.getElementById(providerurl).innerHTML = '&nbsp;('+ltitoolsUrl[j]+')<br />';
                                     }
                                 }
                             } else {
                                 document.getElementById(appenddiv).style.display = 'none';
                                 if (document.getElementById(providerurl)) {
-                                    document.getElementById(providerurl).innerHTML.value = '';
+                                    document.getElementById(providerurl).innerHTML = '';
                                 }
                             }
                         }