--- loncom/interface/lonfeedback.pm 2006/07/18 17:42:15 1.211
+++ loncom/interface/lonfeedback.pm 2006/08/14 21:44:14 1.215
@@ -1,7 +1,7 @@
# The LearningOnline Network
# Feedback
#
-# $Id: lonfeedback.pm,v 1.211 2006/07/18 17:42:15 albertel Exp $
+# $Id: lonfeedback.pm,v 1.215 2006/08/14 21:44:14 albertel Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -186,8 +186,8 @@ sub list_discussion {
push @{$roleinfo{$student}}, 'st:'.$section.':'.$status;
}
($classgroups,$studentgroups) =
- &Apache::loncoursedata::get_group_memberships($classlist,$keylist,
- $cdom,$cnum);
+ &Apache::loncoursedata::get_group_memberships($classlist,$keylist,
+ $cdom,$cnum);
}
# Get discussion display default settings for user
@@ -713,8 +713,8 @@ END
if ($discussiononly) {
my $now = time;
my $attachnum = 0;
- my $currnewattach;
- my $currdelold;
+ my $currnewattach = [];
+ my $currdelold = [];
my $comment = '';
my $subject = '';
if ($env{'form.origpage'}) {
@@ -1683,7 +1683,7 @@ END
}
}
if ($attachmsg) {
- $r->print("Retained attachments:$attachmsg
\n");
+ $r->print("
Retained attachments:$attachmsg
\n");
}
if ($newattachmsg) {
$r->print("$newattachmsg
");
@@ -1930,8 +1930,8 @@ sub print_sortfilter_options {
unshift(@sections,'all'); # Put 'all' at the front of the list
}
- foreach (@sections) {
- $section_sel .= " $_\n";
+ foreach my $sec (@sections) {
+ $section_sel .= " \n";
}
if (&check_group_priv() eq 'ok') {
@@ -1956,8 +1956,8 @@ sub print_sortfilter_options {
$numgroupvis = 1;
}
}
- foreach (@groups) {
- $group_sel .= " $_\n";
+ foreach my $group (@groups) {
+ $group_sel .= " \n";
}
my $function = &Apache::loncommon::get_users_function();
@@ -2047,32 +2047,33 @@ $start_page