--- loncom/interface/lonnavmaps.pm	2023/01/20 22:45:51	1.509.2.14.2.6
+++ loncom/interface/lonnavmaps.pm	2024/07/01 18:13:20	1.509.2.15
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Navigate Maps Handler
 #
-# $Id: lonnavmaps.pm,v 1.509.2.14.2.6 2023/01/20 22:45:51 raeburn Exp $
+# $Id: lonnavmaps.pm,v 1.509.2.15 2024/07/01 18:13:20 raeburn Exp $
 
 #
 # Copyright Michigan State University Board of Trustees
@@ -945,31 +945,29 @@ sub render_resource {
     # links to open and close the folder
 
     my $whitespace = $location.'/whitespace_21.gif';
-    my ($nomodal,$linkopen,$linkclose);
-    unless ($resource->is_map() || $params->{'resource_nolink'}) {
-        $linkopen = "<img src='$whitespace' alt='' />";
-        $linkclose = "</a>";
-        if (($params->{'modalLink'}) && (!$resource->is_sequence())) {
-            if ($link =~m{^(?:|/adm/wrapper)/ext/([^#]+)}) {
-                my $exturl = $1;
-                if (($ENV{'SERVER_PORT'} == 443) && ($exturl !~ /^https:/)) {
-                    $nomodal = 1;
-                }
-            } elsif (($link eq "/public/$LONCAPA::match_domain/$LONCAPA::match_courseid/syllabus") &&
-                     ($env{'request.course.id'}) && ($ENV{'SERVER_PORT'} == 443) &&
-                     ($env{'course.'.$env{'request.course.id'}.'.externalsyllabus'} =~ m{^http://})) {
+    my $linkopen = "<img src='$whitespace' alt='' />";
+    my $nomodal;
+    if (($params->{'modalLink'}) && (!$resource->is_sequence())) {
+        if ($link =~m{^(?:|/adm/wrapper)/ext/([^#]+)}) {
+            my $exturl = $1;
+            if (($ENV{'SERVER_PORT'} == 443) && ($exturl !~ /^https:/)) {
                 $nomodal = 1;
             }
-            my $esclink = &js_escape($link);
-            if ($nomodal) {
-                $linkopen .= "<a href=\"#\" onclick=\"javascript:window.open('$esclink','resourcepreview','height=400,width=500,scrollbars=1,resizable=1,menubar=0,location=1'); return false;\" />";
-            } else {
-                $linkopen .= "<a href=\"$link\" onclick=\"javascript:openMyModal('$esclink',600,500,'yes','true'); return false;\">";
-            }
+        } elsif (($link eq "/public/$LONCAPA::match_domain/$LONCAPA::match_courseid/syllabus") &&
+                 ($env{'request.course.id'}) && ($ENV{'SERVER_PORT'} == 443) &&
+                 ($env{'course.'.$env{'request.course.id'}.'.externalsyllabus'} =~ m{^http://})) {
+             $nomodal = 1;
+        }
+        my $esclink = &js_escape($link);
+        if ($nomodal) {
+            $linkopen .= "<a href=\"#\" onclick=\"javascript:window.open('$esclink','resourcepreview','height=400,width=500,scrollbars=1,resizable=1,menubar=0,location=1'); return false;\" />";
         } else {
-            $linkopen .= "<a href=\"$link\">";
+            $linkopen .= "<a href=\"$link\" onclick=\"javascript:openMyModal('$esclink',600,500,'yes','true'); return false;\">";
         }
+    } else {
+        $linkopen .= "<a href=\"$link\">";
     }
+    my $linkclose = "</a>";
 
     # Default icon: unknown page
     my $icon = "<img class=\"LC_contentImage\" src='$location/unknown.gif' alt='' />";
@@ -997,12 +995,8 @@ sub render_resource {
         if ($it->{CONDITION}) {
             $nowOpen = !$nowOpen;
         }
-	my $folderType;
-	if (&advancedUser() && $resource->is_missing_map()) {
-	    $folderType = 'none';
-	} else {
-	    $folderType = $resource->is_sequence() ? 'folder' : 'page';
-	}
+	
+	my $folderType = $resource->is_sequence() ? 'folder' : 'page';
         my $title=$resource->title;
 		$title=~s/\"/\&qout;/g;
         if (!$params->{'resource_no_folder_link'}) {
@@ -1021,14 +1015,13 @@ sub render_resource {
                 '&amp;jump=' .
                 &escape($resource->symb()) . 
                 "&amp;folderManip=1\">";
-            $linkclose = '</a>';
+
         } else {
             # Don't allow users to manipulate folder
             $icon = "navmap.$folderType." . ($nowOpen ? 'closed' : 'open') . '.gif';
             $icon = "<img class=\"LC_space\" src='$whitespace' alt='' />"."<img class=\"LC_contentImage\" src='$location/$icon' alt=\"".($nowOpen ? &mt('Open Folder') : &mt('Close Folder')).' '.$title."\" />";
             if ($params->{'caller'} eq 'sequence') {
                 $linkopen = "<a href=\"$link\">";
-                $linkclose = '</a>';
             } else {
                 $linkopen = "";
                 $linkclose = "";
@@ -1047,30 +1040,10 @@ sub render_resource {
         }
         if ($params->{'mapHidden'} || $resource->randomout()) {
             $nonLinkedText .= ' <span class="LC_warning">('.&mt('hidden').')</span> ';
-        } elsif ($params->{'mapUnlisted'}) {
-            $nonLinkedText .= ' <span class="LC_warning">('.&mt('unlisted').')</span> ';
-        } elsif ($params->{'mapHiddenDeepLink'} || $resource->deeplinkout()) {
-            $nonLinkedText .= ' <span class="LC_warning">('.&mt('not shown').')</span> ';
         }
     } else {
         if ($resource->randomout()) {
             $nonLinkedText .= ' <span class="LC_warning">('.&mt('hidden').')</span> ';
-        } elsif ($resource->deeplinkout()) {
-            $nonLinkedText .= ' <span class="LC_warning">('.&mt('not shown').')</span> ';
-        } else {
-            my $deeplink = $resource->deeplink($params->{caller});
-            if ((($deeplink eq 'absent') || ($deeplink eq 'grades')) &&
-                  &advancedUser()) {
-                $nonLinkedText .= ' <span class="LC_warning">('.&mt('unlisted').')</span> ';
-            } elsif (($deeplink) && ($deeplink) ne 'full') {
-                if (&advancedUser()) {
-                    $nonLinkedText .= ' <span class="LC_warning">('.&mt('deep-link access').
-                                      ')</span> ';
-                } else {
-                    $nonLinkedText .= ' <span class="LC_warning">('.&mt('access via external site').
-                                      ')</span> ';
-                }
-            }
         }
     }
     if (!$resource->condval()) {
@@ -1395,49 +1368,15 @@ sub render {
         # an infinite loop
         my $oldFilterFunc = $filterFunc;
         $filterFunc = sub { my $res = shift; return !$res->randomout() && 
-                                ($res->deeplink($args->{'caller'}) ne 'absent') &&
-                                ($res->deeplink($args->{'caller'}) ne 'grades') &&
-                                !$res->deeplinkout() &&
                                 &$oldFilterFunc($res);};
     }
 
     my $condition = 0;
     if ($env{'form.condition'}) {
         $condition = 1;
-    } elsif (($env{'request.deeplink.login'}) && ($env{'request.course.id'}) && (!$userCanSeeHidden)) {
-        if (!defined($navmap)) {
-            $navmap = Apache::lonnavmaps::navmap->new();
-        }
-        if (defined($navmap)) {
-            my $cdom = $env{'course.'.$env{'request.course.id'}.'.domain'};
-            my $cnum = $env{'course.'.$env{'request.course.id'}.'.num'};
-            my $symb = &Apache::loncommon::symb_from_tinyurl($env{'request.deeplink.login'},$cnum,$cdom);
-            if ($symb) {
-                my $deeplink;
-                my $res = $navmap->getBySymb($symb);
-                if ($res->is_map()) {
-                    my $mapname = &Apache::lonnet::declutter($res->src());
-                    $mapname = &Apache::lonnet::deversion($mapname);
-                    $deeplink = $navmap->get_mapparam(undef,$mapname,"0.deeplink");
-                } else {
-                    $deeplink = $res->deeplink();
-                }
-                if ($deeplink ne '') {
-                    if ((split(/,/,$deeplink))[1] eq 'hide') {
-                        if ($res->is_map()) {
-                            map { $filterHash->{$_} = 1 if $_ } split(/,/,$res->map_hierarchy());
-                        } else {
-                            my $mapurl = (&Apache::lonnet::decode_symb($symb))[0];
-                            my $map = $navmap->getResourceByUrl($mapurl);
-                            map { $filterHash->{$_} = 1 if $_ } split(/,/,$map->map_hierarchy());
-                        }
-                    }
-                }
-            }
-        }
     }
 
-    if (!$env{'form.folderManip'} && !defined($args->{'iterator'}) && !$args->{'nocurrloc'}) {
+    if (!$env{'form.folderManip'} && !defined($args->{'iterator'})) {
         # Step 1: Check to see if we have a navmap
         if (!defined($navmap)) {
             $navmap = Apache::lonnavmaps::navmap->new();
@@ -1644,22 +1583,16 @@ END
 	}
 	$result.='</form>';
     }
-    if (($args->{'caller'} eq 'navmapsdisplay') && ($env{'request.course.id'})) {
+    if (($args->{'caller'} eq 'navmapsdisplay') &&
+        ((&Apache::lonnet::allowed('mdc',$env{'request.course.id'})) ||
+         (&Apache::lonnet::allowed('cev',$env{'request.course.id'})))) {
         my $cdom = $env{'course.'.$env{'request.course.id'}.'.domain'};
         my $cnum = $env{'course.'.$env{'request.course.id'}.'.num'};
-        if ($env{'course.'.$env{'request.course.id'}.'.url'} eq
+        if ($env{'course.'.$env{'request.course.id'}.'.url'} eq 
             "uploaded/$cdom/$cnum/default.sequence") {
-            if ((&Apache::lonnet::allowed('mdc',$env{'request.course.id'})) ||
-                (&Apache::lonnet::allowed('cev',$env{'request.course.id'}))) {
-                &add_linkitem($args->{'linkitems'},'edittoplevel',
-                              "javascript:gocmd('/adm/coursedocs','editdocs');",
-                              'Content Editor');
-            }
-            if ($counter) {
-                &add_linkitem($args->{'linkitems'},'printout',
-                              "javascript:gopost('/adm/printout','/adm/navmaps');",
-                              'Prepare a printable document');
-            }
+            &add_linkitem($args->{'linkitems'},'edittoplevel',
+                          "javascript:gocmd('/adm/coursedocs','editdocs');",
+                          'Content Editor');
         }
     }
 
@@ -1853,8 +1786,6 @@ END
 
         # If this is an empty sequence and we're filtering them, continue on
         $args->{'mapHidden'} = 0;
-        $args->{'mapUnlisted'} = 0;
-        $args->{'mapHiddenDeepLink'} = 0;
         if (($curRes->is_map()) && (!$curRes->{DATA}->{HAS_VISIBLE_CHILDREN})) {
             if ($args->{'suppressEmptySequences'}) {
                 next;
@@ -1867,22 +1798,6 @@ END
                     } else {
                         next;
                     }
-                } elsif ($curRes->deeplinkout) {
-                    if ($userCanSeeHidden) {
-                        $args->{'mapHiddenDeepLink'} = 1;
-                    } else {
-                        next;
-                    }
-                } else {
-                    my $deeplink = $navmap->get_mapparam(undef,$mapname,"0.deeplink");
-                    my ($state,$others,$listed) = split(/,/,$deeplink);
-                    if (($listed eq 'absent') || ($listed eq 'grades')) {
-                        if ($userCanSeeHidden) {
-                            $args->{'mapUnlisted'} = 1;
-                        } else {
-                            next;
-                        }
-                    }
                 }
             }
         }
@@ -1945,16 +1860,7 @@ END
 		    $args->{'condensed'} = 1;
 		}
             }
-        }
-        # If deep-link parameter is set (and is not set to full) suppress link
-        # unless privileged user, tinyurl used for login resolved to a map, and
-        # the resource is within the map.
-        if ((!$curRes->deeplink($args->{'caller'})) ||
-            ($curRes->deeplink($args->{'caller'}) eq 'full') || &advancedUser()) {
-            $args->{'resource_nolink'} = 0;
-        } else {
-            $args->{'resource_nolink'} = 1;
-        }
+        } 
             
         # If the multipart problem was condensed, "forget" it was multipart
         if (scalar(@parts) == 1) {
@@ -2107,7 +2013,7 @@ sub show_linkitems_toolbar {
             $result .= '<td align="left">'."\n".
                        '<ul id="LC_toolbar">';
             my @linkorder = ('firsthomework','everything','uncompleted',
-                             'changefolder','clearbubbles','printout','edittoplevel');
+                             'changefolder','clearbubbles','edittoplevel');
             foreach my $link (@linkorder) {
                 if (ref($args->{'linkitems'}{$link}) eq 'HASH') {
                     if ($args->{'linkitems'}{$link}{'text'} ne '') {
@@ -2520,7 +2426,7 @@ sub getIterator {
     my $self = shift;
     my $iterator = Apache::lonnavmaps::iterator->new($self, shift, shift,
                                                      shift, undef, shift,
-						     shift, shift, shift);
+						     shift, shift);
     return $iterator;
 }
 
@@ -2958,12 +2864,8 @@ sub recursed_crumbs {
         my $pc = $map->map_pc();
         next if ((!$pc) || ($pc == 1));
         push(@links,$map);
-        my $text = $map->title();
-        if ($text eq '') {
-            $text = '...';
-        }
-        push(@revmapinfo,{'href' => $env{'request.use_absolute'}.$map->link().'?navmap=1','text' => $text,'no_mt' => 1,});
-        $totallength += length($text);
+        push(@revmapinfo,{'href' => $env{'request.use_absolute'}.$map->link().'?navmap=1','text' => $map->title(),'no_mt' => 1,});
+        $totallength += length($map->title());
     }
     my $numlinks = scalar(@links);
     if ($numlinks) {
@@ -2975,11 +2877,7 @@ sub recursed_crumbs {
             }
             @revmapinfo = ();
             foreach my $map (@links) {
-                my $title = $map->title();
-                if ($title eq '') {
-                    $title = '...';
-                }
-                my $showntitle = &truncate_crumb_text($title,$avg);
+                my $showntitle = &truncate_crumb_text($map->title(),$avg);
                 if ($showntitle ne '') {
                     push(@revmapinfo,{'href' => $env{'request.use_absolute'}.$map->link().'?navmap=1','text' => $showntitle,'no_mt' => 1,});
                 }
@@ -3494,7 +3392,7 @@ getIterator behaves as follows:
 
 =over 4
 
-=item * B<getIterator>(firstResource, finishResource, filterHash, condition, forceTop, returnTopMap, $deeplinklisted):
+=item * B<getIterator>(firstResource, finishResource, filterHash, condition, forceTop, returnTopMap):
 
 All parameters are optional. firstResource is a resource reference
 corresponding to where the iterator should start. It defaults to
@@ -3511,10 +3409,7 @@ that is not just a single, 'redirecting'
 will return all information, starting with the top-level map,
 regardless of content. returnTopMap, if true (default false), will
 cause the iterator to return the top-level map object (resource 0.0)
-before anything else. deeplinklisted if true (default false), will
-check "listed" status of a resource with a deeplink, and unless "absent"
-will exclude deeplink checking when retrieving the browsePriv from
-lonnet::allowed().
+before anything else.
 
 Thus, by default, only top-level resources will be shown. Change the
 condition to a 1 without changing the hash, and all resources will be
@@ -3651,10 +3546,6 @@ sub new {
     # have we done that yet?
     $self->{HAVE_RETURNED_0} = 0;
 
-    # Do we want to check the "listed" status for a resource for which
-    # deeplinking applies.
-    $self->{DEEPLINKLISTED} = shift;
-
     # Now, we need to pre-process the map, by walking forward and backward
     # over the parts of the map we're going to look at.
 
@@ -3746,8 +3637,7 @@ sub new {
 						 $finishResource, $self->{FILTER},
 						 $self->{ALREADY_SEEN}, 
 						 $self->{CONDITION},
-						 $self->{FORCE_TOP},
-                                                 undef,$self->{DEEPLINKLISTED});
+						 $self->{FORCE_TOP});
     }
 
     # Set up some bookkeeping information.
@@ -3917,14 +3807,13 @@ sub next {
                                               $finishResource, $self->{FILTER},
                                               $self->{ALREADY_SEEN},
 					      $self->{CONDITION},
-					      $self->{FORCE_TOP},
-                                              undef,$self->{DEEPLINKLISTED});
+					      $self->{FORCE_TOP});
     }
 
     # If this is a blank resource, don't actually return it.
     # Should you ever find you need it, make sure to add an option to the code
     #  that you can use; other things depend on this behavior.
-    my $browsePriv = $self->{HERE}->browsePriv($noblockcheck,$self->{DEEPLINKLISTED});
+    my $browsePriv = $self->{HERE}->browsePriv($noblockcheck);
     if (!$self->{HERE}->src() || 
         (!($browsePriv eq 'F') && !($browsePriv eq '2')) ) {
         return $self->next($closeAllPages);
@@ -4352,7 +4241,6 @@ sub from { my $self=shift; return $self-
 sub goesto { my $self=shift; return $self->navHash("goesto_", 1); }
 sub kind { my $self=shift; return $self->navHash("kind_", 1); }
 sub randomout { my $self=shift; return $self->navHash("randomout_", 1); }
-sub deeplinkout { my $self=shift; return $self->navHash("deeplinkout_", 1); }
 sub randompick { 
     my $self = shift;
     my $randompick = $self->parmval('randompick');
@@ -4579,11 +4467,6 @@ sub is_sequence {
     return $self->navHash("is_map_", 1) && 
     $self->navHash("map_type_" . $self->map_pc()) eq 'sequence';
 }
-sub is_missing_map {
-    my $self=shift;
-    return $self->navHash("is_map_", 1) &&
-    $self->navHash("map_type_" . $self->map_pc()) eq 'none';
-}
 sub is_survey {
     my $self = shift();
     my $part = shift();
@@ -4613,6 +4496,7 @@ sub is_task {
 
 sub is_empty_sequence {
     my $self=shift;
+    my $src = $self->src();
     return !$self->is_page() && $self->navHash("is_map_", 1) && !$self->navHash("map_type_" . $self->map_pc());
 }
 
@@ -4933,12 +4817,11 @@ sub duedate {
     my $date;
     my @interval=$self->parmval("interval", $part);
     my $due_date=$self->parmval("duedate", $part);
-    if ($interval[0] =~ /(\d+)/) {
-        my $timelimit = $1;
-        my $first_access=&Apache::lonnet::get_first_access($interval[1],
+    if ($interval[0] =~ /\d+/) {
+       my $first_access=&Apache::lonnet::get_first_access($interval[1],
                                                           $self->{SYMB});
 	if (defined($first_access)) {
-            my $interval = $first_access+$timelimit;
+           my $interval = $first_access+$interval[0];
 	    $date = (!$due_date || $interval < $due_date) ? $interval 
                                                           : $due_date;
 	} else {
@@ -5032,46 +4915,6 @@ sub slot_control {
     my $available = $self->parmval("available", $part); 
     return ($useslots,$availablestudent,$available);
 }
-sub deeplink {
-    my ($self,$caller,$action) = @_;
-    my $deeplink = $self->parmval("deeplink");
-    if ($deeplink) {
-        my ($state,$others,$listed,$scope) = split(/,/,$deeplink);
-        if ($action eq 'getlisted') {
-            return $listed;
-        }
-        if ($env{'request.deeplink.login'}) {
-            my $cnum = $env{'course.'.$env{'request.course.id'}.'.num'};
-            my $cdom = $env{'course.'.$env{'request.course.id'}.'.domain'};
-            my $deeplink_symb = &Apache::loncommon::deeplink_login_symb($cnum,$cdom);
-            if ($deeplink_symb) {
-                my ($loginmap,$mapname);
-                if ($deeplink_symb =~ /\.(page|sequence)$/) {
-                    $mapname = $self->enclosing_map_src();
-                    $loginmap = &Apache::lonnet::clutter((&Apache::lonnet::decode_symb($deeplink_symb))[2]);
-                    return if ($mapname eq $loginmap);
-                } else {
-                    return if ($deeplink_symb eq $self->symb());
-                    if (($scope eq 'map') || ($scope eq 'rec')) {
-                        $mapname = $self->enclosing_map_src();
-                        $loginmap = &Apache::lonnet::clutter((&Apache::lonnet::decode_symb($deeplink_symb))[0]);
-                        return if ($mapname eq $loginmap);
-                    }
-                }
-                if ($scope eq 'rec') {
-                    my $map_pc = $self->navHash('map_pc_'.$mapname);
-                    my @recurseup = split(/,/,$self->navHash('map_hierarchy_'.$map_pc));
-                    my $login_pc = $self->navHash('map_pc_'.$loginmap);
-                    return if (grep(/^\Q$login_pc\E$/,@recurseup));
-                }
-            }
-        }
-        unless (($caller eq 'sequence') || ($state eq 'both')) {
-            return $listed;
-        }
-    }
-    return;
-}
 
 # Multiple things need this
 sub getReturnHash {
@@ -6203,23 +6046,13 @@ sub getPrevious {
 sub browsePriv {
     my $self = shift;
     my $noblockcheck = shift;
-    my $deeplinklisted = shift;
     if (defined($self->{BROWSE_PRIV})) {
         return $self->{BROWSE_PRIV};
     }
-    my ($nodeeplinkcheck,$nodeeplinkout);
-    if ($deeplinklisted) {
-        my $deeplink = $self->deeplink(undef,'getlisted');
-        if (($deeplink) && ($deeplink ne 'absent')) {
-            $nodeeplinkcheck = 1;
-        }
-        $nodeeplinkout = 1;
-    }
+
     $self->{BROWSE_PRIV} = &Apache::lonnet::allowed('bre',$self->src(),
 						    $self->{SYMB},undef,
-                                                    undef,$noblockcheck,
-                                                    undef,$nodeeplinkcheck,
-                                                    $nodeeplinkout);
+                                                    undef,$noblockcheck);
 }
 
 =pod