--- loncom/interface/lonnavmaps.pm	2003/06/13 13:58:06	1.203
+++ loncom/interface/lonnavmaps.pm	2003/07/21 20:25:42	1.217
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Navigate Maps Handler
 #
-# $Id: lonnavmaps.pm,v 1.203 2003/06/13 13:58:06 bowersj2 Exp $
+# $Id: lonnavmaps.pm,v 1.217 2003/07/21 20:25:42 bowersj2 Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -73,7 +73,7 @@ my %statusIconMap =
       $resObj->INCORRECT          => 'navmap.wrong.gif',
       $resObj->OPEN               => 'navmap.open.gif',
       $resObj->ATTEMPTED          => 'navmap.ellipsis.gif',
-      $resObj->ANSWER_SUBMITTED   => '' );
+      $resObj->ANSWER_SUBMITTED   => 'navmap.ellipsis.gif' );
 
 my %iconAltTags = 
     ( 'navmap.correct.gif' => 'Correct',
@@ -92,7 +92,10 @@ my %colormap =
       $resObj->TRIES_LEFT             => '',
       $resObj->INCORRECT              => '',
       $resObj->OPEN                   => '',
-      $resObj->NOTHING_SET            => '' );
+      $resObj->NOTHING_SET            => '',
+      $resObj->ATTEMPTED              => '',
+      $resObj->ANSWER_SUBMITTED       => ''
+      );
 # And a special case in the nav map; what to do when the assignment
 # is not yet done and due in less then 24 hours
 my $hurryUpColor = "#FF0000";
@@ -161,7 +164,6 @@ sub real_handler {
     # Now that we've displayed some stuff to the user, init the navmap
     $navmap->init();
 
-    $r->print('<br>&nbsp;');
     $r->rflush();
 
     # Check that it's defined
@@ -244,7 +246,7 @@ sub real_handler {
         }
     } else {
         $r->print("<a href='navmaps?jumpToFirstHomework'>" .
-                  "Go To My First Homework Problem</a><br />");
+                  "Go To My First Homework Problem</a>&nbsp;&nbsp;&nbsp;&nbsp;");
     }
 
     my $suppressEmptySequences = 0;
@@ -265,7 +267,7 @@ sub real_handler {
 	$resource_no_folder_link = 1;
     } else {
         $r->print("<a href='navmaps?showOnlyHomework'>" .
-                  "Show Only Uncompleted Homework</a><br />");
+                  "Show Only Uncompleted Homework</a>&nbsp;&nbsp;&nbsp;&nbsp;");
     }
 
     # renderer call
@@ -414,7 +416,7 @@ sub dueInLessThen24Hours {
     my $part = shift;
     my $status = $res->status($part);
 
-    return ($status == $res->OPEN() || $status == $res->ATTEMPTED() ||
+    return ($status == $res->OPEN() ||
             $status == $res->TRIES_LEFT()) &&
            $res->duedate() && $res->duedate() < time()+(24*60*60) &&
            $res->duedate() > time();
@@ -550,29 +552,74 @@ sub timeToHumanString {
 
 =head1 NAME
 
-Apache::lonnavmap - Subroutines to handle and render the navigation maps
+Apache::lonnavmap - Subroutines to handle and render the navigation
+    maps
 
 =head1 SYNOPSIS
 
 The main handler generates the navigational listing for the course,
 the other objects export this information in a usable fashion for
-other modules
+other modules.
 
-=head1 Object: render
+=head1 OVERVIEW
+
+X<lonnavmaps, overview> When a user enters a course, LON-CAPA examines the
+    course structure and caches it in what is often referred to as the
+    "big hash" X<big hash>. You can see it if you are logged into
+    LON-CAPA, in a course, by going to /adm/test. (You may need to
+    tweak the /home/httpd/lonTabs/htpasswd file to view it.) The
+    content of the hash will be under the heading "Big Hash".
+
+Big Hash contains, among other things, how resources are related
+to each other (next/previous), what resources are maps, which 
+resources are being chosen to not show to the student (for random
+selection), and a lot of other things that can take a lot of time
+to compute due to the amount of data that needs to be collected and
+processed.
+
+Apache::lonnavmaps provides an object model for manipulating this
+information in a higher-level fashion then directly manipulating 
+the hash. It also provides access to several auxilary functions 
+that aren't necessarily stored in the Big Hash, but are a per-
+resource sort of value, like whether there is any feedback on 
+a given resource.
+
+Apache::lonnavmaps also abstracts away branching, and someday, 
+conditions, for the times where you don't really care about those
+things.
+
+Apache::lonnavmaps also provides fairly powerful routines for
+rendering navmaps, and last but not least, provides the navmaps
+view for when the user clicks the NAV button.
+
+B<Note>: Apache::lonnavmaps I<only> works for the "currently
+logged in user"; if you want things like "due dates for another
+student" lonnavmaps can not directly retrieve information like
+that. You need the EXT function. This module can still help,
+because many things, such as the course structure, are constant
+between users, and Apache::lonnavmaps can help by providing
+symbs for the EXT call.
+
+The rest of this file will cover the provided rendering routines, 
+which can often be used without fiddling with the navmap object at
+all, then documents the Apache::lonnavmaps::navmap object, which
+is the key to accessing the Big Hash information, covers the use
+of the Iterator (which provides the logic for traversing the 
+somewhat-complicated Big Hash data structure), documents the
+Apache::lonnavmaps::Resource objects that are returned by 
+
+=head1 Subroutine: render
 
 The navmap renderer package provides a sophisticated rendering of the
 standard navigation maps interface into HTML. The provided nav map
 handler is actually just a glorified call to this.
 
-Because of the large number of parameters this function presents,
+Because of the large number of parameters this function accepts,
 instead of passing it arguments as is normal, pass it in an anonymous
-hash with the given options. This is because there is no obvious order
-you may wish to override these in and a hash is easier to read and
-understand then "undef, undef, undef, 1, undef, undef, renderButton,
-undef, 0" when you mostly want default behaviors.
+hash with the desired options.
 
 The package provides a function called 'render', called as
-Apache::lonnavmaps::renderer->render({}).
+Apache::lonnavmaps::render({}).
 
 =head2 Overview of Columns
 
@@ -580,7 +627,7 @@ The renderer will build an HTML table fo
 it. The table is consists of several columns, and a row for each
 resource (or possibly each part). You tell the renderer how many
 columns to create and what to place in each column, optionally using
-one or more of the preparent columns, and the renderer will assemble
+one or more of the prepared columns, and the renderer will assemble
 the table.
 
 Any additional generally useful column types should be placed in the
@@ -597,29 +644,33 @@ that takes a resource reference, a part
 argument hash passed to the renderer, and returns a string that will
 be inserted into the HTML representation as it.
 
+All other parameters are ways of either changing how the columns
+are printing, or which rows are shown.
+
 The pre-packaged column names are refered to by constants in the
-Apache::lonnavmaps::renderer namespace. The following currently exist:
+Apache::lonnavmaps namespace. The following currently exist:
 
 =over 4
 
-=item * B<resource>:
+=item * B<Apache::lonnavmaps::resource>:
 
 The general info about the resource: Link, icon for the type, etc. The
-first column in the standard nav map display. This column also accepts
-the following parameter in the renderer hash:
+first column in the standard nav map display. This column provides the
+indentation effect seen in the B<NAV> screen. This column also accepts
+the following parameters in the renderer hash:
 
 =over 4
 
-=item * B<resource_nolink>:
+=item * B<resource_nolink>: default false
 
-If true, the resource will not be linked. Default: false, resource
-will have links.
+If true, the resource will not be linked. By default, all non-folder
+resources are linked.
 
-=item * B<resource_part_count>:
+=item * B<resource_part_count>: default true
 
-If true (default), the resource will show a part count if the full
-part list is not displayed. If false, the resource will never show a
-part count.
+If true, the resource will show a part count B<if> the full
+part list is not displayed. (See "condense_parts" later.) If false,
+the resource will never show a part count.
 
 =item * B<resource_no_folder_link>:
 
@@ -629,19 +680,21 @@ can't close or open folders when this is
 
 =back
 
-=item B<communication_status>:
+=item B<Apache::lonnavmaps::communication_status>:
 
 Whether there is discussion on the resource, email for the user, or
 (lumped in here) perl errors in the execution of the problem. This is
 the second column in the main nav map.
 
-=item B<quick_status>:
+=item B<Apache::lonnavmaps::quick_status>:
 
-An icon for the status of a problem, with four possible states:
-Correct, incorrect, open, or none (not open yet, not a problem). The
+An icon for the status of a problem, with five possible states:
+Correct, incorrect, open, awaiting grading (for a problem where the
+computer's grade is suppressed, or the computer can't grade, like
+essay problem), or none (not open yet, not a problem). The
 third column of the standard navmap.
 
-=item B<long_status>:
+=item B<Apache::lonnavmaps::long_status>:
 
 A text readout of the details of the current status of the problem,
 such as "Due in 22 hours". The fourth column of the standard navmap.
@@ -664,9 +717,7 @@ to override vertical and horizontal alig
 
 =head2 Parameters
 
-Most of these parameters are only useful if you are *not* using the
-folder interface (i.e., the default first column), which is probably
-the common case. If you are using this interface, then you should be
+Minimally, you should be
 able to get away with just using 'cols' (to specify the columns
 shown), 'url' (necessary for the folders to link to the current screen
 correctly), and possibly 'queryString' if your app calls for it. In
@@ -675,7 +726,7 @@ automatically.
 
 =over 4
 
-=item * B<iterator>:
+=item * B<iterator>: default: constructs one from %ENV
 
 A reference to a fresh ::iterator to use from the navmaps. The
 rendering will reflect the options passed to the iterator, so you can
@@ -684,106 +735,106 @@ one is not passed, the renderer will att
 ENV{'form.filter'} and ENV{'form.condition'} information, plus the
 'iterator_map' parameter if any.
 
-=item * B<iterator_map>:
+=item * B<iterator_map>: default: not used
 
 If you are letting the renderer do the iterator handling, you can
 instruct the renderer to render only a particular map by passing it
 the source of the map you want to process, like
 '/res/103/jerf/navmap.course.sequence'.
 
-=item * B<navmap>:
+=item * B<navmap>: default: constructs one from %ENV
 
 A reference to a navmap, used only if an iterator is not passed in. If
 this is necessary to make an iterator but it is not passed in, a new
 one will be constructed based on ENV info. This is useful to do basic
 error checking before passing it off to render.
 
-=item * B<r>:
+=item * B<r>: default: must be passed in
 
 The standard Apache response object. This must be passed to the
 renderer or the course hash will be locked.
 
-=item * B<cols>:
+=item * B<cols>: default: empty (useless)
 
 An array reference
 
-=item * B<showParts>:
+=item * B<showParts>:default true
 
-A flag. If yes (default), a line for the resource itself, and a line
+A flag. If true, a line for the resource itself, and a line
 for each part will be displayed. If not, only one line for each
 resource will be displayed.
 
-=item * B<condenseParts>:
+=item * B<condenseParts>: default true
 
-A flag. If yes (default), if all parts of the problem have the same
+A flag. If true, if all parts of the problem have the same
 status and that status is Nothing Set, Correct, or Network Failure,
 then only one line will be displayed for that resource anyhow. If no,
 all parts will always be displayed. If showParts is 0, this is
 ignored.
 
-=item * B<jumpCount>:
+=item * B<jumpCount>: default: determined from %ENV
 
-A string identifying the URL to place the anchor 'curloc' at. Default
-to no anchor at all. It is the responsibility of the renderer user to
+A string identifying the URL to place the anchor 'curloc' at.
+It is the responsibility of the renderer user to
 ensure that the #curloc is in the URL. By default, determined through
 the use of the ENV{} 'jump' information, and should normally "just
 work" correctly.
 
-=item * B<here>:
+=item * B<here>: default: empty string
 
-A Symb identifying where to place the 'here' marker. Default empty,
-which means no marker.
+A Symb identifying where to place the 'here' marker. The empty
+string means no marker.
 
-=item * B<indentString>:
+=item * B<indentString>: default: 25 pixel whitespace image
 
-A string identifying the indentation string to use. By default, this
-is a 25 pixel whitespace image with no alt text.
+A string identifying the indentation string to use. 
 
-=item * B<queryString>:
+=item * B<queryString>: default: empty
 
 A string which will be prepended to the query string used when the
-folders are opened or closed.
+folders are opened or closed. You can use this to pass
+application-specific values.
 
-=item * B<url>:
+=item * B<url>: default: none
 
 The url the folders will link to, which should be the current
-page. Required if the resource info column is shown.
+page. Required if the resource info column is shown, and you 
+are allowing the user to open and close folders.
 
-=item * B<currentJumpIndex>:
+=item * B<currentJumpIndex>: default: no jumping
 
 Describes the currently-open row number to cause the browser to jump
 to, because the user just opened that folder. By default, pulled from
 the Jump information in the ENV{'form.*'}.
 
-=item * B<printKey>:
+=item * B<printKey>: default: false
 
 If true, print the key that appears on the top of the standard
-navmaps. Default is false.
+navmaps.
 
-=item * B<printCloseAll>:
+=item * B<printCloseAll>: default: true
 
 If true, print the "Close all folders" or "open all folders"
-links. Default is true.
+links.
 
-=item * B<filterFunc>:
+=item * B<filterFunc>: default: sub {return 1;} (accept everything)
 
 A function that takes the resource object as its only parameter and
 returns a true or false value. If true, the resource is displayed. If
-false, it is simply skipped in the display. By default, all resources
-are shown.
+false, it is simply skipped in the display.
 
-=item * B<suppressEmptySequences>:
+=item * B<suppressEmptySequences>: default: false
 
 If you're using a filter function, and displaying sequences to orient
 the user, then frequently some sequences will be empty. Setting this to
 true will cause those sequences not to display, so as not to confuse the
 user into thinking that if the sequence is there there should be things
-under it.
+under it; for example, see the "Show Uncompleted Homework" view on the
+B<NAV> screen.
 
-=item * B<suppressNavmaps>:
+=item * B<suppressNavmaps>: default: false
 
-If true, will not display Navigate Content resources. Default to
-false.
+If true, will not display Navigate Content resources. 
 
 =back
 
@@ -794,13 +845,19 @@ be passed through unchange to the column
 generate the following information which your renderer may find
 useful:
 
-If you want to know how many rows were printed, the 'counter' element
-of the hash passed into the render function will contain the
-count. You may want to check whether any resources were printed at
-all.
-
 =over 4
 
+=item * B<counter>: 
+
+Contains the number of rows printed. Useful after calling the render 
+function, as you can detect whether anything was printed at all.
+
+=item * B<isNewBranch>:
+
+Useful for renderers: If this resource is currently the first resource
+of a new branch, this will be true. The Resource column (leftmost in the
+navmaps screen) uses this to display the "new branch" icon 
+
 =back
 
 =cut
@@ -839,8 +896,8 @@ sub render_resource {
     my $linkopen = "<a href='$link'>";
     my $linkclose = "</a>";
 
-    # Default icon: HTML page
-    my $icon = "<img src='/adm/lonIcons/html.gif' alt='' border='0' />";
+    # Default icon: unknown page
+    my $icon = "<img src='/adm/lonIcons/unknown.gif' alt='' border='0' />";
     
     if ($resource->is_problem()) {
         if ($part eq '0' || $params->{'condensed'}) {
@@ -848,6 +905,13 @@ sub render_resource {
         } else {
             $icon = $params->{'indentString'};
         }
+    } else {
+	my $curfext= (split (/\./,$resource->src))[-1];
+	my $embstyle = &Apache::loncommon::fileembstyle($curfext);
+	# The unless conditional that follows is a bit of overkill
+	if (!(!defined($embstyle) || $embstyle eq 'unk' || $embstyle eq 'hdn')) {
+	    $icon = "<img src='/adm/lonIcons/$curfext.gif' alt='' border='0' />";
+	}
     }
 
     # Display the correct map icon to open or shut map
@@ -858,8 +922,10 @@ sub render_resource {
             $nowOpen = !$nowOpen;
         }
 
+	my $folderType = $resource->is_sequence() ? 'folder' : 'page';
+
         if (!$params->{'resource_no_folder_link'}) {
-            $icon = 'navmap.folder.' . ($nowOpen ? 'closed' : 'open') . '.gif';
+            $icon = "navmap.$folderType." . ($nowOpen ? 'closed' : 'open') . '.gif';
             $icon = "<img src='/adm/lonIcons/$icon' alt='' border='0' />";
 
             $linkopen = "<a href='" . $params->{'url'} . '?' . 
@@ -875,7 +941,7 @@ sub render_resource {
                 "&folderManip=1'>";
         } else {
             # Don't allow users to manipulate folder
-            $icon = 'navmap.folder.' . ($nowOpen ? 'closed' : 'open') .
+            $icon = "navmap.$folderType." . ($nowOpen ? 'closed' : 'open') .
                 '.nomanip.gif';
             $icon = "<img src='/adm/lonIcons/$icon' alt='' border='0' />";
 
@@ -924,7 +990,7 @@ sub render_resource {
     }
 
     if (!$params->{'resource_nolink'} && $src !~ /^\/uploaded\// &&
-	!$resource->is_map()) {
+	!$resource->is_sequence()) {
         $result .= "  $curMarkerBegin<a href='$link'>$title$partLabel</a>$curMarkerEnd $nonLinkedText</td>";
     } else {
         $result .= "  $curMarkerBegin$title$partLabel$curMarkerEnd $nonLinkedText</td>";
@@ -1010,7 +1076,7 @@ sub render_long_status {
         $params->{'multipart'} && $part eq "0";
                 
     my $color;
-    if ($resource->is_problem() && ($resource->countParts() <= 1 || $part ne '') ) {
+    if ($resource->is_problem()) {
         $color = $colormap{$resource->status};
         
         if (dueInLessThen24Hours($resource, $part) ||
@@ -1029,6 +1095,12 @@ sub render_long_status {
     if ($resource->is_map() && advancedUser() && $resource->randompick()) {
         $result .= '(randomly select ' . $resource->randompick() .')';
     }
+
+    # Debugging code
+    #$result .= " " . $resource->awarded($part) . '/' . $resource->weight($part) .
+    #	' - Part: ' . $part;
+
+    $result .= "</td>\n";
     
     return $result;
 }
@@ -1488,6 +1560,16 @@ sub render {
         }
     } continue {
         $curRes = $it->next();
+
+	if ($r) {
+	    # If we have the connection, make sure the user is still connected
+	    my $c = $r->connection;
+	    if ($c->aborted()) {
+		Apache::lonnet::logthis("navmaps aborted");
+		# Who cares what we do, nobody will see it anyhow.
+		return '';
+	    }
+	}
     }
     
     # Print out the part that jumps to #curloc if it exists
@@ -1520,30 +1602,52 @@ package Apache::lonnavmaps::navmap;
 
 =pod
 
-lonnavmaps provides functions and objects for dealing with the
-compiled course hashes generated when a user enters the course, the
-Apache handler for the "Navigation Map" button, and a flexible
-prepared renderer for navigation maps that are easy to use anywhere.
+=head1 Object: Apache::lonnavmaps::navmap
 
-=head1 Object: navmap
+=head2 Overview
 
-Encapsulating the compiled nav map
+The navmap object's job is to provide access to the resources
+in the course as Apache::lonnavmaps::resource objects, and to
+query and manage the relationship between those resource objects.
 
-navmap is an object that encapsulates a compiled course map and
-provides a reasonable interface to it.
+Generally, you'll use the navmap object in one of three basic ways.
+In order of increasing complexity and power:
 
-Most notably it provides a way to navigate the map sensibly and a
-flexible iterator that makes it easy to write various renderers based
-on nav maps.
+=over 4
 
-You must obtain resource objects through the navmap object.
+=item * C<$navmap-E<gt>getByX>, where X is B<Id>, B<Symb>, B<Url> or B<MapPc>. This provides
+    various ways to obtain resource objects, based on various identifiers.
+    Use this when you want to request information about one object or 
+    a handful of resources you already know the identities of, from some
+    other source. For more about Ids, Symbs, and MapPcs, see the
+    Resource documentation. Note that Url should be a B<last resort>,
+    not your first choice; it only works when there is only one
+    instance of the resource in the course, which only applies to
+    maps, and even that may change in the future.
+
+=item * C<my @resources = $navmap-E<gt>retrieveResources(args)>. This
+    retrieves resources matching some criterion and returns them
+    in a flat array, with no structure information. Use this when
+    you are manipulating a series of resources, based on what map
+    the are in, but do not care about branching, or exactly how
+    the maps and resources are related. This is the most common case.
+
+=item * C<$it = $navmap-E<gt>getIterator(args)>. This allows you traverse
+    the course's navmap in various ways without writing the traversal
+    code yourself. See iterator documentation below. Use this when
+    you need to know absolutely everything about the course, including
+    branches and the precise relationship between maps and resources.
 
-=head2 Methods
+=back
+
+=head2 Creation And Destruction
+
+To create a navmap object, use the following function:
 
 =over 4
 
-=item * B<new>(navHashFile, parmHashFile, genCourseAndUserOptions,
-  genMailDiscussStatus):
+=item * B<Apache::lonnavmaps::navmap-E<gt>new>(navHashFile, parmHashFile, 
+  genCourseAndUserOptions, genMailDiscussStatus, getUserData):
 
 Binds a new navmap object to the compiled nav map hash and parm hash
 given as filenames. genCourseAndUserOptions is a flag saying whether
@@ -1554,7 +1658,24 @@ documentation. genMailDiscussStatus caus
 information about the email and discussion status of
 resources. Returns the navmap object if this is successful, or
 B<undef> if not. You must check for undef; errors will occur when you
-try to use the other methods otherwise.
+try to use the other methods otherwise. getUserData, if true, will 
+retreive the user's performance data for various problems.
+
+=back
+
+Once you have the $navmap object, call ->init() on it when you are ready
+to use it. This allows you to check if the course map is defined (see
+B<courseMapDefined> below) before engaging in potentially expensive 
+initialization routines for the genCourseAndUserOptions and 
+genMailDiscussStatus option.
+
+When you are done with the $navmap object, you I<must> call 
+$navmap->untieHashes(), or you'll prevent the current user from using that 
+course until the web server is restarted. (!)
+
+=head2 Methods
+
+=over 4
 
 =item * B<getIterator>(first, finish, filter, condition):
 
@@ -1575,6 +1696,7 @@ sub new {
     $self->{PARM_HASH_FILE} = shift;
     $self->{GENERATE_COURSE_USER_OPT} = shift;
     $self->{GENERATE_EMAIL_DISCUSS_STATUS} = shift;
+    $self->{GET_USER_DATA} = shift;
 
     # Resource cache stores navmap resources as we reference them. We generate
     # them on-demand so we don't pay for creating resources unless we use them.
@@ -1712,7 +1834,15 @@ sub init {
         $self->{DISCUSSION_TIME} = \%discussiontime;
         $self->{EMAIL_STATUS} = \%emailstatus;
         
-    }    
+    }
+
+    if ($self->{GET_USER_DATA}) {
+	# Retreive performance data on problems
+	my %student_data = Apache::lonnet::currentdump($ENV{'request.course.id'},
+						       $ENV{'user.domain'},
+						       $ENV{'user.name'});
+	$self->{STUDENT_DATA} = \%student_data;
+    }
 
     $self->{PARM_CACHE} = {};
     $self->{INITED} = 1;
@@ -1725,6 +1855,15 @@ sub navhash {
     return $self->{NAV_HASH}->{$key};
 }
 
+=pod
+
+=item * B<courseMapDefined>(): Returns true if the course map is defined, 
+    false otherwise. Undefined course maps indicate an error somewhere in
+    LON-CAPA, and you will not be able to proceed with using the navmap.
+    See the B<NAV> screen for an example of using this.
+
+=cut
+
 # Checks to see if coursemap is defined, matching test in old lonnavmaps
 sub courseMapDefined {
     my $self = shift;
@@ -1806,7 +1945,6 @@ the given map. This is one of the proper
 # The strategy here is to cache the resource objects, and only construct them
 # as we use them. The real point is to prevent reading any more from the tied
 # hash then we have to, which should hopefully alleviate speed problems.
-# Caching is just an incidental detail I throw in because it makes sense.
 
 sub getById {
     my $self = shift;
@@ -2044,15 +2182,20 @@ sub retrieveResources {
         $map = $self->getResourceByUrl($map);
     }
 
+    # If nothing was passed, assume top-level map
+    if (!$map) {
+	$map = $self->getById('0.0');
+    }
+
     # Check the map's validity.
-    if (!$map || !$map->is_map()) {
+    if (!$map->is_map()) {
         # Oh, to throw an exception.... how I'd love that!
         return ();
     }
 
     # Get an iterator.
     my $it = $self->getIterator($map->map_start(), $map->map_finish(),
-                                !$recursive);
+                                undef, $recursive);
 
     my @resources = ();
 
@@ -2081,6 +2224,7 @@ sub retrieveResources {
             }
         }
 
+    } continue {
         $curRes = $it->next();
     }
 
@@ -2133,7 +2277,7 @@ corresponds to where you want the iterat
 navmap->finishResource(). filterHash is a hash used as a set
 containing strings representing the resource IDs, defaulting to
 empty. Condition is a 1 or 0 that sets what to do with the filter
-hash: If a 0, then only resource that exist IN the filterHash will be
+hash: If a 0, then only resources that exist IN the filterHash will be
 recursed on. If it is a 1, only resources NOT in the filterHash will
 be recursed on. Defaults to 0. forceTop is a boolean value. If it is
 false (default), the iterator will only return the first level of map
@@ -2157,21 +2301,21 @@ new branch. The possible tokens are:
 
 =over 4
 
-=item * BEGIN_MAP:
+=item * B<BEGIN_MAP>:
 
 A new map is being recursed into. This is returned I<after> the map
 resource itself is returned.
 
-=item * END_MAP:
+=item * B<END_MAP>:
 
 The map is now done.
 
-=item * BEGIN_BRANCH:
+=item * B<BEGIN_BRANCH>:
 
 A branch is now starting. The next resource returned will be the first
 in that branch.
 
-=item * END_BRANCH:
+=item * B<END_BRANCH>:
 
 The branch is now done.
 
@@ -2205,11 +2349,6 @@ sub min {
     if ($a < $b) { return $a; } else { return $b; }
 }
 
-# In the CVS repository, documentation of this algorithm is included 
-# in /doc/lonnavdocs, as a PDF and .tex source. Markers like **1**
-# will reference the same location in the text as the part of the
-# algorithm is running through.
-
 sub new {
     # magic invocation to create a class instance
     my $proto = shift;
@@ -2265,6 +2404,9 @@ sub new {
     # that isn't just a redirector.
     my $resource; my $resourceCount = 0;
 
+    # Documentation on this algorithm can be found in the CVS repository at 
+    # /docs/lonnavdocs; these "**#**" markers correspond to documentation
+    # in that file.
     # **1**
 
     foreach my $pass (@iterations) {
@@ -2730,8 +2872,9 @@ use Apache::lonnet;
 
 =pod
 
-=head1 Object: resource
+=head1 Object: resource 
 
+X<resource, navmap object>
 A resource object encapsulates a resource in a resource map, allowing
 easy manipulation of the resource, querying the properties of the
 resource (including user properties), and represents a reference that
@@ -2751,24 +2894,52 @@ writing, there is no way to override thi
 parts will never be returned, nor will their response types or ids be
 stored.
 
-=head2 Public Members
-
-resource objects have a hash called DATA ($resourceRef->{DATA}) that
-you can store whatever you want in. This allows you to easily do
-two-pass algorithms without worrying about managing your own
-resource->data hash.
+=head2 Overview
 
-=head2 Methods
-
-=over 4
-
-=item * B<new>($navmapRef, $idString):
-
-The first arg is a reference to the parent navmap object. The second
-is the idString of the resource itself. Very rarely, if ever, called
-directly. Use the nav map->getByID() method.
-
-=back
+A B<Resource> is the most granular type of object in LON-CAPA that can
+be included in a course. It can either be a particular resource, like
+an HTML page, external resource, problem, etc., or it can be a
+container sequence, such as a "page" or a "map".
+
+To see a sequence from the user's point of view, please see the
+B<Creating a Course: Maps and Sequences> chapter of the Author's
+Manual.
+
+A Resource Object, once obtained from a navmap object via a B<getBy*>
+method of the navmap, or from an iterator, allows you to query
+information about that resource.
+
+Generally, you do not ever want to create a resource object yourself,
+so creation has been left undocumented. Always retrieve resources
+from navmap objects.
+
+=head3 Identifying Resources
+
+X<big hash>Every resource is identified by a Resource ID in the big hash that is
+unique to that resource for a given course. X<resource ID, in big hash>
+The Resource ID has the form #.#, where the first number is the same
+for every resource in a map, and the second is unique. For instance,
+for a course laid out like this:
+
+ * Problem 1
+ * Map
+   * Resource 2
+   * Resource 3
+
+C<Problem 1> and C<Map> will share a first number, and C<Resource 2>
+C<Resource 3> will share a first number. The second number may end up
+re-used between the two groups.
+
+The resource ID is only used in the big hash, but can be used in the
+context of a course to identify a resource easily. (For instance, the
+printing system uses it to record which resources from a sequence you 
+wish to print.)
+
+X<symb> X<resource, symb>
+All resources also have B<symb>s, which uniquely identify a resource
+in a course. Many internal LON-CAPA functions expect a symb. A symb
+carries along with it the URL of the resource, and the map it appears
+in. Symbs are much larger then resource IDs.
 
 =cut
 
@@ -2807,14 +2978,21 @@ sub navHash {
 
 =pod
 
-B<Metadata Retreival>
+=head2 Methods
+
+Once you have a resource object, here's what you can do with it:
+
+=head3 Attribute Retrieval
 
-These are methods that help you retrieve metadata about the resource:
-Method names are based on the fields in the compiled course
-representation.
+Every resource has certain attributes that can be retrieved and used:
 
 =over 4
 
+=item * B<ID>: Every resource has an ID that is unique for that
+    resource in the course it is in. The ID is actually in the hash
+    representing the resource, so for a resource object $res, obtain
+    it via C<$res->{ID}).
+
 =item * B<compTitle>:
 
 Returns a "composite title", that is equal to $res->title() if the
@@ -2825,11 +3003,6 @@ resource has a title, and is otherwise t
 
 Returns true if the resource is external.
 
-=item * B<goesto>:
-
-Returns the "goesto" value from the compiled nav map. (It is likely
-you want to use B<getNext> instead.)
-
 =item * B<kind>:
 
 Returns the kind of the resource from the compiled nav map.
@@ -2857,11 +3030,6 @@ Returns the symb for the resource.
 
 Returns the title of the resource.
 
-=item * B<to>:
-
-Returns the "to" value from the compiled nav map. (It is likely you
-want to use B<getNext> instead.)
-
 =back
 
 =cut
@@ -2871,6 +3039,7 @@ want to use B<getNext> instead.)
 sub comesfrom { my $self=shift; return $self->navHash("comesfrom_", 1); }
 sub ext { my $self=shift; return $self->navHash("ext_", 1) eq 'true:'; }
 sub from { my $self=shift; return $self->navHash("from_", 1); }
+# considered private and undocumented
 sub goesto { my $self=shift; return $self->navHash("goesto_", 1); }
 sub kind { my $self=shift; return $self->navHash("kind_", 1); }
 sub randomout { my $self=shift; return $self->navHash("randomout_", 1); }
@@ -2891,7 +3060,15 @@ sub symb {
          $self->navHash('map_id_'.$first)) 
         . '___' . $second . '___' . $symbSrc;
 }
-sub title { my $self=shift; return $self->navHash("title_", 1); }
+sub title { 
+    my $self=shift; 
+    if ($self->{ID} eq '0.0') {
+	# If this is the top-level map, return the title of the course
+	# since this map can not be titled otherwise.
+	return $ENV{'course.'.$ENV{'request.course.id'}.'.description'};
+    }
+    return $self->navHash("title_", 1); }
+# considered private and undocumented
 sub to { my $self=shift; return $self->navHash("to_", 1); }
 sub compTitle {
     my $self = shift;
@@ -2943,7 +3120,8 @@ sub is_map { my $self=shift; return defi
 sub is_page {
     my $self=shift;
     my $src = $self->src();
-    return ($src =~ /page$/);
+    return $self->navHash("is_map_", 1) && 
+	$self->navHash("map_type_" . $self->map_pc()) eq 'page';
 }
 sub is_problem {
     my $self=shift;
@@ -2953,7 +3131,8 @@ sub is_problem {
 sub is_sequence {
     my $self=shift;
     my $src = $self->src();
-    return ($src =~ /sequence$/);
+    return $self->navHash("is_map_", 1) && 
+	$self->navHash("map_type_" . $self->map_pc()) eq 'sequence';
 }
 
 # Private method: Shells out to the parmval in the nav map, handler parts.
@@ -3028,8 +3207,6 @@ sub map_type {
     return $self->navHash("map_type_$pc", 0);
 }
 
-
-
 #####
 # Property queries
 #####
@@ -3067,6 +3244,11 @@ Get the Client IP/Name Access Control in
 
 Get the answer-reveal date for the problem.
 
+=item * B<awarded>: 
+
+Gets the awarded value for the problem part. Requires genUserData set to
+true when the navmap object was created.
+
 =item * B<duedate>:
 
 Get the due date for the problem.
@@ -3120,7 +3302,11 @@ sub answerdate {
     }
     return $self->parmval("answerdate", $part);
 }
-sub awarded { my $self = shift; return $self->queryRestoreHash('awarded', shift); }
+sub awarded { 
+    my $self = shift; my $part = shift;
+    if (!defined($part)) { $part = '0'; }
+    return $self->{NAV_MAP}->{STUDENT_DATA}->{$self->symb()}->{'resource.'.$part.'.awarded'};
+}
 sub duedate {
     (my $self, my $part) = @_;
     return $self->parmval("duedate", $part);
@@ -3161,7 +3347,12 @@ sub type {
 }
 sub weight { 
     my $self = shift; my $part = shift;
-    return $self->parmval("weight", $part);
+    if (!defined($part)) { $part = '0'; }
+    return &Apache::lonnet::EXT('resource.'.$part.'.weight',
+				$self->symb(), $ENV{'user.domain'},
+				$ENV{'user.name'}, 
+				$ENV{'request.course.sec'});
+
 }
 
 # Multiple things need this
@@ -3307,7 +3498,7 @@ sub responseType {
     my $part = shift;
 
     $self->extractParts();
-    return $self->{RESPONSE_TYPE}->{$part};
+    return $self->{RESPONSE_TYPES}->{$part};
 }
 
 sub responseIds {
@@ -3791,15 +3982,18 @@ sub completable {
         # "If any of the parts are open, or have tries left (implies open),
         # and it is not "attempted" (manually graded problem), it is
         # not "complete"
-        if (!(($status == OPEN() || $status == TRIES_LEFT()) 
-              && $self->getCompletionStatus($part) != ATTEMPTED()
-              && $status != ANSWER_SUBMITTED())) {
-            return 0;
-        }
+	if ($self->getCompletionStatus($part) == ATTEMPTED() ||
+	    $status == ANSWER_SUBMITTED() ) {
+	    # did this part already, as well as we can
+	    next;
+	}
+	if ($status == OPEN() || $status == TRIES_LEFT()) {
+	    return 1;
+	}
     }
         
     # If all the parts were complete, so was this problem.
-    return 1;
+    return 0;
 }
 
 =pod