--- loncom/interface/lonparmset.pm	2005/06/06 17:38:07	1.214
+++ loncom/interface/lonparmset.pm	2005/09/28 23:19:25	1.253
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to set parameters for assessments
 #
-# $Id: lonparmset.pm,v 1.214 2005/06/06 17:38:07 www Exp $
+# $Id: lonparmset.pm,v 1.253 2005/09/28 23:19:25 banghart Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -70,6 +70,8 @@ my $parmhashid;
 my %parmhash;
 my $symbsid;
 my %symbs;
+my $rulesid;
+my %rules;
 
 # --- end local caches
 
@@ -240,6 +242,38 @@ sub symbcache {
     return $symbs{$id};
 }
 
+sub resetrulescache {
+    $rulesid='';
+}
+
+sub rulescache {
+    my $id=shift;
+    if ($rulesid ne $env{'request.course.id'}) {
+	%rules=();
+    }
+    unless (defined($rules{$id})) {
+	my $dom = $env{'course.'.$env{'request.course.id'}.'.domain'};
+	my $crs = $env{'course.'.$env{'request.course.id'}.'.num'};
+	%rules=&Apache::lonnet::dump('parmdefactions',$dom,$crs);
+	$rulesid=$env{'request.course.id'};
+    }
+    return $rules{$id};
+}
+
+sub preset_defaults {
+    my $type=shift;
+    if (&rulescache($type.'_action') eq 'default') {
+# yes, there is something
+	return (&rulescache($type.'_hours'),
+		&rulescache($type.'_min'),
+		&rulescache($type.'_sec'),
+		&rulescache($type.'_value'));
+    } else {
+# nothing there or something else
+	return ('','','','','');
+    }
+}
+
 ##################################################
 ##################################################
 #
@@ -271,7 +305,57 @@ sub storeparm {
 # - username
 # - userdomain
 
+my %recstack;
 sub storeparm_by_symb {
+    my ($symb,$spnam,$snum,$nval,$ntype,$uname,$udom,$csec,$recflag)=@_;
+    unless ($recflag) {
+# first time call
+	%recstack=();
+	$recflag=1;
+    }
+# store parameter
+    &storeparm_by_symb_inner
+	($symb,$spnam,$snum,$nval,$ntype,$uname,$udom,$csec);
+    my ($prefix,$parm)=($spnam=~/^(.*[\_\.])([^\_\.]+)$/);
+# remember that this was set
+    $recstack{$parm}=1;
+# what does this trigger?
+    foreach my $triggered (split(/\:/,&rulescache($parm.'_triggers'))) {
+# don't backfire
+       unless ((!$triggered) || ($recstack{$triggered})) {
+	   my $action=&rulescache($triggered.'_action');
+	   my ($whichaction,$whichparm)=($action=~/^(.*\_)([^\_]+)$/);
+# set triggered parameter on same level
+	   my $newspnam=$prefix.$triggered;
+	   my $newvalue='';
+	   my $active=1;
+	   if ($action=~/^when\_setting/) {
+# are there restrictions?
+	       if (&rulescache($triggered.'_triggervalue')=~/\w/) {
+		   $active=0;
+		   foreach my $possiblevalue (split(/\s*\,\s*/,&rulescache($triggered.'_triggervalue'))) {
+		       if (lc($possiblevalue) eq lc($nval)) { $active=1; }
+		   }
+	       }
+	       $newvalue=&rulescache($triggered.'_value');
+	   } else {
+	       my $totalsecs=((&rulescache($triggered.'_days')*24+&rulescache($triggered.'_hours'))*60+&rulescache($triggered.'_min'))*60+&rulescache($triggered.'_sec');
+	       if ($action=~/^later\_than/) {
+		   $newvalue=$nval+$totalsecs;
+	       } else {
+		   $newvalue=$nval-$totalsecs;
+	       }
+	   }
+	   if ($active) {
+	       &storeparm_by_symb($symb,$newspnam,$snum,$newvalue,&rulescache($triggered.'_type'),
+				   $uname,$udom,$csec,$recflag);
+	   }
+       }
+    }
+    return '';
+}
+
+sub storeparm_by_symb_inner {
 # ---------------------------------------------------------- Get symb, map, etc
     my ($symb,$spnam,$snum,$nval,$ntype,$uname,$udom,$csec)=@_;
 # ---------------------------------------------------------- Construct prefixes
@@ -440,11 +524,12 @@ sub plink {
             $winvalue=$env{'form.recent_'.(split(/\_/,$type))[0]};
         }
     }
-
-
+    my ($parmname)=((split(/\&/,$marker))[1]=~/\_([^\_]+)$/);
+    my ($hour,$min,$sec,$val)=&preset_defaults($parmname);
+    unless (defined($winvalue)) { $winvalue=$val; }
     return 
 	'<a href="javascript:pjump('."'".$type."','".$dis."','".$winvalue."','"
-	    .$marker."','".$return."','".$call."'".');">'.
+	    .$marker."','".$return."','".$call."','".$hour."','".$min."','".$sec."'".');">'.
 		&valout($value,$type).'</a><a name="'.$marker.'"></a>';
 }
 
@@ -544,7 +629,10 @@ sub print_row {
     } else {    
         $parm=~s|\[.*\]\s||g;
     }
-
+    my $automatic=&rulescache(($which=~/\_([^\_]+)$/)[0].'_triggers');
+    if ($automatic) {
+	$parm.='<font color="red"><br />'.&mt('Automatically sets').' '.join(', ',split(/\:/,$automatic)).'</font>';
+    }
     $r->print('<td bgcolor='.$defbgone.'>'.$parm.'</td>');
    
     my $thismarker=$which;
@@ -776,8 +864,18 @@ sub parmmenu {
 	checkthis('duedate','pscat');
  	checkthis('opendate','pscat');
 	checkthis('answerdate','pscat');
-	checkthis('interval','pscat');
-   }
+    }
+
+    function checkdisset() {
+	checkthis('discussend','pscat');
+ 	checkthis('discusshide','pscat');
+    }
+
+    function checkcontdates() {
+	checkthis('contentopen','pscat');
+ 	checkthis('contentclose','pscat');
+    }
+ 
 
     function checkvisi() {
 	checkthis('hiddenresource','pscat');
@@ -806,12 +904,12 @@ ENDSCRIPT
     $r->print("\n<table><tr>");
     my $cnt=0;
     foreach $tempkey (&keysindisplayorder($allparms,$keyorder)) {
-	$r->print("\n<td><font size='-1'><input type='checkbox' name='pscat' ");
+	$r->print("\n<td><font size='-1'><label><input type='checkbox' name='pscat' ");
 	$r->print('value="'.$tempkey.'"');
 	if ($$pscat[0] eq "all" || grep $_ eq $tempkey, @{$pscat}) {
 	    $r->print(' checked');
 	}
-	$r->print('>'.$$allparms{$tempkey}.'</font></td>');
+	$r->print('>'.$$allparms{$tempkey}.'</label></font></td>');
  	$cnt++;
         if ($cnt==3) {
 	    $r->print("</tr>\n<tr>");
@@ -820,14 +918,16 @@ ENDSCRIPT
     }
     $r->print('
 </tr><tr><td>
-<a href="javascript:checkall(true, \'pscat\')">Select All</a>
-<a href="javascript:checkstandard()">Select Standard</a>
+<a href="javascript:checkall(true, \'pscat\')">Select&nbsp;All</a><br />
+<a href="javascript:checkstandard()">Select&nbsp;Common&nbsp;Only</a>
 </td><td>
-<a href="javascript:checkdates()">Select Dates</a>
-<a href="javascript:checkvisi()">Select Visibilities</a>
-<a href="javascript:checkparts()">Select Part Parameters</a>
+<a href="javascript:checkdates()">Add&nbsp;Problem&nbsp;Dates</a>
+<a href="javascript:checkcontdates()">Add&nbsp;Content&nbsp;Dates</a><br />
+<a href="javascript:checkdisset()">Add&nbsp;Discussion&nbsp;Settings</a>
+<a href="javascript:checkvisi()">Add&nbsp;Visibilities</a><br />
+<a href="javascript:checkparts()">Add&nbsp;Part&nbsp;Parameters</a>
 </td><td>
-<a href="javascript:checkall(false, \'pscat\')">Unselect All</a>
+<a href="javascript:checkall(false, \'pscat\')">Unselect&nbsp;All</a>
 </td>
 ');
     $r->print('</tr></table>');
@@ -841,7 +941,9 @@ sub partmenu {
     $r->print('>'.&mt('All Parts').'</option>');
     my %temphash=();
     foreach (@{$psprt}) { $temphash{$_}=1; }
-    foreach my $tempkey (sort keys %{$allparts}) {
+    foreach my $tempkey (sort {
+	if ($a==$b) { return ($a cmp $b) } else { return ($a <=> $b); }
+    } keys(%{$allparts})) {
 	unless ($tempkey =~ /\./) {
 	    $r->print('<option value="'.$tempkey.'"');
 	    if ($$psprt[0] eq "all" ||  $temphash{$tempkey}) {
@@ -903,7 +1005,7 @@ sub displaymenu {
 
 sub mapmenu {
     my ($r,$allmaps,$pschp,$maptitles)=@_;
-    $r->print(&mt('Select Enclosing Map or Folder').' ');
+    $r->print('<b>'.&mt('Select Enclosing Map or Folder').'</b> ');
     $r->print('<select name="pschp">');
     $r->print('<option value="all">'.&mt('All Maps or Folders').'</option>');
     foreach (sort {$$allmaps{$a} cmp $$allmaps{$b}} keys %{$allmaps}) {
@@ -916,8 +1018,8 @@ sub mapmenu {
 
 sub levelmenu {
     my ($r,$alllevs,$parmlev)=@_;
-    $r->print(&mt('Select Parameter Level').
-	      &Apache::loncommon::help_open_topic('Course_Parameter_Levels').' ');
+    $r->print('<b>'.&mt('Select Parameter Level').
+	      &Apache::loncommon::help_open_topic('Course_Parameter_Levels').'</b> ');
     $r->print('<select name="parmlev">');
     foreach (reverse sort keys %{$alllevs}) {
 	$r->print('<option value="'.$$alllevs{$_}.'"');
@@ -965,6 +1067,18 @@ sub keysinorder {
     } (keys %{$name});
 }
 
+sub keysinorder_bytype {
+    my ($name,$keyorder)=@_;
+    return sort {
+	my $ta=(split('_',$a))[-1];
+	my $tb=(split('_',$b))[-1];
+	if ($$keyorder{'parameter_0_'.$ta} == $$keyorder{'parameter_0_'.$tb}) {
+	    return ($a cmp $b);
+	}
+	$$keyorder{'parameter_0_'.$ta} <=> $$keyorder{'parameter_0_'.$tb};
+    } (keys %{$name});
+}
+
 sub keysindisplayorder {
     my ($name,$keyorder)=@_;
     return sort {
@@ -974,16 +1088,17 @@ sub keysindisplayorder {
 
 sub sortmenu {
     my ($r,$sortorder)=@_;
-    $r->print('<br /><input type="radio" name="sortorder" value="realmstudent"');
+    $r->print('<br /><label><input type="radio" name="sortorder" value="realmstudent"');
     if ($sortorder eq 'realmstudent') {
        $r->print(' checked="on"');
     }
     $r->print(' />'.&mt('Sort by realm first, then student (group/section)'));
-    $r->print('<br /><input type="radio" name="sortorder" value="studentrealm"');
+    $r->print('</label><br /><label><input type="radio" name="sortorder" value="studentrealm"');
     if ($sortorder eq 'studentrealm') {
        $r->print(' checked="on"');
     }
-    $r->print(' />'.&mt('Sort by student (group/section) first, then realm'));
+    $r->print(' />'.&mt('Sort by student (group/section) first, then realm').
+	      '</label>');
 }
 
 sub standardkeyorder {
@@ -1004,7 +1119,9 @@ sub standardkeyorder {
 	    'parameter_0_ordered' => 15,
 	    'parameter_0_tol' => 16,
 	    'parameter_0_sig' => 17,
-	    'parameter_0_turnoffunit' => 18);
+	    'parameter_0_turnoffunit' => 18,
+            'parameter_0_discussend' => 19,
+            'parameter_0_discusshide' => 20);
 }
 
 ##################################################
@@ -1062,7 +1179,7 @@ sub assessparms {
     my $coursename=$env{'course.'.$env{'request.course.id'}.'.description'};
 
     $alllevs{'Resource Level'}='full';
-    $alllevs{'Map Level'}='map';
+    $alllevs{'Map/Folder Level'}='map';
     $alllevs{'Course Level'}='general';
 
     my %allparms;
@@ -1213,7 +1330,9 @@ sub assessparms {
     } else {
         my ($map,$id,$resource)=&Apache::lonnet::decode_symb($pssymb);
         $r->print(&mt('Specific Resource').": ".$resource.
-                  '<input type="hidden" value="'.$pssymb.'" name="symb"><br />');
+                  '<input type="hidden" value="'.$pssymb.'" name="symb">'.
+		  '<br /><label><b>'.&mt('Show all parts').': <input type="checkbox" name="psprt" value="all"'.
+		  ($env{'form.psprt'}?' checked="checked"':'').' /></b></label><br />');
     }
     &usermenu($r,$uname,$id,$udom,$csec);    
 
@@ -1358,14 +1477,9 @@ ENDTABLEHEADFOUR
 
                         $r->print('<td bgcolor='.$defbgone.
                                       ' rowspan='.$totalparms.
-                                      '><tt><font size=-1>');
-
-                        $r->print(' / res / ');
-                        $r->print(join(' / ', split(/\//,$mapp{$rid})));
+                                      '>'.$maptitles{$mapp{$rid}}.'</td>');
 
-                        $r->print('</font></tt></td>');
-
-                        foreach (&keysinorder(\%name,\%keyorder)) {
+                        foreach (&keysinorder_bytype(\%name,\%keyorder)) {
                             unless ($firstrow) {
                                 $r->print('<tr>');
                             } else {
@@ -1655,9 +1769,13 @@ sub crsenv {
         #
         # Let the user know we made the changes
         if ($name && defined($value)) {
+            my $failed_cloners;
             if ($name eq 'cloners') {
+                $value =~ s/\s//g;
                 $value =~ s/^,//;
                 $value =~ s/,$//;
+                # check requested clones are valid users.
+                $failed_cloners = &check_cloners(\$value,\@oldcloner);
             }
             my $put_result = &Apache::lonnet::put('environment',
                                                   {$name=>$value},$dom,$crs);
@@ -1674,6 +1792,18 @@ sub crsenv {
                 $setoutput.=&mt('Unable to set').' <b>'.$name.'</b> '.&mt('to').
 		    ' <b>'.$value.'</b> '.&mt('due to').' '.$put_result.'.<br />';
             }
+            if (($name eq 'cloners') && ($failed_cloners)) {
+                $setoutput.= &mt('Unable to include').' - <b>'.$failed_cloners.'</b>, '.
+                 &mt('reason').' - '.&mt('LON-CAPA user(s) do(es) not exist').
+                 '.<br />'.&mt('Please ').
+                 ' <a href="/adm/createuser">'.
+                 &mt('add the user(s)').'</a>, '.
+                 &mt('and then return to the ').
+                 '<a href="/admparmset?action=crsenv">'.
+                 &mt('Course Parameters page').'</a> '.
+                 &mt('to add the new user(s) to the list of possible cloners').
+                 '.<br />';
+            }
         }
     }
 # ------------------------- Re-init course environment entries for this session
@@ -1780,8 +1910,8 @@ sub crsenv {
              'anonymous_quiz'
                  => '<b>'.&mt('Anonymous quiz/exam').'</b><br />'.
                     ' (<tt><b>'.&mt('yes').'</b> '.&mt('to avoid print students names').' </tt>)',
-             'default_enrollment_start_date' => '<b>'.&mt('Default beginning date when enrolling students').'</b>',
-             'default_enrollment_end_date'   => '<b>'.&mt('Default ending date when enrolling students').'</b>',
+             'default_enrollment_start_date' => '<b>'.&mt('Default beginning date for student access.').'</b>',
+             'default_enrollment_end_date'   => '<b>'.&mt('Default ending date for student access.').'</b>',
              'nothideprivileged'   => '<b>'.&mt('Privileged users that should not be hidden on staff listings').'</b>'.
                                  '<br />(<tt>user:domain,user:domain,...</tt>)',
              'languages' => '<b>'.&mt('Languages used').'</b>',
@@ -1791,6 +1921,9 @@ sub crsenv {
 	     'disablesigfigs'
 	         => '<b>'.&mt('Disable checking of Significant Figures').'</b><br />'.
                     ' ('.&mt('"[_1]" to disable, anything else if not','<tt>yes</tt>').')',
+	     'disableexampointprint'
+	         => '<b>'.&mt('Disable automatically printing point values onto exams.').'</b><br />'.
+                    ' ('.&mt('"[_1]" to disable, anything else if not','<tt>yes</tt>').')',
 	     'tthoptions'
 	         => '<b>'.&mt('Default set of options to pass to tth/m when converting tex').'</b>'
              ); 
@@ -1817,10 +1950,11 @@ sub crsenv {
                              'default_enrollment_start_date',
                              'default_enrollment_end_date',
 			     'tthoptions',
-			     'disablesigfigs'
+			     'disablesigfigs',
+			     'disableexampointprint'
                              );
 	foreach my $parameter (sort(keys(%values))) {
-            unless ($parameter =~ m/^internal\./) {
+            unless (($parameter =~ m/^internal\./)||($parameter =~ m/^metadata\./)) {
                 if (! $descriptions{$parameter}) {
                     $descriptions{$parameter}=$parameter;
                     push(@Display_Order,$parameter);
@@ -2059,15 +2193,41 @@ sub listdata {
     my $pointer=0;
     $tableopen=0;
     my $foundkeys=0;
+    my %keyorder=&standardkeyorder();
     foreach my $thiskey (sort {
 	if ($sortorder eq 'realmstudent') {
-	    my ($astudent,$arealm)=($a=~/^$env{'request.course.id'}\.([^\.]+)\.(.+)\.[^\.]+$/);
-	    my ($bstudent,$brealm)=($b=~/^$env{'request.course.id'}\.([^\.]+)\.(.+)\.[^\.]+$/);
-            ($arealm cmp $brealm) || ($astudent cmp $bstudent);
+	    my ($astudent,$arealm)=($a=~/^\Q$env{'request.course.id'}\E\.\[([^\.]+)\]\.(.+)\.[^\.]+$/);
+	    my ($bstudent,$brealm)=($b=~/^\Q$env{'request.course.id'}\E\.\[([^\.]+)\]\.(.+)\.[^\.]+$/);
+	    if (!defined($astudent)) {
+		($arealm)=($a=~/^\Q$env{'request.course.id'}\E\.(.+)$/);
+	    }
+	    if (!defined($bstudent)) {
+		($brealm)=($b=~/^\Q$env{'request.course.id'}\E\.(.+)$/);
+	    }
+	    $arealm=~s/\.type//;
+	    my ($ares, $aparm) = ($arealm=~/^(.*)\.(.*)$/);
+	    $aparm=$keyorder{'parameter_0_'.$aparm};
+	    $brealm=~s/\.type//;
+	    my ($bres, $bparm) = ($brealm=~/^(.*)\.(.*)$/);
+	    $bparm=$keyorder{'parameter_0_'.$bparm};	   
+	    if ($ares eq $bres) {
+		if (defined($aparm) && defined($bparm)) {
+		    ($aparm <=> $bparm);
+		} elsif (defined($aparm)) {
+		    -1;
+		} elsif (defined($bparm)) {
+		    1;
+		} else {
+		    ($arealm cmp $brealm) || ($astudent cmp $bstudent);
+		}
+	    } else {
+		($arealm cmp $brealm) || ($astudent cmp $bstudent);
+	    }
 	} else {
 	    $a cmp $b;
 	}
     } keys %{$listdata}) {
+	 
 	if ($$listdata{$thiskey.'.type'}) {
             my $thistype=$$listdata{$thiskey.'.type'};
             if ($$resourcedata{$thiskey.'.type'}) {
@@ -2123,6 +2283,15 @@ sub listdata {
 		$oldpart=$part;
 	    }
 #
+# Preset defaults?
+#
+            my ($hour,$min,$sec,$val)=('','','','');
+	    unless ($$resourcedata{$thiskey}) {
+		my ($parmname)=($thiskey=~/\.(\w+)$/);
+		($hour,$min,$sec,$val)=&preset_defaults($parmname);
+	    }
+
+#
 # Ready to print
 #
 	    $r->print(&tablestart().'<tr><td><b>'.$name.
@@ -2133,14 +2302,40 @@ sub listdata {
 		my $jskey='key_'.$pointer;
 		$pointer++;
 		$r->print(
-			  &Apache::lonhtmlcommon::date_setter('overviewform',
+			  &Apache::lonhtmlcommon::date_setter('parmform',
 							      $jskey,
-						      $$resourcedata{$thiskey}).
+						      $$resourcedata{$thiskey},
+							      '',1,'','',$hour,$min,$sec).
 '<input type="hidden" name="datepointer_'.$thiskey.'" value="'.$jskey.'" />'
 			  );
+	    } elsif ($thistype eq 'string_yesno') {
+		my $showval;
+		if (defined($$resourcedata{$thiskey})) {
+		    $showval=$$resourcedata{$thiskey};
+		} else {
+		    $showval=$val;
+		}
+		$r->print('<label><input type="radio" name="set_'.$thiskey.
+			  '" value="yes"');
+		if ($showval eq 'yes') {
+		    $r->print(' checked="checked"');
+		}
+                $r->print(' />'.&mt('Yes').'</label> ');
+		$r->print('<label><input type="radio" name="set_'.$thiskey.
+			  '" value="no"');
+		if ($showval eq 'no') {
+		    $r->print(' checked="checked"');
+		}
+                $r->print(' />'.&mt('No').'</label>');
 	    } else {
+		my $showval;
+		if (defined($$resourcedata{$thiskey})) {
+		    $showval=$$resourcedata{$thiskey};
+		} else {
+		    $showval=$val;
+		}
 		$r->print('<input type="text" name="set_'.$thiskey.'" value="'.
-			  $$resourcedata{$thiskey}.'">');
+			  $showval.'">');
 	    }
 	    $r->print('<input type="hidden" name="typeof_'.$thiskey.'" value="'.
 		      $thistype.'">');
@@ -2152,8 +2347,7 @@ sub listdata {
 
 sub newoverview {
     my $r=shift;
-    my $bodytag=&Apache::loncommon::bodytag(
-                             'Set Course Assessment Parameters');
+    my $bodytag=&Apache::loncommon::bodytag('Set Parameters');
     my $dom = $env{'course.'.$env{'request.course.id'}.'.domain'};
     my $crs = $env{'course.'.$env{'request.course.id'}.'.num'};
     my $breadcrumbs = &Apache::lonhtmlcommon::breadcrumbs(undef,'Overview');
@@ -2182,7 +2376,7 @@ ENDOVER
 
     my %alllevs=();
     $alllevs{'Resource Level'}='full';
-    $alllevs{'Map Level'}='map';
+    $alllevs{'Map/Folder Level'}='map';
     $alllevs{'Course Level'}='general';
 
     my $csec=$env{'form.csec'};
@@ -2298,8 +2492,7 @@ ENDOVER
 
 sub overview {
     my $r=shift;
-    my $bodytag=&Apache::loncommon::bodytag(
-                             'Modify Course Assessment Parameters');
+    my $bodytag=&Apache::loncommon::bodytag('Modify Parameters');
     my $dom = $env{'course.'.$env{'request.course.id'}.'.domain'};
     my $crs = $env{'course.'.$env{'request.course.id'}.'.num'};
     my $breadcrumbs = &Apache::lonhtmlcommon::breadcrumbs(undef,'Overview');
@@ -2311,7 +2504,7 @@ $html
 </head>
 $bodytag
 $breadcrumbs
-<form method="post" action="/adm/parmset?action=setoverview" name="overviewform">
+<form method="post" action="/adm/parmset?action=setoverview" name="parmform">
 ENDOVER
 # Store modified
 
@@ -2338,25 +2531,76 @@ ENDOVER
 ##################################################
                                                                                             
 =pod
-                                                                                            
-=item change clone
-                                                                                            
+
+=item check_cloners
+
+Checks if new users included in list of allowed cloners
+are valid users.  Replaces supplied list with 
+cleaned list containing only users with valid usernames
+and domains.
+
+Inputs: $clonelist, $oldcloner 
+where $clonelist is ref to array of requested cloners,
+and $oldcloner is ref to array of currently allowed
+cloners.
+
+Returns: string - comma separated list of requested
+cloners (username:domain) who do not exist in system.
+
+=item change_clone
+
 Modifies the list of courses a user can clone (stored
-in the user's environemnt.db file), called when a
+in the user's environment.db file), called when a
 change is made to the list of users allowed to clone
 a course.
-                                                                                            
+
 Inputs: $action,$cloner
 where $action is add or drop, and $cloner is identity of 
 user for whom cloning ability is to be changed in course. 
-                                                                                            
-Returns: 
 
 =cut
                                                                                             
 ##################################################
 ##################################################
 
+sub extract_cloners {
+    my ($clonelist,$allowclone) = @_;
+    if ($clonelist =~ /,/) {
+        @{$allowclone} = split/,/,$clonelist;
+    } else {
+        $$allowclone[0] = $clonelist;
+    }
+}
+
+
+sub check_cloners {
+    my ($clonelist,$oldcloner) = @_;
+    my ($clean_clonelist,$disallowed);
+    my @allowclone = ();
+    &extract_cloners($$clonelist,\@allowclone);
+    foreach my $currclone (@allowclone) {
+        if (!grep/^$currclone$/,@$oldcloner) {
+            my ($uname,$udom) = split/:/,$currclone;
+            if ($uname && $udom) {
+                if (&Apache::lonnet::homeserver($uname,$udom) eq 'no_host') {
+                    $disallowed .= $currclone.',';   
+                } else {
+                    $clean_clonelist .= $currclone.',';
+                }
+            }
+        } else {
+            $clean_clonelist .= $currclone.',';
+        }
+    }
+    if ($disallowed) {
+        $disallowed =~ s/,$//;
+    }
+    if ($clean_clonelist) {
+        $clean_clonelist =~ s/,$//;
+    }
+    $$clonelist = $clean_clonelist;
+    return $disallowed;
+}  
 
 sub change_clone {
     my ($clonelist,$oldcloner) = @_;
@@ -2366,12 +2610,8 @@ sub change_clone {
     my $clone_crs = $cnum.':'.$cdom;
     
     if ($cnum && $cdom) {
-        my @allowclone = ();
-        if ($clonelist =~ /,/) {
-            @allowclone = split/,/,$clonelist;
-        } else {
-            $allowclone[0] = $clonelist;
-        }
+        my @allowclone;
+        &extract_cloners($clonelist,\@allowclone);
         foreach my $currclone (@allowclone) {
             if (!grep/^$currclone$/,@$oldcloner) {
                 ($uname,$udom) = split/:/,$currclone;
@@ -2462,28 +2702,31 @@ ENDMAINFORMHEAD
 	    action => 'crsenv',
             permission => $parm_permission,
             },
-          { text => 'Set/Modify Course Assessment Parameters - Helper Mode',
+          { text => 'Set Instructor Defined Metadata',
+	    action => 'setinstmeta',
+            permission => $parm_permission,
+            },
+          { text => 'Set/Modify Resource Parameters - Helper Mode',
             url => '/adm/helper/parameter.helper',
             permission => $parm_permission,
             },
-          { text => 'Modify Course Assessment Parameters - Overview Mode',
+          { text => 'Modify Resource Parameters - Overview Mode',
             action => 'setoverview',
             permission => $parm_permission,
             },          
-	  { text => 'Set Course Assessment Parameters - Overview Mode',
+	  { text => 'Set Resource Parameters - Overview Mode',
             action => 'newoverview',
             permission => $parm_permission,
             },
-          { text => 'Set/Modify Course Assessment Parameters - Table Mode',
+          { text => 'Set/Modify Resource Parameters - Table Mode',
             action => 'settable',
             permission => $parm_permission,
             help => 'Cascading_Parameters',
             },
-#          { text => 'Set Parameter Default Preferences',
-#            help => 'Course_View_Class_List',
-#            action => 'setdefaults',
-#            permission => $parm_permission,
-#            },
+          { text => 'Set Parameter Setting Default Actions',
+            action => 'setdefaults',
+            permission => $parm_permission,
+            },
           );
     my $menu_html = '';
     foreach my $menu_item (@menu) {
@@ -2506,9 +2749,288 @@ ENDMAINFORMHEAD
     $r->print($menu_html);
     return;
 }
+### Set instructor defined metadata
+sub output_row {
+    my ($r, $field_name) = @_;
+    my $output;
+    my $active=$env{'course.'.$env{'request.course.id'}.'.metadata.'.$field_name.'.active'};
+    my $onlyone=$env{'course.'.$env{'request.course.id'}.'.metadata.'.$field_name.'.onlyone'};
+    my $stuadd=$env{'course.'.$env{'request.course.id'}.'.metadata.'.$field_name.'.stuadd'};
+    my $values=$env{'course.'.$env{'request.course.id'}.'.metadata.'.$field_name.'.values'};
+    my $checked;
+    unless (defined($active)) {
+        $active = 'no';
+        $stuadd = 'yes';
+        $values = 'Type a list of values separated by commas.';
+        $onlyone = 'no';
+    }
+    $output.='<tr><td><strong>'.$field_name.'</strong></td>';
+    $output.='<td><input name="'.$field_name.'_values" type="text" value="'.$values.'" /></td>';
+    if ($onlyone eq 'no') {
+        $checked = ' CHECKED ';
+    } else {
+        $checked = ' ';
+    }
+    $output.='<td><center><input type="checkbox" name="'.$field_name.'_onlyone"" value="yes"'.$checked.' /></center></td>';
+    if ($stuadd eq 'yes') {
+        $checked = ' CHECKED ';
+    } else {
+        $checked = ' ';
+    }
+    $output.='<td><input type="checkbox" name="'.$field_name.'_stuadd" value="yes"'.$checked.' /></td>';
+    $output.='</tr>';
+    return ($output);
+}
+sub setinstmeta {
+    my ($r)=@_;
+    my $next_meta;
+    my $output;
+    my $item_num;
+    my $put_result;
+    $r->print(&Apache::lonxml::xmlbegin());
+    $r->print('<head>
+            <title>LON-CAPA Set Instructor Metadata</title>
+            </head>');
+    $r->print(&Apache::loncommon::bodytag('Set Instructor Metadata'));
+    $r->print(&Apache::lonhtmlcommon::breadcrumbs(undef,
+						    'Set Instructor Metadata'));
+    my $dom = $env{'course.'.$env{'request.course.id'}.'.domain'};
+    my $crs = $env{'course.'.$env{'request.course.id'}.'.num'};
+    my $key_base = $env{'course.'.$env{'request.course.id'}.'.metadata.'};
+    my $save_field = '';
+    my $stuadd;
+    my $onlyone;
+    my $active;
+    if ($env{'form.instmeta'}) {
+        foreach my $field (sort %env) {
+            if ($field=~m/^form.(.+)_(.+)$/) {
+                my $meta_field = $1;
+                my $meta_key = $2;
+                if ($save_field ne $meta_field) {
+                    $save_field = $meta_field;
+            	    if ($env{'form.'.$meta_field.'_stuadd'}) {
+            	        $stuadd='yes';
+            	    } else {
+            	        $stuadd='no';
+            	    }
+            	    if ($env{'form.'.$meta_field.'_onlyone'}) {
+            	        $onlyone='no';
+            	    } else {
+            	        $onlyone='yes';
+            	    }
+            	    $active='yes';			
+                    my $name = 'metadata.'.$save_field;
+                     $put_result = &Apache::lonnet::put('environment',
+                                                  {'metadata.'.$meta_field.'.stuadd'=>$stuadd,
+                                                    'metadata.'.$meta_field.'.onlyone'=>$onlyone,
+                                                    'metadata.'.$meta_field.'.active'=>$active,
+                                                   'metadata.'.$meta_field.'.values'=>$env{'form.'.$meta_field.'_values'},
+                                                   },$dom,$crs);
+                }
+            }
+        }
+        
+    }
+    foreach my $field (%env) {
+        # start by looking for populated fields
+        if ($field=~m/type(\d+)/) {
+	    	my $name;
+    		my $value;
+            # $put_result = &Apache::lonnet::put('environment',
+            #                                      {$name=>$value},$dom,$crs);
+            # $put_result = &Apache::lonnet::put('environment',
+            #                                      {$name=>$value},$dom,$crs);
+        }
+        if ($field=~m/newfield/) {
+            my $name = 'metadata.'.$env{'form.titlenew'};
+            my %meta_hash = {values=>[$env{'form.valuesnew'}],
+            				allow_pick=>'many',
+            				allow_type=>'no'};
+            				
+            my $value = \%meta_hash;
+            # $put_result = &Apache::lonnet::put('environment',
+            #                                      {$name=>$value},$dom,$crs);
+        }
+    } 
+    &Apache::lonnet::coursedescription($env{'request.course.id'});
+    $output.= &output_row($r, "Title");
+    $output.= &output_row($r, "Subject");
+    $output.= &output_row($r, "Keywords");     
+    $r->print(<<ENDenv);       
+        <form method="post" action="/adm/parmset?action=setinstmeta" name="form">
+        
+        <p>
+        <table border=2>
+        <tr><th>Metadata Item</th><th>Values</th><th>Only One Choice</th><th>Student Can Add Choices</th></tr>
+        $output
+        </table>
+        <input type="submit" name="instmeta" value="Update Instructor Metadata">
+        </form>
 
+ENDenv
+        
+    
+    $r->print('</body>
+                </html>');
+    return 'ok';
+}
+##################################################
 
+sub defaultsetter {
+    my $r=shift;
+    my $bodytag=&Apache::loncommon::bodytag('Parameter Setting Default Actions');
+    my $dom = $env{'course.'.$env{'request.course.id'}.'.domain'};
+    my $crs = $env{'course.'.$env{'request.course.id'}.'.num'};
+    my $breadcrumbs = &Apache::lonhtmlcommon::breadcrumbs(undef,'Defaults');
+    my $html=&Apache::lonxml::xmlbegin();
+    $r->print(<<ENDDEFHEAD);
+$html
+<head>
+<title>LON-CAPA Parameters</title>
+</head>
+$bodytag
+$breadcrumbs
+<form method="post" action="/adm/parmset?action=setdefaults" name="defaultform">
+ENDDEFHEAD
+    my @ids=();
+    my %typep=();
+    my %keyp=();
+    my %allparms=();
+    my %allparts=();
+    my %allmaps=();
+    my %mapp=();
+    my %symbp=();
+    my %maptitles=();
+    my %uris=();
+    my %keyorder=&standardkeyorder();
+    my %defkeytype=();
 
+    &extractResourceInformation(\@ids, \%typep,\%keyp, \%allparms, \%allparts, \%allmaps, 
+				\%mapp, \%symbp,\%maptitles,\%uris,
+				\%keyorder,\%defkeytype);
+    if ($env{'form.storerules'}) {
+	my %newrules=();
+	my @delrules=();
+	my %triggers=();
+	foreach my $key (keys(%env)) {
+            if ($key=~/^form\.(\w+)\_action$/) {
+		my $tempkey=$1;
+		my $action=$env{$key};
+                if ($action) {
+		    $newrules{$tempkey.'_action'}=$action;
+		    if ($action ne 'default') {
+			my ($whichaction,$whichparm)=($action=~/^(.*\_)([^\_]+)$/);
+			$triggers{$whichparm}.=$tempkey.':';
+		    }
+		    $newrules{$tempkey.'_type'}=$defkeytype{$tempkey};
+		    if (&isdateparm($defkeytype{$tempkey})) {
+			$newrules{$tempkey.'_days'}=$env{'form.'.$tempkey.'_days'};
+			$newrules{$tempkey.'_hours'}=$env{'form.'.$tempkey.'_hours'};
+			$newrules{$tempkey.'_min'}=$env{'form.'.$tempkey.'_min'};
+			$newrules{$tempkey.'_sec'}=$env{'form.'.$tempkey.'_sec'};
+		    } else {
+			$newrules{$tempkey.'_value'}=$env{'form.'.$tempkey.'_value'};
+			$newrules{$tempkey.'_triggervalue'}=$env{'form.'.$tempkey.'_triggervalue'};
+		    }
+		} else {
+		    push(@delrules,$tempkey.'_action');
+		    push(@delrules,$tempkey.'_type');
+		    push(@delrules,$tempkey.'_hours');
+		    push(@delrules,$tempkey.'_min');
+		    push(@delrules,$tempkey.'_sec');
+		    push(@delrules,$tempkey.'_value');
+		}
+	    }
+	}
+	foreach my $key (keys %allparms) {
+	    $newrules{$key.'_triggers'}=$triggers{$key};
+	}
+	&Apache::lonnet::put('parmdefactions',\%newrules,$dom,$crs);
+	&Apache::lonnet::del('parmdefactions',\@delrules,$dom,$crs);
+	&resetrulescache();
+    }
+    my %lt=&Apache::lonlocal::texthash('days' => 'Days',
+				       'hours' => 'Hours',
+				       'min' => 'Minutes',
+				       'sec' => 'Seconds',
+				       'yes' => 'Yes',
+				       'no' => 'No');
+    my @standardoptions=('','default');
+    my @standarddisplay=('',&mt('Default value when manually setting'));
+    my @dateoptions=('','default');
+    my @datedisplay=('',&mt('Default value when manually setting'));
+    foreach my $tempkey (&keysindisplayorder(\%allparms,\%keyorder)) {
+	unless ($tempkey) { next; }
+	push @standardoptions,'when_setting_'.$tempkey;
+	push @standarddisplay,&mt('Automatically set when setting ').$tempkey;
+	if (&isdateparm($defkeytype{$tempkey})) {
+	    push @dateoptions,'later_than_'.$tempkey;
+	    push @datedisplay,&mt('Automatically set later than ').$tempkey;
+	    push @dateoptions,'earlier_than_'.$tempkey;
+	    push @datedisplay,&mt('Automatically set earlier than ').$tempkey;
+	} 
+    }
+$r->print(&mt('Manual setting rules apply to all interfaces.').'<br />'.
+	  &mt('Automatic setting rules apply to table mode interfaces only.'));
+    $r->print("\n<table border='1'><tr><th>".&mt('Rule for parameter').'</th><th>'.
+	      &mt('Action').'</th><th>'.&mt('Value').'</th></tr>');
+    foreach my $tempkey (&keysindisplayorder(\%allparms,\%keyorder)) {
+	unless ($tempkey) { next; }
+	$r->print("\n<tr><td>".$allparms{$tempkey}."\n<br />(".$tempkey.')</td><td>');
+	my $action=&rulescache($tempkey.'_action');
+	$r->print('<select name="'.$tempkey.'_action">');
+	if (&isdateparm($defkeytype{$tempkey})) {
+	    for (my $i=0;$i<=$#dateoptions;$i++) {
+		if ($dateoptions[$i]=~/\_$tempkey$/) { next; }
+		$r->print("\n<option value='$dateoptions[$i]'".
+			  ($dateoptions[$i] eq $action?' selected="selected"':'').
+			  ">$datedisplay[$i]</option>");
+	    }
+	} else {
+	    for (my $i=0;$i<=$#standardoptions;$i++) {
+		if ($standardoptions[$i]=~/\_$tempkey$/) { next; }
+		$r->print("\n<option value='$standardoptions[$i]'".
+			  ($standardoptions[$i] eq $action?' selected="selected"':'').
+			  ">$standarddisplay[$i]</option>");
+	    }
+	}
+	$r->print('</select>');
+	unless (&isdateparm($defkeytype{$tempkey})) {
+	    $r->print("\n<br />".&mt('Triggering value(s) of other parameter (optional, comma-separated):').
+		      '<input type="text" size="20" name="'.$tempkey.'_triggervalue" value="'.&rulescache($tempkey.'_triggervalue').'" />');
+	}
+	$r->print("\n</td><td>\n");
+
+        if (&isdateparm($defkeytype{$tempkey})) {
+	    my $days=&rulescache($tempkey.'_days');
+	    my $hours=&rulescache($tempkey.'_hours');
+	    my $min=&rulescache($tempkey.'_min');
+	    my $sec=&rulescache($tempkey.'_sec');
+	    $r->print(<<ENDINPUTDATE);
+<input name="$tempkey\_days" type="text" size="4" value="$days" />$lt{'days'}<br />
+<input name="$tempkey\_hours" type="text" size="4" value="$hours" />$lt{'hours'}<br />
+<input name="$tempkey\_min" type="text" size="4" value="$min" />$lt{'min'}<br />
+<input name="$tempkey\_sec" type="text" size="4" value="$sec" />$lt{'sec'}
+ENDINPUTDATE
+	} elsif ($defkeytype{$tempkey} eq 'string_yesno') {
+            my $yeschecked='';
+            my $nochecked='';
+            if (&rulescache($tempkey.'_value') eq 'yes') { $yeschecked='checked="checked"'; }
+            if (&rulescache($tempkey.'_value') eq 'no') { $nochecked='checked="checked"'; }
+
+	    $r->print(<<ENDYESNO);
+<label><input type="radio" name="$tempkey\_value" value="yes" $yeschecked /> $lt{'yes'}</label><br />
+<label><input type="radio" name="$tempkey\_value" value="no" $nochecked /> $lt{'no'}</label>
+ENDYESNO
+        } else {
+	    $r->print('<input type="text" size="20" name="'.$tempkey.'_value" value="'.&rulescache($tempkey.'_value').'" />');
+	}
+        $r->print('</td></tr>');
+    }
+    $r->print("</table>\n<input type='submit' name='storerules' value='".
+	      &mt('Store Rules')."' /></form>\n</body>\n</html>");
+    return;
+}
 
 ##################################################
 ##################################################
@@ -2522,7 +3044,8 @@ Main handler.  Calls &assessparms and &c
 =cut
 ##################################################
 ##################################################
-    use Data::Dumper;
+#    use Data::Dumper;
+
 sub handler {
     my $r=shift;
 
@@ -2536,7 +3059,7 @@ sub handler {
                                              'pres_marker',
                                              'pres_value',
                                              'pres_type',
-                                             'udom','uname']);
+                                             'udom','uname','symb','serial']);
 
 
     &Apache::lonhtmlcommon::clear_breadcrumbs();
@@ -2578,18 +3101,24 @@ sub handler {
         } elsif ($env{'form.action'} eq 'crsenv' && $parm_permission) {
             &Apache::lonhtmlcommon::add_breadcrumb({href=>'/adm/parmset?action=crsenv',
 						    text=>"Course Environment"});
-            $r->print(&Apache::lonhtmlcommon::breadcrumbs(undef,
-						   'Edit Course Environment'));
             &crsenv($r); 
         } elsif ($env{'form.action'} eq 'setoverview' && $parm_permission) {
             &Apache::lonhtmlcommon::add_breadcrumb({href=>'/adm/parmset?action=setoverview',
 						    text=>"Overview Mode"});
 	    &overview($r);
+        } elsif ($env{'form.action'} eq 'setinstmeta' && $parm_permission) {
+            &Apache::lonhtmlcommon::add_breadcrumb({href=>'/adm/parmset?action=setinstmeta',
+						    text=>"Instructor Metadata"});
+	    &setinstmeta($r);
         } elsif ($env{'form.action'} eq 'newoverview' && $parm_permission) {
             &Apache::lonhtmlcommon::add_breadcrumb({href=>'/adm/parmset?action=setoverview',
 						    text=>"Overview Mode"});
 	    &newoverview($r);
-        } elsif ($env{'form.action'} eq 'settable' && $parm_permission) {
+        }  elsif ($env{'form.action'} eq 'setdefaults' && $parm_permission) {
+            &Apache::lonhtmlcommon::add_breadcrumb({href=>'/adm/parmset?action=setdefaults',
+						    text=>"Set Defaults"});
+	    &defaultsetter($r);
+	} elsif ($env{'form.action'} eq 'settable' && $parm_permission) {
             &Apache::lonhtmlcommon::add_breadcrumb({href=>'/adm/parmset?action=settable',
 						    text=>"Table Mode",
 						    help => 'Course_Setting_Parameters'});