--- loncom/lcuserdel 2000/10/29 17:57:26 1.5
+++ loncom/lcuserdel 2002/10/07 01:52:28 1.14
@@ -25,6 +25,11 @@ use strict;
# Standard input usage
# First line is USERNAME
+# Valid user names must consist of ascii
+# characters that are alphabetical characters
+# (A-Z,a-z), numeric (0-9), or the underscore
+# mark (_). (Essentially, the perl regex \w).
+
# Command-line arguments [USERNAME]
# Yes, but be very careful here (don't pass shell commands)
# and this is only supported to allow perl-system calls.
@@ -35,6 +40,12 @@ use strict;
# print "uh-oh" if $exitcode;
# These are the exit codes.
+# ( (0,"ok"),
+# (1,"User ID mismatch. This program must be run as user 'www'"),
+# (2,"Error. This program needs just 1 command-line argument (username).") )
+# (3,"Error. Only one line should be entered into standard input."),
+# (4,"Error. Too many other simultaneous password change requests being made."),
+# (5,"Error. The user name specified has invalid characters.") )
# Security
$ENV{'PATH'}=""; # Nullify path information.
@@ -75,12 +86,14 @@ if (@ARGV==1) {
}
elsif (@ARGV) {
print("Error. This program needs just 1 command-line argument (username).\n") unless $noprint;
+ unlink('/tmp/lock_lcpasswd');
exit 2;
}
else {
@input=<>;
if (@input!=1) {
print("Error. Only one line should be entered into standard input.\n") unless $noprint;
+ unlink('/tmp/lock_lcpasswd');
exit 3;
}
map {chop} @input;
@@ -89,23 +102,32 @@ else {
my ($username)=@input;
$username=~/^(\w+)$/;
my $safeusername=$1;
+if ($username ne $safeusername) {
+ print "Error. The user name specified has invalid characters.\n";
+ unlink('/tmp/lock_lcpasswd');
+ exit 5;
+}
&enable_root_capability;
# By using the system userdel command:
# Remove entry from /etc/passwd if it exists
# Remove entry from /etc/groups if it exists
+# I surround with groupdel command to make absolutely sure the group definition disappears.
+system('/usr/sbin/groupdel',$safeusername); # ignore error message
system('/usr/sbin/userdel',$safeusername); # ignore error message
system('/usr/sbin/groupdel',$safeusername); # ignore error message
# Remove entry from /etc/smbpasswd if it exists
-my $oldsmbpasswd=`/bin/cat /etc/smbpasswd`;
-my $newsmbpasswd=`/bin/grep -v '^${safeusername}:' /etc/smbpasswd`;
+# the safest way to do this is with smbpasswd -x
+# as that's independent of location of the smbpasswd file.
+#
+if (-e '/usr/bin/smbpasswd') {
+ ($>,$<) = (0,0); # fool smbpasswd to think this is not setuid.
+ system('/usr/bin/smbpasswd -x '.$safeusername);
+ $< = $wwwid;
+}
-if ($oldsmbpasswd ne $newsmbpasswd) {
-open OUT,">/etc/smbpasswd";
-print OUT $newsmbpasswd;
-close OUT;
# Change ownership on directory from username:username to www:www
# This prevents subsequently added users from having access.
500 Internal Server Error
Internal Server Error
The server encountered an internal error or
misconfiguration and was unable to complete
your request.
Please contact the server administrator at
root@localhost to inform them of the time this error occurred,
and the actions you performed just before this error.
More information about this error may be available
in the server error log.