--- loncom/publisher/lonpublisher.pm	2004/01/27 22:54:59	1.163
+++ loncom/publisher/lonpublisher.pm	2007/06/18 20:30:32	1.225
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Publication Handler
 #
-# $Id: lonpublisher.pm,v 1.163 2004/01/27 22:54:59 albertel Exp $
+# $Id: lonpublisher.pm,v 1.225 2007/06/18 20:30:32 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -121,14 +121,16 @@ use HTML::LCParser;
 use Apache::lonxml;
 use Apache::loncacc;
 use DBI;
-use Apache::lonnet();
+use Apache::lonnet;
 use Apache::loncommon();
 use Apache::lonmysql;
 use Apache::lonlocal;
 use Apache::loncfile;
-use Apache::lonmeta;
+use LONCAPA::lonmetadata;
 use Apache::lonmsg;
 use vars qw(%metadatafields %metadatakeys);
+use LONCAPA qw(:DEFAULT :match);
+ 
 
 my %addid;
 my %nokey;
@@ -138,6 +140,9 @@ my $docroot;
 my $cuname;
 my $cudom;
 
+my $registered_cleanup;
+my $modified_urls;
+
 =pod
 
 =item B<metaeval>
@@ -178,17 +183,18 @@ sub metaeval {
 	if ($token->[0] eq 'S') {
 	    my $entry=$token->[1];
 	    my $unikey=$entry;
+	    next if ($entry =~ m/^(?:parameter|stores)_/);
 	    if (defined($token->[2]->{'package'})) { 
-		$unikey.='_package_'.$token->[2]->{'package'};
+		$unikey.="\0package\0".$token->[2]->{'package'};
 	    } 
 	    if (defined($token->[2]->{'part'})) { 
-		$unikey.='_'.$token->[2]->{'part'}; 
+		$unikey.="\0".$token->[2]->{'part'}; 
 	    }
 	    if (defined($token->[2]->{'id'})) { 
-		$unikey.='_'.$token->[2]->{'id'};
+		$unikey.="\0".$token->[2]->{'id'};
 	    } 
 	    if (defined($token->[2]->{'name'})) { 
-		$unikey.='_'.$token->[2]->{'name'}; 
+		$unikey.="\0".$token->[2]->{'name'}; 
 	    }
 	    foreach (@{$token->[3]}) {
 		$metadatafields{$unikey.'.'.$_}=$token->[2]->{$_};
@@ -199,7 +205,8 @@ sub metaeval {
 		}
 	    }
 	    my $newentry=$parser->get_text('/'.$entry);
-	    if ($entry eq 'customdistributionfile') {
+	    if (($entry eq 'customdistributionfile') ||
+		($entry eq 'sourcerights')) {
 		$newentry=~s/^\s*//;
 		if ($newentry !~m|^/res|) { $newentry=$prefix.$newentry; }
 	    }
@@ -274,9 +281,8 @@ sub metaread {
 sub coursedependencies {
     my $url=&Apache::lonnet::declutter(shift);
     $url=~s/\.meta$//;
-    my ($adomain,$aauthor)=($url=~/^(\w+)\/(\w+)\//);
-    my $regexp=$url;
-    $regexp=~s/(\W)/\\$1/g;
+    my ($adomain,$aauthor)=($url=~ m{^($match_domain)/($match_username)/});
+    my $regexp=quotemeta($url);
     $regexp='___'.$regexp.'___course';
     my %evaldata=&Apache::lonnet::dump('nohist_resevaldata',$adomain,
 				       $aauthor,$regexp);
@@ -322,20 +328,48 @@ sub textfield {
     $value=~s/\s+$//gs;
     $value=~s/\s+/ /gs;
     $title=&mt($title);
+    $env{'form.'.$name}=$value;
     return "\n<p><font color=\"#800000\" face=\"helvetica\"><b>$title:".
            "</b></font></p><br />".
            '<input type="text" name="'.$name.'" size=80 value="'.$value.'" />';
 }
 
+sub text_with_browse_field {
+    my ($title,$name,$value,$restriction)=@_;
+    $value=~s/^\s+//gs;
+    $value=~s/\s+$//gs;
+    $value=~s/\s+/ /gs;
+    $title=&mt($title);
+    $env{'form.'.$name}=$value;
+    return "\n<p><font color=\"#800000\" face=\"helvetica\"><b>$title:".
+           "</b></font></p><br />".
+           '<input type="text" name="'.$name.'" size=80 value="'.$value.'" />'.
+	   '<a href="javascript:openbrowser(\'pubform\',\''.$name.'\',\''.$restriction.'\');">Select</a>&nbsp;'.
+	   '<a href="javascript:opensearcher(\'pubform\',\''.$name.'\');">Search</a>';
+	   
+}
+
 sub hiddenfield {
     my ($name,$value)=@_;
+    $env{'form.'.$name}=$value;
     return "\n".'<input type="hidden" name="'.$name.'" value="'.$value.'" />';
 }
 
+sub checkbox {
+    my ($name,$text)=@_;
+    return "\n<br /><label><input type='checkbox' name='$name' /> ".
+	&mt($text)."</label>";
+}
+
 sub selectbox {
     my ($title,$name,$value,$functionref,@idlist)=@_;
     $title=&mt($title);
     $value=(split(/\s*,\s*/,$value))[-1];
+    if (defined($value)) {
+	$env{'form.'.$name}=$value;
+    } else {
+	$env{'form.'.$name}=$idlist[0];
+    }
     my $selout="\n<p><font color=\"#800000\" face=\"helvetica\"><b>$title:".
 	'</b></font></p><br /><select name="'.$name.'">';
     foreach (@idlist) {
@@ -348,6 +382,12 @@ sub selectbox {
     return $selout.'</select>';
 }
 
+sub select_level_form {
+    my ($value,$name)=@_;
+    $env{'form.'.$name}=$value;
+    if (!defined($value)) { $env{'form.'.$name}=0; }
+    return  &Apache::loncommon::select_level_form($value,$name);
+}
 #########################################
 #########################################
 
@@ -369,15 +409,14 @@ sub urlfixup {
     if ($url =~ /^mailto:/i) { return $url; }
     #internal document links need no fixing
     if ($url =~ /^\#/) { return $url; } 
-    my ($host)=($url=~/(?:http\:\/\/)*([^\/]+)/);
-    foreach (values %Apache::lonnet::hostname) {
-	if ($_ eq $host) {
-	    $url=~s/^http\:\/\///;
-            $url=~s/^$host//;
-        }
+    my ($host)=($url=~m{(?:(?:http|https|ftp)://)*([^/]+)});
+    my @lonids = &Apache::lonnet::machine_ids($host);
+    if (@lonids) {
+	$url=~s{^(?:http|https|ftp)://}{};
+	$url=~s/^\Q$host\E//;
     }
-    if ($url=~/^http\:\/\//) { return $url; }
-    $url=~s/\~$cuname/res\/$cudom\/$cuname/;
+    if ($url=~m{^(?:http|https|ftp)://}) { return $url; }
+    $url=~s{\Q~$cuname\E}{res/$cudom/$cuname};
     return $url;
 }
 
@@ -428,11 +467,11 @@ sub set_allow {
     }
     if (($newurl !~ /^javascript:/i) &&
 	($newurl !~ /^mailto:/i) &&
-	($newurl !~ /^http:/i) &&
+	($newurl !~ /^(?:http|https|ftp):/i) &&
 	($newurl !~ /^\#/)) {
 	$$allow{&absoluteurl($newurl,$target)}=1;
     }
-    return $return_url
+    return $return_url;
 }
 
 #########################################
@@ -455,10 +494,15 @@ sub get_subscribed_hosts {
     $target=~/(.*)\/([^\/]+)$/;
     my $srcf=$2;
     opendir(DIR,$1);
+    # cycle through listed files, subscriptions used to exist
+    # as "filename.lonid"
     while ($filename=readdir(DIR)) {
-	if ($filename=~/\Q$srcf\E\.(\w+)$/) {
+	if ($filename=~/\Q$srcf\E\.($match_lonid)$/) {
 	    my $subhost=$1;
-	    if (($subhost ne 'meta' && $subhost ne 'subscription') &&
+	    if (($subhost ne 'meta' 
+		 && $subhost ne 'subscription' 
+		 && $subhost ne 'meta.subscription'
+		 && $subhost ne 'tmp') &&
                 ($subhost ne $Apache::lonnet::perlvar{'lonHostID'})) {
 		push(@subscribed,$subhost);
 	    }
@@ -467,19 +511,13 @@ sub get_subscribed_hosts {
     closedir(DIR);
     my $sh;
     if ( $sh=Apache::File->new("$target.subscription") ) {
-	&Apache::lonnet::logthis("opened $target.subscription");
 	while (my $subline=<$sh>) {
-	    &Apache::lonnet::logthis("Trying $subline");
-	    if ($subline =~ /(^\w+):/) { 
+	    if ($subline =~ /^($match_lonid):/) { 
                 if ($1 ne $Apache::lonnet::perlvar{'lonHostID'}) { 
                    push(@subscribed,$1);
 	        }
-            } else {
-		&Apache::lonnet::logthis("No Match for $subline");
 	    }
 	}
-    } else {
-	&Apache::lonnet::logthis("Unable to open $target.subscription");
     }
     return @subscribed;
 }
@@ -509,13 +547,15 @@ sub get_max_ids_indices {
     my %duplicatedids;
 
     my $parser=HTML::LCParser->new($content);
+    $parser->xml_mode(1);
     my $token;
     while ($token=$parser->get_token) {
 	if ($token->[0] eq 'S') {
 	    my $counter;
 	    if ($counter=$addid{$token->[1]}) {
 		if ($counter eq 'id') {
-		    if (defined($token->[2]->{'id'})) {
+		    if (defined($token->[2]->{'id'}) &&
+			$token->[2]->{'id'} !~ /^\s*$/) {
 			$maxid=($token->[2]->{'id'}>$maxid)?$token->[2]->{'id'}:$maxid;
 			if (exists($allids{$token->[2]->{'id'}})) {
 			    $duplicateids=1;
@@ -527,7 +567,8 @@ sub get_max_ids_indices {
 			$needsfixup=1;
 		    }
 		} else {
-		    if (defined($token->[2]->{'index'})) {
+		    if (defined($token->[2]->{'index'}) &&
+			$token->[2]->{'index'} !~ /^\s*$/) {
 			$maxindex=($token->[2]->{'index'}>$maxindex)?$token->[2]->{'index'}:$maxindex;
 		    } else {
 			$needsfixup=1;
@@ -569,11 +610,11 @@ sub get_all_text_unbalanced {
 	} elsif ($token->[0] eq 'E')  {
 	    $result.=$token->[2];
 	}
-	if ($result =~ /(.*)\Q$tag\E(.*)/s) {
+	if ($result =~ /\Q$tag\E/s) {
+	    ($result,my $redo)=$result =~ /(.*)\Q$tag\E(.*)/is;
 	    #&Apache::lonnet::logthis('Got a winner with leftovers ::'.$2);
 	    #&Apache::lonnet::logthis('Result is :'.$1);
-	    $result=$1;
-	    my $redo=$tag.$2;
+	    $redo=$tag.$redo;
 	    push (@$pars,HTML::LCParser->new(\$redo));
 	    $$pars[-1]->xml_mode('1');
 	    last;
@@ -636,30 +677,37 @@ sub fix_ids_and_indices {
 		    $allow{$token->[2]->{'src'}}=1;
 		    next;
 		}
+		if ($lctag eq 'base') { next; }
 		my %parms=%{$token->[2]};
 		$counter=$addid{$tag};
 		if (!$counter) { $counter=$addid{$lctag}; }
 		if ($counter) {
 		    if ($counter eq 'id') {
-			unless (defined($parms{'id'})) {
+			unless (defined($parms{'id'}) &&
+				$parms{'id'}!~/^\s*$/) {
 			    $maxid++;
 			    $parms{'id'}=$maxid;
-			    print $logfile 'ID: '.$tag.':'.$maxid."\n";
+			    print $logfile 'ID(new) : '.$tag.':'.$maxid."\n";
+			} else {
+			    print $logfile 'ID(kept): '.$tag.':'.$parms{'id'}."\n";
 			}
 		    } elsif ($counter eq 'index') {
-			unless (defined($parms{'index'})) {
+			unless (defined($parms{'index'}) &&
+				$parms{'index'}!~/^\s*$/) {
 			    $maxindex++;
 			    $parms{'index'}=$maxindex;
 			    print $logfile 'Index: '.$tag.':'.$maxindex."\n";
 			}
 		    }
 		}
-		foreach my $type ('src','href','background','bgimg') {
-		    foreach my $key (keys(%parms)) {
-			if ($key =~ /^$type$/i) {
-			    $parms{$key}=&set_allow(\%allow,$logfile,
-						    $target,$tag,
-						    $parms{$key});
+                unless ($parms{'type'} eq 'zombie') {
+		    foreach my $type ('src','href','background','bgimg') {
+			foreach my $key (keys(%parms)) {
+			    if ($key =~ /^$type$/i) {
+				$parms{$key}=&set_allow(\%allow,$logfile,
+							$target,$tag,
+							$parms{$key});
+			    }
 			}
 		    }
 		}
@@ -670,6 +718,7 @@ sub fix_ids_and_indices {
 		    ($lctag eq 'image')) {
 		    my $next_token=$parser[-1]->get_token();
 		    if ($next_token->[0] eq 'T') {
+                        $next_token->[1] =~ s/[\n\r\f]+//g;
 			$next_token->[1]=&set_allow(\%allow,$logfile,
 						    $target,$tag,
 						    $next_token->[1]);
@@ -788,55 +837,56 @@ sub store_metadata {
         &Apache::lonnet::logthis($error);
         return ($error,undef);
     }
+    my $dbh = &Apache::lonmysql::get_dbh();
     if (($metadata{'obsolete'}) || ($metadata{'copyright'} eq 'priv') ||
 	($metadata{'copyright'} eq 'custom')) {
-# remove this entry
-	$status=&Apache::lonmysql::remove_from_table
-	    ('metadata','url',$metadata{'url'});
+        # remove this entry
+	$status=&LONCAPA::lonmetadata::delete_metadata($dbh,undef,
+                                                       $metadata{'url'});
     } else {
-# store new data
-# adjust some values to metadatadatabase (e.g., "usage" is a reserved word)
-	$metadata{'creationdate'}=
-	    &Apache::lonmysql::sqltime($metadata{'creationdate'}); 
-	$metadata{'lastrevisiondate'}=
-	    &Apache::lonmysql::sqltime($metadata{'lastrevisiondate'});
-	$metadata{'sequsage'}=$metadata{'usage'};
-	$metadata{'sequsage_list'}=$metadata{'usage_list'};
-	my %newmetadata=();
-# see if we have old entries
-	my @oldmeta=&Apache::lonmysql::get_rows('metadata',
-						"url LIKE BINARY '".
-						$metadata{'url'}."'");
-	if ($#oldmeta==0) {
-# yes, there is one old entry, transfer to newmetadata
-	    %newmetadata=&Apache::lonmeta::metadata_col_to_hash(@{$oldmeta[0]});
-# remove old entry
-	    $status=&Apache::lonmysql::remove_from_table
-		('metadata','url',$metadata{'url'});
-	} elsif ($#oldmeta>0) {
-# more than one entry fit - how did that happen?
-	    $error='<font color="red">Error occured retrieving old values in '.
-	      'metadata table in LON-CAPA database: '.$#oldmeta.
-	      ' matches</font>';
-	    &Apache::lonnet::logthis($error);
-	    return ($error,undef);
-	}
-# store new data on top of it
-	foreach (keys %metadata) {
-	    $newmetadata{$_}=$metadata{$_};
-	}
-	$status = &Apache::lonmysql::store_row('metadata',\%newmetadata);
+        $status = &LONCAPA::lonmetadata::update_metadata($dbh,undef,undef,
+                                                         \%metadata);
     }
-    if (! defined($status)) {
-        $error='<font color="red">Error occured storing new values in '.
+    if (defined($status) && $status ne '') {
+        $error='<font color="red">Error occured saving new values in '.
             'metadata table in LON-CAPA database</font>';
         &Apache::lonnet::logthis($error);
+        &Apache::lonnet::logthis($status);
         return ($error,undef);
     }
-    return (undef,$status);
+    return (undef,'success');
 }
 
 
+# ========================================== Parse file for errors and warnings
+
+sub checkonthis {
+    my ($r,$source)=@_;
+    my $uri=&Apache::lonnet::hreflocation($source);
+    $uri=~s/\/$//;
+    my $result=&Apache::lonnet::ssi_body($uri,
+					 ('grade_target'=>'web',
+					  'return_only_error_and_warning_counts' => 1));
+    my ($errorcount,$warningcount)=split(':',$result);
+    if (($errorcount) || ($warningcount)) {
+        $r->print('<br /><tt>'.$uri.'</tt>: ');
+	if ($errorcount) {
+	    $r->print('<img src="/adm/lonMisc/bomb.gif" /><font color="red"><b>'.
+		      $errorcount.' '.
+		      &mt('error(s)').'</b></font> ');
+	}
+	if ($warningcount) {
+	    $r->print('<font color="blue">'.
+		      $warningcount.' '.
+		      &mt('warning(s)').'</font>');
+	}
+    } else {
+	#$r->print('<font color="green">'.&mt('ok').'</font>');
+    }
+    $r->rflush();
+    return ($warningcount,$errorcount);
+}
+
 # ============================================== Parse file itself for metadata
 #
 # parses a file with target meta, sets global %metadatafields %metadatakeys 
@@ -890,7 +940,7 @@ sub publish {
 	return ('<font color="red">'.&mt('No write permission to user directory, FAIL').'</font>',1);
     }
     print $logfile 
-"\n\n================= Publish ".localtime()." Phase One  ================\n".$ENV{'user.name'}.'@'.$ENV{'user.domain'}."\n";
+"\n\n================= Publish ".localtime()." Phase One  ================\n".$env{'user.name'}.':'.$env{'user.domain'}."\n";
 
     if (($style eq 'ssi') || ($style eq 'rat') || ($style eq 'prv')) {
 # ------------------------------------------------------- This needs processing
@@ -920,11 +970,11 @@ sub publish {
               $allowstr.="\n".'<allow src="'.$thisdep.'" />';
 	   }
            $scrout.='<br />';
-           unless ($thisdep=~/\*/) {
+           if ($thisdep!~/\*/ && $thisdep!~m|^/adm/|) {
 	       $scrout.='<a href="'.$thisdep.'">';
            }
            $scrout.='<tt>'.$thisdep.'</tt>';
-           unless ($thisdep=~/\*/) {
+           if ($thisdep!~/\*/ && $thisdep!~m|^/adm/|) {
 	       $scrout.='</a>';
                if (
        &Apache::lonnet::getfile($Apache::lonnet::perlvar{'lonDocRoot'}.'/'.
@@ -935,7 +985,7 @@ sub publish {
                    my %temphash=(&Apache::lonnet::declutter($target).'___'.
                              &Apache::lonnet::declutter($thisdep).'___usage'
                                  => time);
-                   $thisdep=~/^\/res\/(\w+)\/(\w+)\//;
+                   $thisdep=~m{^/res/($match_domain)/($match_username)/};
                    if ((defined($1)) && (defined($2))) {
                       &Apache::lonnet::put('nohist_resevaldata',\%temphash,
 					   $1,$2);
@@ -943,13 +993,8 @@ sub publish {
 	       }
            }
         }
-        $outstring=~s/\n*(\<\/[^\>]+\>)\s*$/$allowstr\n$1\n/s;
+        $outstring=~s/\n*(\<\/[^\>]+\>[^<]*)$/$allowstr\n$1\n/s;
 
-### FIXME: is this really what we want?
-# I dont' think so, to will corrupt any UTF-8 resources at least, 
-# and any encoding other than ISO-8859-1 will probably break
-	#Encode any High ASCII characters
-	#$outstring=&HTML::Entities::encode($outstring,"\200-\377");
 # ------------------------------------------------------------- Write modified.
 
         {
@@ -982,14 +1027,14 @@ sub publish {
     }
 
 # ------------------------------------------------ First, check out environment
-     unless (-e $source.'.meta') {
-        $metadatafields{'author'}=$ENV{'environment.firstname'}.' '.
-	                          $ENV{'environment.middlename'}.' '.
-		                  $ENV{'environment.lastname'}.' '.
-		                  $ENV{'environment.generation'};
+     if ((!(-e $source.'.meta')) || ($env{'form.forceoverride'})) {
+        $metadatafields{'author'}=$env{'environment.firstname'}.' '.
+	                          $env{'environment.middlename'}.' '.
+		                  $env{'environment.lastname'}.' '.
+		                  $env{'environment.generation'};
         $metadatafields{'author'}=~s/\s+/ /g;
         $metadatafields{'author'}=~s/\s+$//;
-        $metadatafields{'owner'}=$cuname.'@'.$cudom;
+        $metadatafields{'owner'}=$cuname.':'.$cudom;
 
 # ------------------------------------------------ Check out directory hierachy
 
@@ -1007,6 +1052,7 @@ sub publish {
             $scrout.=&metaread($logfile,$currentpath.'default.meta',$prefix);
 	    $prefix=~s|^\.\./||;
         }
+
 # ----------------------------------------------------------- Parse file itself
 # read %metadatafields from file itself
  
@@ -1031,10 +1077,18 @@ sub publish {
 		delete $metadatafields{$_};
             }
         }
+# ------------------------------------------------------------- Save some stuff
+        my %savemeta=();
+        foreach ('title') {
+            $savemeta{$_}=$metadatafields{$_};
+	}
 # ------------------------------------------ See if anything new in file itself
  
 	$allmeta=&parseformeta($source,$style);
-
+# ----------------------------------------------------------- Restore the stuff
+        foreach (keys %savemeta) {
+	    $metadatafields{$_}=$savemeta{$_};
+	}
    }
 
        
@@ -1045,14 +1099,16 @@ sub publish {
 	if (($_=~/^parameter/) || ($_=~/^stores/)) {
 	    unless ($_=~/\.\w+$/) { 
 		unless ($oldparmstores{$_}) {
-		    print $logfile 'New: '.$_."\n";
-		    $chparms.=$_.' ';
+		    my $disp_key = $_;
+		    $disp_key =~ tr/\0/_/;
+		    print $logfile ('New: '.$disp_key."\n");
+		    $chparms .= $disp_key.' ';
 		}
 	    }
 	}
     }
     if ($chparms) {
-	$scrout.='<p><b>'.&mt('New parameters or stored values').
+	$scrout.='<p><b>'.&mt('New parameters or saved values').
 	    ':</b> '.$chparms.'</p>';
     }
 
@@ -1061,16 +1117,18 @@ sub publish {
 	if (($_=~/^parameter/) || ($_=~/^stores/)) {
 	    unless (($metadatafields{$_.'.name'}) ||
 		    ($metadatafields{$_.'.package'}) || ($_=~/\.\w+$/)) {
-		print $logfile 'Obsolete: '.$_."\n";
-		$chparms.=$_.' ';
+		my $disp_key = $_;
+		$disp_key =~ tr/\0/_/;
+		print $logfile ('Obsolete: '.$disp_key."\n");
+		$chparms.=$disp_key.' ';
 	    }
 	}
     }
     if ($chparms) {
-	$scrout.='<p><b>'.&mt('Obsolete parameters or stored values').':</b> '.
-	    $chparms.'</p><h1><font color="red">'.&mt('Warning!').
-	    '</font></h1><p><font color="red" size="+1">'.
-	    &mt('If this resource is in active use, student performance data from the previous version may become inaccessible.').'</font></p><hr />';
+	$scrout.='<p><b>'.&mt('Obsolete parameters or saved values').':</b> '.
+	    $chparms.'</p><h1><span class="LC_warning">'.&mt('Warning!').
+	    '</span></h1><p><span class="LC_warning">'.
+	    &mt('If this resource is in active use, student performance data from the previous version may become inaccessible.').'</span></p><hr />';
     }
 
 # ------------------------------------------------------- Now have all metadata
@@ -1094,32 +1152,41 @@ sub publish {
     }
 
             
-    foreach (split(/\W+/,$metadatafields{'keywords'})) {
-	$keywords{$_}=1;
+    foreach my $addkey (split(/[\"\'\,\;]/,$metadatafields{'keywords'})) {
+	$addkey=~s/\s+/ /g;
+	$addkey=~s/^\s//;
+	$addkey=~s/\s$//;
+	if ($addkey=~/\w/) {
+	    $keywords{$addkey}=1;
+	}
     }
 # --------------------------------------------------- Now we also have keywords
 # =============================================================================
-# INTERACTIVE MODE
-#
-    unless ($batch) {
-        $scrout.=
-	    '<form name="pubform" action="/adm/publish" method="post">'.
-            '<p><input type="submit" value="'.&mt('Finalize Publication').'" /></p>'.
-            &hiddenfield('phase','two').
-            &hiddenfield('filename',$ENV{'form.filename'}).
-	    &hiddenfield('allmeta',&Apache::lonnet::escape($allmeta)).
-            &hiddenfield('dependencies',join(',',keys %allow)).
-            &textfield('Title','title',$metadatafields{'title'}).
-            &textfield('Author(s)','author',$metadatafields{'author'}).
-	    &textfield('Subject','subject',$metadatafields{'subject'});
-
-# --------------------------------------------------- Scan content for keywords
-
-        my $keywords_help = Apache::loncommon::help_open_topic("Publishing_Keywords");
-        my $KEYWORDS=&mt('Keywords');
-	my $CheckAll=&mt('check all');
-	my $UncheckAll=&mt('uncheck all');
-	my $keywordout=<<"END";
+# interactive mode html goes into $intr_scrout
+# batch mode throws away this HTML
+# additionally all of the field functions have a by product of setting
+#   $env{'from.'..} so that it can be used by the phase two handler in
+#    batch mode
+
+    my $intr_scrout.=
+	'<form name="pubform" action="/adm/publish" method="post">'.
+	'<p>'.($env{'form.makeobsolete'}?'':'<input type="submit" value="'.&mt('Finalize Publication').'" />').'</p>'.
+	&hiddenfield('phase','two').
+	&hiddenfield('filename',$env{'form.filename'}).
+	&hiddenfield('allmeta',&escape($allmeta)).
+	&hiddenfield('dependencies',join(',',keys %allow));
+    unless ($env{'form.makeobsolete'}) {
+       $intr_scrout.=
+	&textfield('Title','title',$metadatafields{'title'}).
+	&textfield('Author(s)','author',$metadatafields{'author'}).
+	&textfield('Subject','subject',$metadatafields{'subject'});
+ # --------------------------------------------------- Scan content for keywords
+
+    my $keywords_help = Apache::loncommon::help_open_topic("Publishing_Keywords");
+    my $KEYWORDS=&mt('Keywords');
+    my $CheckAll=&mt('check all');
+    my $UncheckAll=&mt('uncheck all');
+    my $keywordout=<<"END";
 <script>
 function checkAll(field) {
     for (i = 0; i < field.length; i++)
@@ -1138,153 +1205,165 @@ function uncheckAll(field) {
 </p>
 <br />
 END
-	$keywordout.='<table border="2"><tr>';
-	my $colcount=0;
+    $keywordout.='<table border="2"><tr>';
+    my $colcount=0;
 
-	foreach (sort keys %keywords) {
-	    $keywordout.='<td><input type="checkbox" name="keywords" value="'.$_.'"';
-	    if ($metadatafields{'keywords'}) {
-		if ($metadatafields{'keywords'}=~/\Q$_\E/) {
-		    $keywordout.=' checked="on"';
-		}
-	    } elsif (&Apache::loncommon::keyword($_)) {
+    foreach (sort keys %keywords) {
+	$keywordout.='<td><label><input type="checkbox" name="keywords" value="'.$_.'"';
+	if ($metadatafields{'keywords'}) {
+	    if ($metadatafields{'keywords'}=~/\Q$_\E/) {
 		$keywordout.=' checked="on"';
+		$env{'form.keywords'}.=$_.',';
 	    }
-	    $keywordout.=' />'.$_.'</td>';
-	    if ($colcount>10) {
-		$keywordout.="</tr><tr>\n";
-		$colcount=0;
-	    }
-	    $colcount++;
+	} elsif (&Apache::loncommon::keyword($_)) {
+	    $keywordout.=' checked="on"';
+	    $env{'form.keywords'}.=$_.',';
+	}
+	$keywordout.=' />'.$_.'</label></td>';
+	if ($colcount>10) {
+	    $keywordout.="</tr><tr>\n";
+	    $colcount=0;
 	}
+	$colcount++;
+    }
+    $env{'form.keywords'}=~s/\,$//;
 
-	$keywordout.='</tr></table>';
+    $keywordout.='</tr></table>';
 
-	$scrout.=$keywordout;
+    $intr_scrout.=$keywordout;
 
-	$scrout.=&textfield('Additional Keywords','addkey','');
+    $intr_scrout.=&textfield('Additional Keywords','addkey','');
 
-	$scrout.=&textfield('Notes','notes',$metadatafields{'notes'});
+    $intr_scrout.=&textfield('Notes','notes',$metadatafields{'notes'});
 
-	$scrout.=
-	    "\n<p><font color=\"#800000\" face=\"helvetica\"><b>".&mt('Abstract').":".
-	    "</b></font></p><br />".
-	    '<textarea cols="80" rows="5" name="abstract">'.
-	    $metadatafields{'abstract'}.'</textarea></p>';
+    $intr_scrout.=
+	"\n<p><font color=\"#800000\" face=\"helvetica\"><b>".&mt('Abstract').":".
+	"</b></font></p><br />".
+	'<textarea cols="80" rows="5" name="abstract">'.
+	$metadatafields{'abstract'}.'</textarea></p>';
 
-	$source=~/\.(\w+)$/;
+    $source=~/\.(\w+)$/;
 
 
-	$scrout.=
-	    "\n<p><font color=\"#800000\" face=\"helvetica\"><b>".
-	    &mt('Lowest Grade Level').':'.
-           "</b></font></p><br />".
-	   &Apache::loncommon::select_level_form($metadatafields{'lowestgradelevel'},'lowestgradelevel').
-	    "\n<p><font color=\"#800000\" face=\"helvetica\"><b>".
-	    &mt('Highest Grade Level').':'.
-           "</b></font></p><br />".
-	   &Apache::loncommon::select_level_form($metadatafields{'highestgradelevel'},'highestgradelevel').
-           &textfield('Standards','standards',$metadatafields{'standards'});
+    $intr_scrout.=
+	"\n<p><font color=\"#800000\" face=\"helvetica\"><b>".
+	&mt('Lowest Grade Level').':'.
+	"</b></font></p><br />".
+	&select_level_form($metadatafields{'lowestgradelevel'},'lowestgradelevel').
+	"\n<p><font color=\"#800000\" face=\"helvetica\"><b>".
+	&mt('Highest Grade Level').':'.
+	"</b></font></p><br />".
+	&select_level_form($metadatafields{'highestgradelevel'},'highestgradelevel').
+	&textfield('Standards','standards',$metadatafields{'standards'});
 
 
 
 
-	$scrout.=&hiddenfield('mime',$1);
+    $intr_scrout.=&hiddenfield('mime',$1);
 
-	my $defaultlanguage=$metadatafields{'language'};
-	$defaultlanguage =~ s/\s*notset\s*//g;
-	$defaultlanguage =~ s/^,\s*//g;
-	$defaultlanguage =~ s/,\s*$//g;
+    my $defaultlanguage=$metadatafields{'language'};
+    $defaultlanguage =~ s/\s*notset\s*//g;
+    $defaultlanguage =~ s/^,\s*//g;
+    $defaultlanguage =~ s/,\s*$//g;
 
-	$scrout.=&selectbox('Language','language',
-			    $defaultlanguage,
-			    \&Apache::loncommon::languagedescription,
-			    (&Apache::loncommon::languageids),
-			   );
+    $intr_scrout.=&selectbox('Language','language',
+			     $defaultlanguage,
+			     \&Apache::loncommon::languagedescription,
+			     (&Apache::loncommon::languageids),
+			     );
 
-	unless ($metadatafields{'creationdate'}) {
-	    $metadatafields{'creationdate'}=time;
-	}
-	$scrout.=&hiddenfield('creationdate',
-			      &Apache::lonmysql::unsqltime($metadatafields{'creationdate'}));
+    unless ($metadatafields{'creationdate'}) {
+	$metadatafields{'creationdate'}=time;
+    }
+    $intr_scrout.=&hiddenfield('creationdate',
+			       &Apache::lonmysql::unsqltime($metadatafields{'creationdate'}));
 
-	$scrout.=&hiddenfield('lastrevisiondate',time);
+    $intr_scrout.=&hiddenfield('lastrevisiondate',time);
 
 
-	$scrout.=&textfield('Publisher/Owner','owner',
-			    $metadatafields{'owner'});
+    $intr_scrout.=&textfield('Publisher/Owner','owner',
+			     $metadatafields{'owner'});
 
+# ---------------------------------------------- Retrofix for unused copyright
+    if ($metadatafields{'copyright'} eq 'free') {
+	$metadatafields{'copyright'}='default';
+	$metadatafields{'sourceavail'}='open';
+    }
+# ------------------------------------------------ Dial in reasonable defaults
+    my $defaultoption=$metadatafields{'copyright'};
+    unless ($defaultoption) { $defaultoption='default'; }
+    my $defaultsourceoption=$metadatafields{'sourceavail'};
+    unless ($defaultsourceoption) { $defaultsourceoption='closed'; }
+    unless ($style eq 'prv') {
 # -------------------------------------------------- Correct copyright for rat.
-        my $defaultoption=$metadatafields{'copyright'};
-        unless ($defaultoption) { $defaultoption='default'; }
-	unless ($style eq 'prv') {
-	    if ($style eq 'rat') {
-		if ($metadatafields{'copyright'} eq 'public') { 
-		    delete $metadatafields{'copyright'};
-                    $defaultoption='default';
-		}
-		$scrout.=&selectbox('Copyright/Distribution','copyright',
-				    $defaultoption,
-				    \&Apache::loncommon::copyrightdescription,
+	if ($style eq 'rat') {
+# -------------------------------------- Retrofix for non-applicable copyright
+	    if ($metadatafields{'copyright'} eq 'public') { 
+		delete $metadatafields{'copyright'};
+		$defaultoption='default';
+	    }
+	    $intr_scrout.=&selectbox('Copyright/Distribution','copyright',
+				     $defaultoption,
+				     \&Apache::loncommon::copyrightdescription,
 				    (grep !/^public$/,(&Apache::loncommon::copyrightids)));
-	    } else {
-		$scrout.=&selectbox('Copyright/Distribution','copyright',
-				    $defaultoption,
-				    \&Apache::loncommon::copyrightdescription,
-				    (&Apache::loncommon::copyrightids));
-	    }
-    
-	    my $copyright_help =
-		Apache::loncommon::help_open_topic('Publishing_Copyright');
-	    $scrout =~ s/DISTRIBUTION:/'DISTRIBUTION: ' . $copyright_help/ge;
-	    $scrout.=&textfield('Custom Distribution File','customdistributionfile',
-				$metadatafields{'customdistributionfile'}).
-				    $copyright_help;
-	    my $uctitle=&mt('Obsolete');
-            $scrout.=
-		"\n<p><font color=\"#800000\" face=\"helvetica\"><b>$uctitle:".
-		'</b></font> <input type="checkbox" name="obsolete" ';
-	    if ($metadatafields{'obsolete'}) {
-		$scrout.=' checked="1" ';
-	    }
-	    $scrout.='/ ></p>'.
-		&textfield('Suggested Replacement for Obsolete File',
-				    'obsoletereplacement',
-				    $metadatafields{'obsoletereplacement'});
 	} else {
-	    $scrout.=&hiddenfield('copyright','private');
+	    $intr_scrout.=&selectbox('Copyright/Distribution','copyright',
+				     $defaultoption,
+				     \&Apache::loncommon::copyrightdescription,
+				     (&Apache::loncommon::copyrightids));
+	}
+	my $copyright_help =
+	    Apache::loncommon::help_open_topic('Publishing_Copyright');
+	$intr_scrout =~ s/Distribution:/'Distribution: ' . $copyright_help/ge;
+	$intr_scrout.=&text_with_browse_field('Custom Distribution File','customdistributionfile',$metadatafields{'customdistributionfile'},'rights').$copyright_help;
+	$intr_scrout.=&selectbox('Source Distribution','sourceavail',
+				 $defaultsourceoption,
+				 \&Apache::loncommon::source_copyrightdescription,
+				 (&Apache::loncommon::source_copyrightids));
+#	$intr_scrout.=&text_with_browse_field('Source Custom Distribution File','sourcerights',$metadatafields{'sourcerights'},'rights');
+	my $uctitle=&mt('Obsolete');
+	$intr_scrout.=
+	    "\n<p><label><font color=\"#800000\" face=\"helvetica\"><b>$uctitle:".
+	    '</b></font> <input type="checkbox" name="obsolete" ';
+	if ($metadatafields{'obsolete'}) {
+	    $intr_scrout.=' checked="1" ';
 	}
-	return ($scrout.'<p><input type="submit" value="'.
-		&mt('Finalize Publication').'" /></p></form>',0);
-# =============================================================================
-# BATCH MODE
-#
+	$intr_scrout.='/ ></label></p>'.
+	    &text_with_browse_field('Suggested Replacement for Obsolete File',
+				    'obsoletereplacement',
+				    $metadatafields{'obsoletereplacement'});
     } else {
-# Transfer metadata directly to environment for stage 2
-	foreach (keys %metadatafields) {
-	    $ENV{'form.'.$_}=$metadatafields{$_};
-	}
-	$ENV{'form.addkey'}='';
-	$ENV{'form.keywords'}='';
-	foreach (keys %keywords) {
-	    if ($metadatafields{'keywords'}) {
-		if ($metadatafields{'keywords'}=~/\Q$_\E/) { 
-		    $ENV{'form.keywords'}.=$_.','; 
-		}
-	    } elsif (&Apache::loncommon::keyword($_)) {
-		$ENV{'form.keywords'}.=$_.',';
-	    }
-	}
-	$ENV{'form.keywords'}=~s/\,$//;
-	unless ($ENV{'form.creationdate'}) { $ENV{'form.creationdate'}=time; }
-	$ENV{'form.lastrevisiondate'}=time;
-	if ((($style eq 'rat') && ($ENV{'form.copyright'} eq 'public')) ||
-	    (!$ENV{'form.copyright'})) { 
-	    $ENV{'form.copyright'}='default';
-	}
-	$ENV{'form.allmeta'}=&Apache::lonnet::escape($allmeta);
-	return ($scrout,0);
+	$intr_scrout.=&hiddenfield('copyright','private');
+    }
+   } else {
+       $intr_scrout.=
+	&hiddenfield('title',$metadatafields{'title'}).
+	&hiddenfield('author',$metadatafields{'author'}).
+	&hiddenfield('subject',$metadatafields{'subject'}).
+	&hiddenfield('keywords',$metadatafields{'keywords'}).
+	&hiddenfield('abstract',$metadatafields{'abstract'}).
+	&hiddenfield('notes',$metadatafields{'notes'}).
+	&hiddenfield('mime',$metadatafields{'mime'}).
+	&hiddenfield('creationdate',$metadatafields{'creationdate'}).
+	&hiddenfield('lastrevisiondate',time).
+	&hiddenfield('owner',$metadatafields{'owner'}).
+	&hiddenfield('lowestgradelevel',$metadatafields{'lowestgradelevel'}).
+	&hiddenfield('standards',$metadatafields{'standards'}).
+	&hiddenfield('highestgradelevel',$metadatafields{'highestgradelevel'}).
+	&hiddenfield('language',$metadatafields{'language'}).
+	&hiddenfield('copyright',$metadatafields{'copyright'}).
+	&hiddenfield('sourceavail',$metadatafields{'sourceavail'}).
+	&hiddenfield('customdistributionfile',$metadatafields{'customdistributionfile'}).
+	&hiddenfield('obsolete',1).
+	&text_with_browse_field('Suggested Replacement for Obsolete File',
+				    'obsoletereplacement',
+				    $metadatafields{'obsoletereplacement'});
+   }
+    if (!$batch) {
+	$scrout.=$intr_scrout.'<p><input type="submit" value="'.
+	    &mt($env{'form.makeobsolete'}?'Make Obsolete':'Finalize Publication').'" /></p></form>';
     }
+    return($scrout,0);
 }
 
 #########################################
@@ -1315,10 +1394,10 @@ Returns:
 
 =over 4
 
-=item Scalar string
+=item integer
 
-String contains status (errors and warnings) and information associated with
-the server's attempts at publication.     
+0: fail
+1: success
 
 =cut
 
@@ -1330,13 +1409,29 @@ sub phasetwo {
     my ($r,$source,$target,$style,$distarget,$batch)=@_;
     $source=~s/\/+/\//g;
     $target=~s/\/+/\//g;
-
-    if ($target=~/\_\_\_/) {
-	$r->print(
- '<font color="red">'.&mt('Unsupported character combination').
-		  ' "<tt>___</tt>" '.&mt('in filename, FAIL').'</font>');
-        return 0;
+#
+# Unless trying to get rid of something, check name validity
+#
+    unless ($env{'form.obsolete'}) {
+	if ($target=~/(\_\_\_|\&\&\&|\:\:\:)/) {
+	    $r->print(
+		      '<font color="red">'.&mt('Unsupported character combination').
+		      ' "<tt>'.$1.'</tt>" '.&mt('in filename, FAIL').'</font>');
+	    return 0;
+	}
+	unless ($target=~/\.(\w+)$/) {
+	    $r->print('<font color="red">'.&mt('No valid extension found in filename, FAIL').'</font>');
+	    return 0;
+	}
+	if ($target=~/\.(\d+)\.(\w+)$/) {
+	    $r->print('<font color="red">'.&mt('Cannot publish versioned resource, FAIL').'</font>');
+	    return 0;
+	}
     }
+
+#
+# End name check
+#
     $distarget=~s/\/+/\//g;
     my $logfile;
     unless ($logfile=Apache::File->new('>>'.$source.'.log')) {
@@ -1346,65 +1441,72 @@ sub phasetwo {
         return 0;
     }
     print $logfile 
-        "\n================= Publish ".localtime()." Phase Two  ================\n".$ENV{'user.name'}.'@'.$ENV{'user.domain'}."\n";
+        "\n================= Publish ".localtime()." Phase Two  ================\n".$env{'user.name'}.':'.$env{'user.domain'}."\n";
     
     %metadatafields=();
     %metadatakeys=();
+
+    &metaeval(&unescape($env{'form.allmeta'}));
     
-    &metaeval(&Apache::lonnet::unescape($ENV{'form.allmeta'}));
-    
-    $metadatafields{'title'}=$ENV{'form.title'};
-    $metadatafields{'author'}=$ENV{'form.author'};
-    $metadatafields{'subject'}=$ENV{'form.subject'};
-    $metadatafields{'notes'}=$ENV{'form.notes'};
-    $metadatafields{'abstract'}=$ENV{'form.abstract'};
-    $metadatafields{'mime'}=$ENV{'form.mime'};
-    $metadatafields{'language'}=$ENV{'form.language'};
-    $metadatafields{'creationdate'}=$ENV{'form.creationdate'};
-    $metadatafields{'lastrevisiondate'}=$ENV{'form.lastrevisiondate'};
-    $metadatafields{'owner'}=$ENV{'form.owner'};
-    $metadatafields{'copyright'}=$ENV{'form.copyright'};
-    $metadatafields{'standards'}=$ENV{'form.standards'};
-    $metadatafields{'lowestgradelevel'}=$ENV{'form.lowestgradelevel'};
-    $metadatafields{'highestgradelevel'}=$ENV{'form.highestgradelevel'};
+    $metadatafields{'title'}=$env{'form.title'};
+    $metadatafields{'author'}=$env{'form.author'};
+    $metadatafields{'subject'}=$env{'form.subject'};
+    $metadatafields{'notes'}=$env{'form.notes'};
+    $metadatafields{'abstract'}=$env{'form.abstract'};
+    $metadatafields{'mime'}=$env{'form.mime'};
+    $metadatafields{'language'}=$env{'form.language'};
+    $metadatafields{'creationdate'}=$env{'form.creationdate'};
+    $metadatafields{'lastrevisiondate'}=$env{'form.lastrevisiondate'};
+    $metadatafields{'owner'}=$env{'form.owner'};
+    $metadatafields{'copyright'}=$env{'form.copyright'};
+    $metadatafields{'standards'}=$env{'form.standards'};
+    $metadatafields{'lowestgradelevel'}=$env{'form.lowestgradelevel'};
+    $metadatafields{'highestgradelevel'}=$env{'form.highestgradelevel'};
     $metadatafields{'customdistributionfile'}=
-                                 $ENV{'form.customdistributionfile'};
-    $metadatafields{'obsolete'}=$ENV{'form.obsolete'};
+                                 $env{'form.customdistributionfile'};
+    $metadatafields{'sourceavail'}=$env{'form.sourceavail'};
+    $metadatafields{'obsolete'}=$env{'form.obsolete'};
     $metadatafields{'obsoletereplacement'}=
-	                        $ENV{'form.obsoletereplacement'};
-    $metadatafields{'dependencies'}=$ENV{'form.dependencies'};
-    $metadatafields{'modifyinguser'}=$ENV{'user.name'}.'@'.
-	                                 $ENV{'user.domain'};
-    $metadatafields{'authorspace'}=$cuname.'@'.$cudom;
+	                        $env{'form.obsoletereplacement'};
+    $metadatafields{'dependencies'}=$env{'form.dependencies'};
+    $metadatafields{'modifyinguser'}=$env{'user.name'}.':'.
+	                                 $env{'user.domain'};
+    $metadatafields{'authorspace'}=$cuname.':'.$cudom;
+    $metadatafields{'domain'}=$cudom;
     
-    my $allkeywords=$ENV{'form.addkey'};
-    if (exists($ENV{'form.keywords'})) {
-        if (ref($ENV{'form.keywords'})) {
-            $allkeywords .= ','.join(',',@{$ENV{'form.keywords'}});
+    my $allkeywords=$env{'form.addkey'};
+    if (exists($env{'form.keywords'})) {
+        if (ref($env{'form.keywords'})) {
+            $allkeywords .= ','.join(',',@{$env{'form.keywords'}});
         } else {
-            $allkeywords .= ','.$ENV{'form.keywords'};
+            $allkeywords .= ','.$env{'form.keywords'};
         }
     }
-    $allkeywords=~s/\W+/\,/;
-    $allkeywords=~s/^\,//;
+    $allkeywords=~s/[\"\']//g;
+    $allkeywords=~s/\s*[\;\,]\s*/\,/g;
+    $allkeywords=~s/\s+/ /g;
+    $allkeywords=~s/^[ \,]//;
+    $allkeywords=~s/[ \,]$//;
     $metadatafields{'keywords'}=$allkeywords;
     
 # check if custom distribution file is specified
     if ($metadatafields{'copyright'} eq 'custom') {
 	my $file=$metadatafields{'customdistributionfile'};
 	unless ($file=~/\.rights$/) {
-            return 
+            $r->print(
                 '<font color="red">'.&mt('No valid custom distribution rights file specified, FAIL').
-		'</font>';
+		'</font>');
+	    return 0;
         }
     }
     {
         print $logfile "\nWrite metadata file for ".$source;
         my $mfh;
         unless ($mfh=Apache::File->new('>'.$source.'.meta')) {
-            return 
+            $r->print( 
                 '<font color="red">'.&mt('Could not write metadata, FAIL').
-		'</font>';
+		'</font>');
+	    return 0;
         }
         foreach (sort keys %metadatafields) {
             unless ($_=~/\./) {
@@ -1419,7 +1521,7 @@ sub phasetwo {
                     print $mfh ' '.$_.'="'.$value.'"';
                 }
                 print $mfh '>'.
-                    &HTML::Entities::encode($metadatafields{$unikey})
+                    &HTML::Entities::encode($metadatafields{$unikey},'<>&"')
                         .'</'.$tag.'>';
             }
         }
@@ -1455,7 +1557,9 @@ sub phasetwo {
         my $srcd=$1;
         unless ($srcd=~/^\/home\/httpd\/html\/res/) {
             print $logfile "\nPANIC: Target dir is ".$srcd;
-            return "<font color=\"red\">Invalid target directory, FAIL</font>";
+            $r->print(
+	 "<font color=\"red\">Invalid target directory, FAIL</font>");
+	    return 0;
         }
         opendir(DIR,$srcd);
         while ($filename=readdir(DIR)) {
@@ -1480,8 +1584,9 @@ sub phasetwo {
             $r->print('<p>'.&mt('Copied old target file').'</p>');
         } else {
 	    print $logfile "Unable to write ".$copyfile.':'.$!."\n";
-            return "<font color=\"red\">".&mt('Failed to copy old target').
-		", $!, ".&mt('FAIL')."</font>";
+            $r->print("<font color=\"red\">".&mt('Failed to copy old target').
+		", $!, ".&mt('FAIL')."</font>");
+	    return 0;
         }
         
 # --------------------------------------------------------------- Copy Metadata
@@ -1494,9 +1599,10 @@ sub phasetwo {
         } else {
 	    print $logfile "Unable to write metadata ".$copyfile.':'.$!."\n";
             if (-e $target.'.meta') {
-                return 
+                $r->print( 
                     "<font color=\"red\">".
-&mt('Failed to write old metadata copy').", $!, ".&mt('FAIL')."</font>";
+&mt('Failed to write old metadata copy').", $!, ".&mt('FAIL')."</font>");
+		return 0;
 	    }
         }
         
@@ -1527,8 +1633,9 @@ sub phasetwo {
         $r->print('<p>'.&mt('Copied source file').'</p>');
     } else {
         print $logfile "\nUnable to write ".$copyfile.':'.$!."\n";
-        return "<font color=\"red\">".
-	    &mt('Failed to copy source').", $!, ".&mt('FAIL')."</font>";
+        $r->print("<font color=\"red\">".
+	    &mt('Failed to copy source').", $!, ".&mt('FAIL')."</font>");
+	return 0;
     }
     
 # --------------------------------------------------------------- Copy Metadata
@@ -1540,53 +1647,31 @@ sub phasetwo {
         $r->print('<p>'.&mt('Copied metadata').'</p>');
     } else {
         print $logfile "\nUnable to write metadata ".$copyfile.':'.$!."\n";
-        return 
-            "<font color=\"red\">".&mt('Failed to write metadata copy').", $!, ".&mt('FAIL')."</font>";
+        $r->print(
+            "<font color=\"red\">".&mt('Failed to write metadata copy').", $!, ".&mt('FAIL')."</font>");
+	return 0;
     }
     $r->rflush;
-# --------------------------------------------------- Send update notifications
 
-    my @subscribed=&get_subscribed_hosts($target);
-    foreach my $subhost (@subscribed) {
-	$r->print('<p>'.&mt('Notifying host').' '.$subhost.':');$r->rflush;
-	print $logfile "\nNotifying host ".$subhost.':';
-	my $reply=&Apache::lonnet::critical('update:'.$target,$subhost);
-	$r->print($reply.'</p><br />');$r->rflush;
-	print $logfile $reply;
+# ------------------------------------------------------------- Trigger updates
+    push(@{$modified_urls},[$target,$source]);
+    unless ($registered_cleanup) {
+	$r->register_cleanup(\&notify);
+	$registered_cleanup=1;
     }
-    
-# ---------------------------------------- Send update notifications, meta only
 
-    my @subscribedmeta=&get_subscribed_hosts("$target.meta");
-    foreach my $subhost (@subscribedmeta) {
-	$r->print('<p>'.
-&mt('Notifying host for metadata only').' '.$subhost.':');$r->rflush;
-	print $logfile "\nNotifying host for metadata only ".$subhost.':';
-	my $reply=&Apache::lonnet::critical('update:'.$target.'.meta',
-					    $subhost);
-	$r->print($reply.'</p><br />');$r->rflush;
-	print $logfile $reply;
-    }
-    
-# --------------------------------------------------- Notify subscribed courses
-    my %courses=&coursedependencies($target);
-    my $now=time;
-    foreach (keys %courses) {
-	$r->print('<p>'.&mt('Notifying course').' '.$_.':');$r->rflush;
-	print $logfile "\nNotifying host ".$_.':';
-        my ($cdom,$cname)=split(/\_/,$_);
-	my $reply=&Apache::lonnet::cput
-                  ('versionupdate',{$target => $now},$cdom,$cname);
-	$r->print($reply.'</p><br />');$r->rflush;
-	print $logfile $reply;
-    }
+# ---------------------------------------------------------- Clear local caches
+    my $thisdistarget=$target;
+    $thisdistarget=~s/^\Q$docroot\E//;
+    &Apache::lonnet::devalidate_cache_new('resversion',$target);
+    &Apache::lonnet::devalidate_cache_new('meta',
+			 &Apache::lonnet::declutter($thisdistarget));
+
 # ------------------------------------------------ Provide link to new resource
     unless ($batch) {
-        my $thisdistarget=$target;
-        $thisdistarget=~s/^\Q$docroot\E//;
         
         my $thissrc=$source;
-        $thissrc=~s/^\/home\/(\w+)\/public_html/\/priv\/$1/;
+        $thissrc=~s{^/home/($match_username)/public_html}{/priv/$1};
         
         my $thissrcdir=$thissrc;
         $thissrcdir=~s/\/[^\/]+$/\//;
@@ -1601,15 +1686,54 @@ sub phasetwo {
                    '"><font size="+2">'.
 		  &mt('Back to Source Directory').'</font></a></p>');
     }
-    return '<p><font color="green">'.&mt('Done').'</font></p>';
+    $logfile->close();
+    $r->print('<p><font color="green">'.&mt('Done').'</font></p>');
+    return 1;
+}
+
+# =============================================================== Notifications
+sub notify {  
+# --------------------------------------------------- Send update notifications
+    foreach my $targetsource (@{$modified_urls}){
+	my ($target,$source)=@{$targetsource};
+	my $logfile=Apache::File->new('>>'.$source.'.log');
+	print $logfile "\nCleanup phase: Notifications\n";
+	my @subscribed=&get_subscribed_hosts($target);
+	foreach my $subhost (@subscribed) {
+	    print $logfile "\nNotifying host ".$subhost.':';
+	    my $reply=&Apache::lonnet::critical('update:'.$target,$subhost);
+	    print $logfile $reply;
+	}
+# ---------------------------------------- Send update notifications, meta only
+	my @subscribedmeta=&get_subscribed_hosts("$target.meta");
+	foreach my $subhost (@subscribedmeta) {
+	    print $logfile "\nNotifying host for metadata only ".$subhost.':';
+	    my $reply=&Apache::lonnet::critical('update:'.$target.'.meta',
+						$subhost);
+	    print $logfile $reply;
+	} 
+# --------------------------------------------------- Notify subscribed courses
+	my %courses=&coursedependencies($target);
+	my $now=time;
+	foreach (keys %courses) {
+	    print $logfile "\nNotifying course ".$_.':';
+	    my ($cdom,$cname)=split(/\_/,$_);
+	    my $reply=&Apache::lonnet::cput
+		('versionupdate',{$target => $now},$cdom,$cname);
+	    print $logfile $reply;
+	}
+	print $logfile "\n============ Done ============\n";
+	$logfile->close();
+    }
+    return OK;
 }
 
 #########################################
 
 sub batchpublish {
     my ($r,$srcfile,$targetfile)=@_;
-    #publication pollutes %ENV with form.* values
-    my %oldENV=%ENV;
+    #publication pollutes %env with form.* values
+    my %oldenv=%env;
     $srcfile=~s/\/+/\//g;
     $targetfile=~s/\/+/\//g;
     my $thisdisfn=$srcfile;
@@ -1637,13 +1761,13 @@ sub batchpublish {
     $r->print('<p>'.$outstring.'</p>');
 # phase two takes
 # my ($source,$target,$style,$distarget,batch)=@_;
-# $ENV{'form.allmeta'},$ENV{'form.title'},$ENV{'form.author'},...
+# $env{'form.allmeta'},$env{'form.title'},$env{'form.author'},...
     if (!$error) {
 	$r->print('<p>');
 	&phasetwo($r,$srcfile,$targetfile,$thisembstyle,$thisdistarget,1);
 	$r->print('</p>');
     }
-    %ENV=%oldENV;
+    %env=%oldenv;
     return '';
 }
 
@@ -1660,47 +1784,65 @@ sub publishdirectory {
 	      &mt('Target').': <tt>'.$resdir.'</tt><br />');
 
     my $dirptr=16384;		# Mask indicating a directory in stat.cmode.
-
-    opendir(DIR,$fn);
-    my @files=sort(readdir(DIR));
-    foreach my $filename (@files) {
-	my ($cdev,$cino,$cmode,$cnlink,
-            $cuid,$cgid,$crdev,$csize,
-            $catime,$cmtime,$cctime,
-            $cblksize,$cblocks)=stat($fn.'/'.$filename);
-
-	my $extension='';
-	if ($filename=~/\.(\w+)$/) { $extension=$1; }
-	if ($cmode&$dirptr) {
-	    if (($filename!~/^\./) && ($ENV{'form.pubrec'})) {
-		&publishdirectory($r,$fn.'/'.$filename,$thisdisfn.'/'.$filename);
-	    }
-	} elsif ((&Apache::loncommon::fileembstyle($extension) ne 'hdn') &&
-		 ($filename!~/^[\#\.]/) && ($filename!~/\~$/)) {
+    unless ($env{'form.phase'} eq 'two') {
+# ask user what they want
+        $r->print('<form name="pubdirpref" method="post">'.
+		  &hiddenfield('phase','two').
+		  &hiddenfield('filename',$env{'form.filename'}).
+		  &checkbox('pubrec','include subdirectories').
+		  &checkbox('forcerepub','force republication of previously published files').
+                  &checkbox('obsolete','make file(s) obsolete').
+		  &checkbox('forceoverride','force directory level catalog information over existing').
+		  '<br /><input type="submit" value="'.&mt('Publish Directory').'" /></form>');
+    } else {
+# actually publish things
+	opendir(DIR,$fn);
+	my @files=sort(readdir(DIR));
+	foreach my $filename (@files) {
+	    my ($cdev,$cino,$cmode,$cnlink,
+		$cuid,$cgid,$crdev,$csize,
+		$catime,$cmtime,$cctime,
+		$cblksize,$cblocks)=stat($fn.'/'.$filename);
+	    
+	    my $extension='';
+	    if ($filename=~/\.(\w+)$/) { $extension=$1; }
+	    if ($cmode&$dirptr) {
+		if (($filename!~/^\./) && ($env{'form.pubrec'})) {
+		    &publishdirectory($r,$fn.'/'.$filename,$thisdisfn.'/'.$filename);
+		}
+	    } elsif ((&Apache::loncommon::fileembstyle($extension) ne 'hdn') &&
+		     ($filename!~/^[\#\.]/) && ($filename!~/\~$/)) {
 # find out publication status and/or exiting metadata
-	    my $publishthis=0;
-	    if (-e $resdir.'/'.$filename) {
-	        my ($rdev,$rino,$rmode,$rnlink,
-		    $ruid,$rgid,$rrdev,$rsize,
-		    $ratime,$rmtime,$rctime,
-		    $rblksize,$rblocks)=stat($resdir.'/'.$filename);
-	        if (($rmtime<$cmtime) || ($ENV{'form.forcerepub'})) {
+		my $publishthis=0;
+		if (-e $resdir.'/'.$filename) {
+		    my ($rdev,$rino,$rmode,$rnlink,
+			$ruid,$rgid,$rrdev,$rsize,
+			$ratime,$rmtime,$rctime,
+			$rblksize,$rblocks)=stat($resdir.'/'.$filename);
+		    if (($rmtime<$cmtime) || ($env{'form.forcerepub'})) {
 # previously published, modified now
-		    $publishthis=1;
-                }
-	    } else {
+			$publishthis=1;
+		    }
+		    my $meta_cmtime = (stat($fn.'/'.$filename.'.meta'))[9];
+		    my $meta_rmtime = (stat($resdir.'/'.$filename.'.meta'))[9];
+		    if ( $meta_rmtime<$meta_cmtime ) {
+			$publishthis=1;
+		    }
+		} else {
 # never published
-		$publishthis=1;
-	    }
-	    if ($publishthis) {
-                &batchpublish($r,$fn.'/'.$filename,$resdir.'/'.$filename);
-	    } else {
-		$r->print('<br />'.&mt('Skipping').' '.$filename.'<br />');
+		    $publishthis=1;
+		}
+		
+		if ($publishthis) {
+		    &batchpublish($r,$fn.'/'.$filename,$resdir.'/'.$filename);
+		} else {
+		    $r->print('<br />'.&mt('Skipping').' '.$filename.'<br />');
+		}
+		$r->rflush();
 	    }
-	    $r->rflush();
 	}
+	closedir(DIR);
     }
-    closedir(DIR);
 }
 
 #########################################
@@ -1719,8 +1861,7 @@ sub defaultmetapublish {
     &Apache::loncommon::content_type($r,'text/html');
     $r->send_http_header;
 
-    $r->print('<html><head><title>LON-CAPA Publishing</title></head>');
-    $r->print(&Apache::loncommon::bodytag('Catalog Information Publication'));
+    $r->print(&Apache::loncommon::start_page('Catalog Information Publication'));
 
 # ---------------------------------------------------------------- Write Source
     my $copyfile=$target;
@@ -1756,7 +1897,7 @@ sub defaultmetapublish {
     my $link=$fn;
     $link=~s/^\/home\/$cuname\/public_html\//\/priv\/$cuname\//;
     $r->print("<a href='$link'>".&mt('Back to Catalog Information').'</a>');
-    $r->print('</body></html>');
+    $r->print(&Apache::loncommon::end_page());
     return OK;
 }
 #########################################
@@ -1813,9 +1954,12 @@ sub handler {
     &Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'},
                                             ['filename']);
 
+# -------------------------------------- Flag and buffer for registered cleanup
+    $registered_cleanup=0;
+    @{$modified_urls}=();
 # -------------------------------------------------------------- Check filename
 
-    my $fn=&Apache::lonnet::unescape($ENV{'form.filename'});
+    my $fn=&unescape($env{'form.filename'});
 
     ($cuname,$cudom)=
 	&Apache::loncacc::constructaccess($fn,$r->dir_config('lonDefDomain'));
@@ -1834,7 +1978,7 @@ sub handler {
 
     unless (($cuname) && ($cudom)) {
 	$r->log_reason($cuname.' at '.$cudom.
-		       ' trying to publish file '.$ENV{'form.filename'}.
+		       ' trying to publish file '.$env{'form.filename'}.
 		       ' ('.$fn.') - not authorized', 
 		       $r->filename); 
 	return HTTP_NOT_ACCEPTABLE;
@@ -1846,21 +1990,21 @@ sub handler {
     foreach my $id (@ids) { if ($id eq $home) { $allowed = 1; }  }
     unless ($allowed) {
 	$r->log_reason($cuname.' at '.$cudom.
-		       ' trying to publish file '.$ENV{'form.filename'}.
+		       ' trying to publish file '.$env{'form.filename'}.
 		       ' ('.$fn.') - not homeserver ('.$home.')', 
 		       $r->filename); 
 	return HTTP_NOT_ACCEPTABLE;
     }
 
-    $fn=~s/^http\:\/\/[^\/]+//;
-    $fn=~s/^\/\~(\w+)/\/home\/$1\/public_html/;
+    $fn=~s{^http://[^/]+}{};
+    $fn=~s{^/~($match_username)}{/home/$1/public_html};
 
     my $targetdir='';
     $docroot=$r->dir_config('lonDocRoot'); 
     if ($1 ne $cuname) {
 	$r->log_reason($cuname.' at '.$cudom.
 		       ' trying to publish unowned file '.
-		       $ENV{'form.filename'}.' ('.$fn.')', 
+		       $env{'form.filename'}.' ('.$fn.')', 
 		       $r->filename); 
 	return HTTP_NOT_ACCEPTABLE;
     } else {
@@ -1871,44 +2015,42 @@ sub handler {
     unless (-e $fn) { 
 	$r->log_reason($cuname.' at '.$cudom.
 		       ' trying to publish non-existing file '.
-		       $ENV{'form.filename'}.' ('.$fn.')', 
+		       $env{'form.filename'}.' ('.$fn.')', 
 		       $r->filename); 
 	return HTTP_NOT_FOUND;
     } 
 
-    unless ($ENV{'form.phase'} eq 'two') {
-
 # -------------------------------- File is there and owned, init lookup tables.
 
-	%addid=();
-
-	{
-	    my $fh=Apache::File->new($r->dir_config('lonTabDir').'/addid.tab');
-	    while (<$fh>=~/(\w+)\s+(\w+)/) {
-		$addid{$1}=$2;
-	    }
+    %addid=();
+    
+    {
+	my $fh=Apache::File->new($r->dir_config('lonTabDir').'/addid.tab');
+	while (<$fh>=~/(\w+)\s+(\w+)/) {
+	    $addid{$1}=$2;
 	}
+    }
 
-	%nokey=();
+    %nokey=();
 
-	{
-	    my $fh=Apache::File->new($r->dir_config('lonIncludes').'/un_keyword.tab');
-	    while (<$fh>) {
-		my $word=$_;
-		chomp($word);
-		$nokey{$word}=1;
-	    }
+    {
+	my $fh=Apache::File->new($r->dir_config('lonIncludes').'/un_keyword.tab');
+	while (<$fh>) {
+	    my $word=$_;
+	    chomp($word);
+	    $nokey{$word}=1;
 	}
-
     }
 
 # ---------------------------------------------------------- Start page output.
 
     &Apache::loncommon::content_type($r,'text/html');
     $r->send_http_header;
-
-    $r->print('<html><head><title>LON-CAPA Publishing</title></head>');
-    $r->print(&Apache::loncommon::bodytag('Resource Publication'));
+    
+    my $js='<script type="text/javascript">'.
+	&Apache::loncommon::browser_and_searcher_javascript().
+	'</script>';
+    $r->print(&Apache::loncommon::start_page('Resource Publication',$js));
 
 
     my $thisfn=$fn;
@@ -1927,7 +2069,7 @@ sub handler {
     if ($fn=~/\/$/) {
 # -------------------------------------------------------- This is a directory
 	&publishdirectory($r,$fn,$thisdisfn);
-	$r->print('<hr><font size="+2">'.&mt('Done').'</font><br><a href="/priv/'
+	$r->print('<hr /><a href="/priv/'
 		  .$cuname.'/'.$thisdisfn
 		  .'">'.&mt('Return to Directory').'</a>');
 
@@ -1937,6 +2079,7 @@ sub handler {
 	$thisfn=~/\.(\w+)$/;
 	my $thistype=$1;
 	my $thisembstyle=&Apache::loncommon::fileembstyle($thistype);
+        if ($thistype eq 'page') {  $thisembstyle = 'rat'; }
 	$r->print('<h2>'.&mt('Publishing').' '.
 		  &Apache::loncommon::filedescription($thistype).' <tt>');
 
@@ -1947,7 +2090,7 @@ ENDCAPTION
         $r->print('</tt></h2><b>'.&mt('Target').':</b> <tt>'.
 		  $thisdistarget.'</tt><br />');
    
-	if (($cuname ne $ENV{'user.name'})||($cudom ne $ENV{'user.domain'})) {
+	if (($cuname ne $env{'user.name'})||($cudom ne $env{'user.domain'})) {
 	    $r->print('<h3><font color="red">'.&mt('Co-Author').': '.
 		      $cuname.&mt(' at ').$cudom.'</font></h3>');
 	}
@@ -1962,15 +2105,27 @@ ENDDIFF
   
 # ------------------ Publishing from $thisfn to $thistarget with $thisembstyle.
 
-	unless ($ENV{'form.phase'} eq 'two') {
-	    my ($outstring,$error)=&publish($thisfn,$thistarget,$thisembstyle);
-	    $r->print('<hr />'.$outstring);
+	unless ($env{'form.phase'} eq 'two') {
+# ---------------------------------------------------------- Parse for problems
+	    my ($warningcount,$errorcount);
+	    if ($thisembstyle eq 'ssi') {
+		($warningcount,$errorcount)=&checkonthis($r,$thisfn);
+	    }
+	    unless ($errorcount) {
+		my ($outstring,$error)=
+		    &publish($thisfn,$thistarget,$thisembstyle);
+		$r->print('<hr />'.$outstring);
+	    } else {
+		$r->print('<h3>'.
+			  &mt('The document contains errors and cannot be published.').
+			  '</h3>');
+	    }
 	} else {
-	    $r->print('<hr />'.
-	    &phasetwo($r,$thisfn,$thistarget,$thisembstyle,$thisdistarget)); 
+	    &phasetwo($r,$thisfn,$thistarget,$thisembstyle,$thisdistarget); 
+	    $r->print('<hr />');
 	}
     }
-    $r->print('</body></html>');
+    $r->print(&Apache::loncommon::end_page());
 
     return OK;
 }